Opened 13 years ago
Closed 13 years ago
#9507 closed Patch - Bug Fix (Fixed)
[patch] OpenGL bicubic filter (legacy)
| Reported by: | Owned by: | Janne Grunau | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.25 |
| Component: | MythTV - Video Playback | Version: | Master Head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
This patch fixing:
- A bug introduced in commit https://github.com/MythTV/mythtv/commit/61453e219 causing bottom and left screen pixel shimering (green or/and random pixels)
- Adding support for rectangual textures when using openglbicubic resizer.
Optimal will be chage also:
"MAD coord.xy, fragment.texcoord[0], {%6, %7}, {0.5, 0.5};\n"
to
"ADD coord.xy, fragment.texcoord[0], {0.5, 0.5};\n"
when using rectangual texture but diference betwen those two instructions are negligible.
Changes was tested with Radeon X1300 opensource drivers (gallium and classsic) with legacy profile, since high profile is not finished yet.
Jiri
Attachments (1)
Change History (2)
Changed 13 years ago by
| Attachment: | 101-bicubic_rect_fix.patch added |
|---|
comment:1 Changed 13 years ago by
| Milestone: | unknown → 0.25 |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
Jiri
Thanks for the patch. I've applied the offset fix in a080886c2a97d7da942b. The use of rectangular textures does not work here (makes a complete mess of the video) and indeed should not work - the speedup used by that fragment program is very much dependent on bilinear sampling in conjunction with 2d textures (texture coords in the 0..1 range rather than 0...720 etc)
regards, Mark
the patch