[PATCH] Mythbrowser does not use proxy set in http_proxy environment variable

[jan.ceuleers@…]

The http_proxy environment variable is correctly set, and it is being used by various parts of the MythTV universe as well as other bits of the system, but not Mythbrowser. I found this by observing the squid logfiles while using Mythbrowser.

This means that Mythbrowser may be unnecessarily slow.

Michael T. Dean suggested on the users mailing list that the solution may be found here:

​http://blog.mrcongwang.com/2009/07/21/applying-system-proxy-settings-to-qt-application/

[robertm]

Closing as a feature request without patch-- if you would like to work up a patch and attach it, please feel free to reopen.

[E. Westbrook <mythtv-trac@…>]

Add support for http_proxy environment variable

[E. Westbrook <mythtv-trac@…>]

Patch attached; please review, re-open, or other action as appropriate.

[nigel@…]

1. I wanted to add proxy support for CDDB lookups many years ago, but that required a different way to do the lookups. When (if?) HttpComms is used for that, it should be the location for doing proxy-compatible stuff?
2. My gut feeling is that using an environment variable is a little clumsy - I would have preferred a setting from the database, but then that is just another thing that needs a settings UI.
3. Mac OS X and Windows supposedly have hooks to look up the system proxy settings via QNetworkProxyFactory::systemProxyForQuery(). I find it hard to believe that the Linux environments don't have a standard proxy setting location these days?
4. Now that the backend also does HTTP traffic, it also needs to set proxy "environment"s?

Paul, my work has a few corporate proxies - I'm happy to take this is you don't have any burning desire.

[paulh]

Replying to nigel@…:

1. I wanted to add proxy support for CDDB lookups many years ago, but that required a different way to do the lookups. When (if?) HttpComms is used for that, it should be the location for doing proxy-compatible stuff?
2. My gut feeling is that using an environment variable is a little clumsy - I would have preferred a setting from the database, but then that is just another thing that needs a settings UI.
3. Mac OS X and Windows supposedly have hooks to look up the system proxy settings via QNetworkProxyFactory::systemProxyForQuery(). I find it hard to believe that the Linux environments don't have a standard proxy setting location these days?
4. Now that the backend also does HTTP traffic, it also needs to set proxy "environment"s?

Paul, my work has a few corporate proxies - I'm happy to take this is you don't have any burning desire.

I have no use for this so you're welcome to it :)

[Github]

Use HTTP_PROXY env. var. for MythBrowser? and other QHttp. Refs #9525.

Now also supports Mac OS X and windows, though only tested on the former. Compared to the original patch, this is horrendously complicated, but given that Qt's proxy support is hidden deep down without debugging, I think having sanity checking up front is useful.

Branch: master Changeset: 01f1c9215ffd54e19716ab35101fc6f41f4ddc81

[beirdo]

With Nigel's commit 5 months ago, it seems that the intent of this ticket has been completed.