Modify

Ticket #9535 (closed Patch - Feature: fixed)

Opened 2 years ago

Last modified 16 months ago

Minor cleanup after #8901

Reported by: Jim Stichnoth <stichnot@…> Owned by: mdean
Priority: minor Milestone: 0.25
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After the changes in #8901, the PlayerContext? argument to most DeleteMap? methods is now redundant since the PlayerContext? pointer is now cached in the DeleteMap? object. This patch provides the cleanup.

Attachments

8901_cleanup.patch (13.1 KB) - added by Jim Stichnoth <stichnot@…> 2 years ago.

Change History

Changed 2 years ago by Jim Stichnoth <stichnot@…>

comment:1 Changed 2 years ago by mdean

  • Owner changed from janne to mdean
  • Status changed from new to accepted

comment:2 Changed 16 months ago by Github

  • Status changed from accepted to closed
  • Resolution set to fixed
  • Milestone changed from unknown to 0.25

Clean up PlayerContext? usage after editor undo/redo feature.

Remove redundant PlayerContext? function arguments after PlayerContext? was made a DeleteMap? member variable in 0791662a7.

Closes #9535.

Signed-off-by: Michael T. Dean <mdean@…>

Branch: master Changeset: 143bd71be80d7b9a31f64c9e6389fced6aec224f

comment:3 Changed 16 months ago by Github

Fix saving edits after editor cleanup.

Leftover argument caused edits to save as "autosave" lists, so that they weren't actually applied during playback, but looked correct in editing.

Refs #9535

Signed-off-by: Michael T. Dean <mdean@…>

Branch: master Changeset: 05b8be76e24adf30fbf6e3a5b19cc1cc057feb21

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.