Ticket #9546 (closed Patch - Bug Fix: fixed)
Opened 2 years ago
Last modified 2 years ago
[patch] corrupted read buffer refs #9511
|Reported by:||Jiri Fojtasek <jiri.fojtasek@…>||Owned by:||janne|
|Component:||MythTV - Video Playback||Version:||Master Head|
Replying to markk:
Jiri - I'm closing this ticket as fixed, though recognise that there are probably outstanding issues.
If you are still seeing issues with livetv hitting the end of the file during normal playback, please open another ticket as that is a separate issue that needs a proper root cause analysis.
Thanks for the time and effort taken in debugging the issue and producing the patches.
Mark, c3e1879e0c284b3c2267 introduced new problem and its stream corruption when you hit pause/play few times (sometimes leading in to playback crash), or during program switch/jump.
Your solution is wrong because when the buffer is paused and decoder trying to read from ringbuffer ReadDirect? is used instead and reading data from physical file without readahead buffer and read position adjustment. This will cause readahead buffer corruption when playback is resumed.
Attached patch reverting c3e1879e0c284b3c2267 and fixing wait condition by another way than in my previous patch.
Changed 2 years ago by Jiri Fojtasek <jiri.fojtasek@…>
comment:1 Changed 2 years ago by stuartm
- Cc stuartm added
- Milestone changed from unknown to 0.25
comment:2 Changed 2 years ago by markk
comment:3 Changed 2 years ago by markk
- Status changed from new to closed
- Resolution set to Fixed
comment:4 Changed 2 years ago by Mark Kendall
- Resolution changed from Fixed to fixed