Ticket #9577 (closed Patch - Bug Fix: fixed)
Opened 2 years ago
Last modified 2 years ago
CEA-708 captions sometimes spontaneously reset
|Reported by:||Clayton Smith <argilo@…>||Owned by:||danielk|
|Component:||MythTV - ATSC||Version:||0.24-fixes|
Sometimes the CEA-708 closed caption decoder resets the caption display spontaneously, making the captions unreadable. Upon investigation, I found that the code which detects reset (RST) and delay cancel (DLC) commands in the parse_cc_service_stream function is incorrect. It should only inspect command bytes, but it actually scans parameter bytes as well. These parameter bytes may coincide with RST and DLC, causing an undesired reset in the former case, or a premature delay cancel in the latter.
To solve this problem, I added code to skip over parameter bytes. The list of commands and their corresponding number of parameter bytes were taken from the CEA-708 specification. I tested the code on a number of shows, and it now correctly skips over parameter bytes (verified with printf debugging), and the spontaneous resets are gone.
comment:1 Changed 2 years ago by Clayton Smith <argilo@…>
comment:2 Changed 2 years ago by paulh
- Type changed from Bug Report to Patch - Bug Fix
comment:3 Changed 2 years ago by Clayton Smith
- Status changed from new to closed
- Resolution set to fixed
- Milestone changed from unknown to 0.25