Opened 13 years ago
Closed 12 years ago
#9578 closed Patch - Feature (fixed)
Increase arbitrary MAX_DISPLAY_CHANS in guidegrid.h
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | MythTV - General | Version: | 0.24-fixes |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The maximum number of channels visible on screen in guidegrid is locked to 12 by a define in guidegrid.h
On larger TV's at higher resolutions, more channels than this are certainly easily readable. Also, the number of channels is set in the theme separately.
The MAX_DISPLAY_CHANS is used to create an array so it's easier to keep it there rather than trying to dynamically create the array at runtime based on theme settings, but it would be good to set it significantly higher and allow the theme to set a useful size for use.
--- a/mythtv/programs/mythfrontend/guidegrid.h +++ b/mythtv/programs/mythfrontend/guidegrid.h @@ -28,7 +28,7 @@ class QTimer; class MythUIButtonList; class MythUIGuideGrid; -#define MAX_DISPLAY_CHANS 12 +#define MAX_DISPLAY_CHANS 99 #define MAX_DISPLAY_TIMES 36 typedef vector<PixmapChannel> pix_chan_list_t;
Change History (2)
comment:1 Changed 13 years ago by
comment:2 Changed 12 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Bump the maximum number of channels in GuideGrid?.
Based on a patch from Andrew Leech, though I reduced the new masx to 40
- which seems a little more practical.
Fixes #9578
Branch: master Changeset: 6cf957e6f5de237320f1c8f40c3bf8fc244fb42c
Ok that was very daft on my part, the above patch isn't enough. The original figure of 12 is also hard coded in mythuiguidegrid.h
They should really be both referencing a single common define.