Modify

Ticket #9615 (closed Patch - Bug Fix: fixed)

Opened 2 years ago

Last modified 15 months ago

Reset selection in "Main Menu" jump point

Reported by: Jim Stichnoth <stichnot@…> Owned by: stichnot
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When the "Main Menu" jump point is executed, the highlighted selection stays the same as it originally was. Some people might like this, but I prefer to be able to use finger memory to navigate to a known location with a fixed set of keypresses. This patch makes it possible by resetting the highlighted selection when the "Main Menu" jump point is executed from the top-level main menu. I.e., executing the jump point twice in a row will always put you in the main menu with the first item highlighted.

Alternatively, the same code could be moved into gotoMainMenu() and the selection would be reset regardless of where the jump point is executed from.

Attachments

mainmenu_jumppoint_reset.patch (1.1 KB) - added by Jim Stichnoth <stichnot@…> 2 years ago.
mainmenu_jumppoint_reset_v2.patch (669 bytes) - added by Jim Stichnoth <stichnot@…> 2 years ago.

Change History

Changed 2 years ago by Jim Stichnoth <stichnot@…>

Changed 2 years ago by Jim Stichnoth <stichnot@…>

comment:1 Changed 2 years ago by Jim Stichnoth <stichnot@…>

On further thought, I'm submitting the v2 patch, which unconditionally resets the mainmenu selection. First, I believe this was the old behavior a couple of releases ago, maybe before the mythui-osd branch merge. Second, it stays out of the way of the current deprecated way of implementing the mechanics of jump points.

comment:2 Changed 15 months ago by stichnot

  • Owner set to stichnot
  • Status changed from new to assigned

comment:3 Changed 15 months ago by stichnot

  • Status changed from assigned to accepted
  • Type changed from Patch - Feature to Patch - Bug Fix
  • Milestone changed from unknown to 0.25

comment:4 Changed 15 months ago by Github

  • Status changed from accepted to closed
  • Resolution set to fixed

JumpPoints?: Reset the menu selection for the Main Menu jump point.

Fixes a regression introduced sometime around 0.22, in which the Main Menu jump point leaves the selection on the same entry that was active the last time the user was at the Main Menu, rather than the first entry.

Fixes #9615

Branch: master Changeset: 9c05ccdb1b84b42497e45c6c3fd52516157fa44c

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.