Ticket #9725 (closed Patch - Bug Fix: fixed)
Opened 2 years ago
Last modified 23 months ago
[PATCH] Frontend network control does not always return a prompt
|Reported by:||Gregory Moyer <moyerg@…>||Owned by:||wagnerrp|
|Component:||MythTV - General||Version:||Master Head|
|Severity:||medium||Keywords:||frontend network control|
When using the frontend network control, if a command does not generate any result, nothing is sent back to the client. This means that no prompt is sent back to the client as well.
The problem is in mythtv/programs/mythfrontend/networkcontrol.cpp in NetworkControl::processNetworkControlCommand(NetworkCommand? *nc). If a command does not return any result (e.g. 'query recordings' when there are no recordings), the if check will resolve to 'false' and nothing (including the prompt) is sent back.
Frontend version log, logs of example sessions using netcat before and after the patch, and a patch removing the if condition will be attached. I have only tested this patch lightly, but it seems to work well.
If removing this if condition is not acceptable, the other route is to make sure all commands return something. In the case of 'query recordings' something like 'No recordings found.' could be returned. This seems like a more difficult and error prone way to fix this though.
Changed 2 years ago by Gregory Moyer <moyerg@…>
comment:1 Changed 23 months ago by wagnerrp
- Owner set to wagnerrp
- Status changed from new to accepted
comment:2 Changed 23 months ago by Github
- Status changed from accepted to closed
- Resolution set to fixed
- Milestone changed from unknown to 0.25