Ticket #9971 (new Patch - Bug Fix)
Opened 22 months ago
Last modified 15 months ago
Improve CrystalHD decoding for BCM 70012
|Reported by:||czhang1974@…||Owned by:|
|Component:||MythTV - Video Decoding||Version:||0.24-fixes|
This patch fixes the green overlay problem reported in the following thread on the bcm70012.
The default output format from CrystalHD on the bcm70012 is NV12, not YV12. It can be changed to use YV12 by setting some flags if we use the DtsProcOutput? instead of DtsProcOutputNoCopy?, but further reading of the library source code shows that it was converted to YV12 in software anyways. The hardware output is always in NV12, so there is no gain in using YV12.
I also had to make sure that the buffer is always released after decoding. I am still not sure why the code checked for mpa_pic.data before calling the release_buffer, which effectively blocked the call since that would always be NULL for the crystalhd decoder. It most likely is breaking something else that I don't know about, but I will leave that to someone more familiar with the other private decoders.
This now works reasonably well for 720P on my AppleTV. 1080i is still having serious stuttering problem that I can't find the root cause of yet.
comment:1 Changed 22 months ago by wagnerrp
- Owner set to markk
- Status changed from new to assigned
comment:2 Changed 20 months ago by markk
- Status changed from assigned to accepted
- Milestone changed from unknown to 0.25
comment:3 Changed 20 months ago by markk
comment:4 Changed 16 months ago by markk
- Owner markk deleted
- Status changed from accepted to assigned
comment:5 Changed 15 months ago by beirdo
- Status changed from assigned to new
- Milestone changed from 0.25 to unknown