summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGavin Hurlbut <ghurlbut@mythtv.org>2011-05-28 02:30:43 (GMT)
committer Gavin Hurlbut <ghurlbut@mythtv.org>2011-05-28 02:30:43 (GMT)
commit2c7735e7f80b5d2737d2bc8c4e9144f3e42da2e7 (patch)
tree7ca24856f561d463a7d83a06b74b88127ddc36c0
parent62d70845b46387bf16e0a1e1c75f7a0082ba61f3 (diff)
Initialize the MythUIImage filename correctly
Fixes #9634. Fixes #9708. Refs #9547. If the filename does not start with "/", "http://", "https://" or "ftp://", then the actual filename loaded is uninitialized. It can be any random crap on the stack. I'm honestly surprised this worked at all :) This may fix things for #9547 as well, and should be tested with that scenario too.
-rw-r--r--mythtv/libs/libmythui/mythuiimage.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/mythtv/libs/libmythui/mythuiimage.cpp b/mythtv/libs/libmythui/mythuiimage.cpp
index d272f1f..117c439 100644
--- a/mythtv/libs/libmythui/mythuiimage.cpp
+++ b/mythtv/libs/libmythui/mythuiimage.cpp
@@ -85,7 +85,7 @@ class ImageLoadThread : public QRunnable
void run()
{
- QString tmpFilename;
+ QString tmpFilename = m_filename;
if ((m_filename.startsWith("/")) ||
(m_filename.startsWith("http://")) ||
(m_filename.startsWith("https://")) ||