diff options
authorKevin Ross <>2011-10-09 16:03:41 (GMT)
committer Michael T. Dean <>2011-10-09 16:03:41 (GMT)
commitf135d5d5ed59291c54922dcb0ad079cf36139a28 (patch)
parent9b24abdd93cbbdd7a3c41f24454abeb57ae52444 (diff)
Fix MythPlayer::GetRawVideoFrame() for mythcommflag.
Fix MythPlayer::GetRawVideoFrame() to return the correct frame number. This change fixes mythcommflag so that it will return consistent results across multiple runs. It should also improve commercial detection accuracy, as the frame numbers identified by the different methods will actually be precise--allowing for better comparing the results of the different methods. Although this commit has my name for the signed-off line, I didn't do much. Thanks to Kevin Ross for the debugging and the patch, to Taylor Ralph and Mark Kendall for actually reviewing the patch, and to all the users and devs who ran with the patch to test it (and saw greatly-improved commercial flagging results). Signed-off-by: Michael T. Dean <>
1 files changed, 2 insertions, 1 deletions
diff --git a/mythtv/libs/libmythtv/mythplayer.cpp b/mythtv/libs/libmythtv/mythplayer.cpp
index 99fd103..b774053 100644
--- a/mythtv/libs/libmythtv/mythplayer.cpp
+++ b/mythtv/libs/libmythtv/mythplayer.cpp
@@ -4186,7 +4186,8 @@ VideoFrame* MythPlayer::GetRawVideoFrame(long long frameNumber)
LOG(VB_PLAYBACK, LOG_INFO, LOC + "Waited 100ms for video frame");
- return videoOutput->GetLastDecodedFrame();
+ videoOutput->StartDisplayingFrame();
+ return videoOutput->GetLastShownFrame();
QString MythPlayer::GetEncodingType(void) const