There are 143 total results
4 errors, 13 warnings, 11 performance, 4 portability,
1 information, 110 style
MythTV

cppcheck Report


Columns are sortable
# Severity Description File
1 1 error  Found a exit path from function with non-void return type that has missing return statement mythtv/libs/libmythmetadata/musicmetadata.h:208
2 1 error  Rethrowing current exception with ' throw; ' , it seems there is no current exception to rethrow. If there is no current exception this calls std::terminate(). More: https://isocpp.org/wiki/faq/exceptions#throw-without-an-object mythtv/libs/libmythupnp/servicehost.cpp:34
3 1 error  Rethrowing current exception with ' throw; ' , it seems there is no current exception to rethrow. If there is no current exception this calls std::terminate(). More: https://isocpp.org/wiki/faq/exceptions#throw-without-an-object mythtv/libs/libmythupnp/servicehost.cpp:112
4 1 error  The one definition rule is violated, different classes/structs have the same name ' FileTransfer' mythtv/libs/libmythprotoserver/sockethandler/filetransfer.h:18
mythtv/programs/mythbackend/filetransfer.h:20
5 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpcache.cpp:59
mythtv/libs/libmythbase/http/mythhttpcache.cpp:83
6 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpcache.cpp:71
mythtv/libs/libmythbase/http/mythhttpcache.cpp:83
7 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpcache.cpp:82
mythtv/libs/libmythbase/http/mythhttpcache.cpp:83
8 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpencoding.cpp:321
mythtv/libs/libmythbase/http/mythhttpencoding.cpp:334
9 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:43
mythtv/libs/libmythbase/http/mythhttpranges.cpp:68
10 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:47
mythtv/libs/libmythbase/http/mythhttpranges.cpp:68
11 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:97
mythtv/libs/libmythbase/http/mythhttpranges.cpp:120
12 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:98
mythtv/libs/libmythbase/http/mythhttpranges.cpp:120
13 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:99
mythtv/libs/libmythbase/http/mythhttpranges.cpp:120
14 2 warning  Either the condition ' file' is redundant or there is possible null pointer dereference: file. mythtv/libs/libmythbase/http/mythhttpranges.cpp:100
mythtv/libs/libmythbase/http/mythhttpranges.cpp:120
15 2 warning  Either the condition ' lookup' is redundant or there is possible null pointer dereference: lookup. mythtv/libs/libmythmetadata/metadatacommon.cpp:472
mythtv/libs/libmythmetadata/metadatacommon.cpp:469
16 2 warning  Either the condition ' m_animation' is redundant or there is possible null pointer dereference: m_animation. mythtv/programs/mythfrontend/gallerytransitions.cpp:176
mythtv/programs/mythfrontend/gallerytransitions.cpp:181
17 2 warning  Either the condition ' list.size()> =3' is redundant or list size can be 3. Expression ' list[3]' cause access out of bounds. mythplugins/mythmusic/mythmusic/musicplayer.cpp:617
mythplugins/mythmusic/mythmusic/musicplayer.cpp:615
18 3 performance  Variable ' m_dbHostOverride' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmyth/dbsettings.cpp:15
19 3 performance  Variable ' m_monitor' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmyth/mythmediamonitor.cpp:44
20 3 performance  Variable ' m_lastCheckTime' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmyth/mythmediamonitor.cpp:46
21 3 performance  Variable ' m_dbLetterboxColour' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythtv/mythvideoout.cpp:101
22 3 performance  Variable ' m_playingRecStart' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythtv/playercontext.cpp:30
23 3 performance  Variable ' m_oMetaObject' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythupnp/servicehost.cpp:213
24 3 performance  Variable ' m_sBaseUrl' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythupnp/servicehost.cpp:214
25 3 performance  Variable ' m_sName' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythupnp/upnpcds.h:257
26 3 performance  Variable ' m_peerAddress' is assigned in constructor body. Consider performing initialization in initialization list. mythtv/libs/libmythupnp/upnptaskevent.cpp:36
27 3 performance  Variable ' m_check' is assigned in constructor body. Consider performing initialization in initialization list. mythplugins/mythmusic/mythmusic/playlisteditorview.cpp:33
28 3 performance  Variable ' m_action' is assigned in constructor body. Consider performing initialization in initialization list. mythplugins/mythmusic/mythmusic/playlisteditorview.cpp:34
29 4 portability  Shifting signed 32-bit value by 31 bits is implementation-defined behaviour mythtv/libs/libmyth/audio/audioconvert.cpp:156
30 4 portability  Shifting signed 32-bit value by 31 bits is implementation-defined behaviour mythtv/libs/libmyth/audio/audioconvert.cpp:270
31 4 portability  Casting between const unsigned char * and const float * which have an incompatible binary data representation. mythtv/libs/libmythbase/mythbinaryplist.cpp:88
32 4 portability  Casting between const unsigned char * and const double * which have an incompatible binary data representation. mythtv/libs/libmythbase/mythbinaryplist.cpp:88
33 5 information  The code ' class MTV_PUBLIC PID {' is not handled. You can use -I or --include to add handling of this code. mythtv/libs/libmythtv/mpeg/mpegtables.h:206
34 6 style  Obsolescent function ' usleep' called. It is recommended to use ' nanosleep' or ' setitimer' instead. mythtv/libs/libmyth/mediamonitor-darwin.cpp:451
35 6 style  Obsolescent function ' usleep' called. It is recommended to use ' nanosleep' or ' setitimer' instead. mythtv/libs/libmyth/mediamonitor-darwin.cpp:453
36 6 style  Variable ' isWholeMedia' is assigned a value that is never used. mythtv/libs/libmyth/mediamonitor-darwin.cpp:48
37 6 style  The function ' GetCDROMBlockDevices' overrides a function in a base class but is not marked with a ' override' specifier. mythtv/libs/libmyth/mediamonitor-windows.h:16
mythtv/libs/libmyth/mythmediamonitor.h:93
38 6 style  The if condition is the same as the previous if condition mythtv/libs/libmythmetadata/metadatacommon.cpp:533
mythtv/libs/libmythmetadata/metadatacommon.cpp:525
39 6 style  Consider using std::find_if algorithm instead of a raw loop. mythtv/libs/libmythmetadata/metadatagrabber.cpp:182
40 6 style  Consider using std::find_if algorithm instead of a raw loop. mythtv/libs/libmythmetadata/metadatagrabber.cpp:208
41 6 style  Consider using std::find_if algorithm instead of a raw loop. mythtv/libs/libmythmetadata/metadatagrabber.cpp:219
42 6 style  Condition ' m_playerWait' is always true mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:504
mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:502
43 6 style  Condition ' m_playerWait' is always true mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:511
mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:502
44 6 style  Condition ' !((m_title==0& & m_lastTitle==0)& & (m_part==m_lastPart))' is always true mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:647
45 6 style  Variable ' reprocessing' is assigned a value that is never used. mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp:526
46 6 style  Condition ' !m_interrupted' is always true mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp:2751
mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp:2688
47 6 style  Condition ' !m_noAudioOut' is always true mythtv/libs/libmythtv/audioplayer.cpp:456
mythtv/libs/libmythtv/audioplayer.cpp:453
48 6 style  Condition ' DLY==code' is always true mythtv/libs/libmythtv/captions/cc708decoder.cpp:406
mythtv/libs/libmythtv/captions/cc708decoder.cpp:392
mythtv/libs/libmythtv/captions/cc708decoder.cpp:404
49 6 style  Variable ' list' is not assigned a value. mythtv/libs/libmythtv/captions/textsubtitleparser.cpp:182
50 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/tspacket.h:72
51 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/tspacket.h:74
52 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/tspacket.h:96
53 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/tspacket.h:99
54 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1231
55 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1233
56 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1240
57 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1244
58 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1252
59 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1255
60 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1264
61 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/mpegtables.h:1266
62 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/dvbtables.h:153
63 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/dvbtables.h:160
64 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/dvbtables.h:361
65 6 style  Condition ' s_channelDefaultAuthority_runInit' is always true mythtv/libs/libmythtv/channelutil.cpp:1185
mythtv/libs/libmythtv/channelutil.cpp:1181
66 6 style  Variable ' event.m_subtitle' is reassigned a value before the old one has been used. mythtv/libs/libmythtv/eitfixup.cpp:1058
mythtv/libs/libmythtv/eitfixup.cpp:1053
67 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/atsctables.h:281
68 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/atsctables.h:286
69 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/atsctables.h:292
70 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/atsctables.h:495
71 6 style  Non-boolean value returned from function returning bool mythtv/libs/libmythtv/mpeg/atsctables.h:500
72 6 style  struct member ' lineSeg::m_yBottom' is never used. mythtv/libs/libmythtv/mheg/mhi.cpp:1706
73 6 style  struct member ' lineSeg::m_yTop' is never used. mythtv/libs/libmythtv/mheg/mhi.cpp:1706
74 6 style  struct member ' lineSeg::m_xBottom' is never used. mythtv/libs/libmythtv/mheg/mhi.cpp:1706
75 6 style  struct member ' lineSeg::m_slope' is never used. mythtv/libs/libmythtv/mheg/mhi.cpp:1706
76 6 style  struct member ' huffman_table::m_character' is never used. mythtv/libs/libmythtv/mpeg/atsc_huffman.cpp:11
77 6 style  struct member ' huffman_table::m_numberOfBits' is never used. mythtv/libs/libmythtv/mpeg/atsc_huffman.cpp:12
78 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/atsctables.cpp:135
79 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/atsctables.cpp:164
80 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/atsctables.cpp:272
81 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/atsctables.cpp:297
82 6 style  Same expression used in consecutive assignments of ' tid' and ' bid' . mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp:941
mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp:942
83 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/mpegtables.cpp:935
84 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/mpegtables.cpp:953
85 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/mpegtables.cpp:1185
86 6 style  Consider using std::accumulate algorithm instead of a raw loop. mythtv/libs/libmythtv/mpeg/mpegtables.cpp:1204
87 6 style  Virtual function ' HasCRC' is called from constructor ' PESPacket(const char*pesdata)' at line 39. Dynamic binding is not used. mythtv/libs/libmythtv/mpeg/pespacket.h:132
mythtv/libs/libmythtv/mpeg/pespacket.cpp:172
mythtv/libs/libmythtv/mpeg/pespacket.h:39
88 6 style  Virtual function ' HasCRC' is called from constructor ' PESPacket(const std::vector< uint8_t> & pesdata)' at line 46. Dynamic binding is not used. mythtv/libs/libmythtv/mpeg/pespacket.h:132
mythtv/libs/libmythtv/mpeg/pespacket.cpp:172
mythtv/libs/libmythtv/mpeg/pespacket.h:46
89 6 style  Parameter ' Actions' can be declared with const mythtv/libs/libmythtv/mythplayereditorui.cpp:141
90 6 style  Condition ' !cudabuffer' is always false mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp:153
91 6 style  Condition ' !buffer' is always false mythtv/libs/libmythtv/opengl/mythvdpauinterop.cpp:264
92 6 style  Condition ' !frames' is always false mythtv/libs/libmythtv/opengl/mythvdpauinterop.cpp:267
93 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:2798
94 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:2849
95 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:2892
96 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:3111
97 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:3193
98 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:3252
99 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:2920
100 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:2968
101 6 style  Parameter ' planes' can be declared with const mythtv/libs/libmythtv/recorders/RTjpegN.cpp:3030
102 6 style  Condition ' !m_audioBytesRemaining' is always true mythtv/libs/libmythtv/recorders/dtvrecorder.cpp:1148
mythtv/libs/libmythtv/recorders/dtvrecorder.cpp:1100
mythtv/libs/libmythtv/recorders/dtvrecorder.cpp:1095
103 6 style  Variable ' m_dftL[k]' is reassigned a value before the old one has been used. mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp:61
mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp:60
104 6 style  Class ' MythNotification' has a constructor with 1 argument that is not explicit. mythtv/libs/libmythui/mythnotification.h:40
105 6 style  Variable ' crtcs' is not assigned a value. mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp:215
106 6 style  Variable ' outputs' is not assigned a value. mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp:216
107 6 style  Variable ' outputs' is not assigned a value. mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp:432
108 6 style  Parameter ' sTypeName' can be declared with const mythtv/libs/libmythupnp/wsdl.cpp:462
109 6 style  Consider using std::find_if algorithm instead of a raw loop. mythtv/libs/libmythupnp/xsd.cpp:937
110 6 style  Obsolescent function ' usleep' called. It is recommended to use ' nanosleep' or ' setitimer' instead. mythtv/programs/mythbackend/recordingextender.cpp:1671
111 6 style  Condition ' thisScore> 0' is always true mythtv/programs/mythcommflag/ClassicCommDetector.cpp:1758
mythtv/programs/mythcommflag/ClassicCommDetector.cpp:1672
112 6 style  Condition ' i< (commercials-1)' is always true mythtv/programs/mythcommflag/ClassicCommDetector.cpp:1981
mythtv/programs/mythcommflag/ClassicCommDetector.cpp:1969
113 6 style  Variable ' flagFPS' is assigned a value that is never used. mythtv/programs/mythcommflag/ClassicCommDetector.cpp:398
114 6 style  Condition ' histogramAnalyzer' is always true mythtv/programs/mythcommflag/CommDetector2.cpp:361
115 6 style  Condition ' dbChan.m_name!=(*i).m_name' is always false mythtv/programs/mythfilldatabase/channeldata.cpp:315
mythtv/programs/mythfilldatabase/channeldata.cpp:303
116 6 style  Condition ' dbChan.m_chanNum!=(*i).m_chanNum' is always false mythtv/programs/mythfilldatabase/channeldata.cpp:317
mythtv/programs/mythfilldatabase/channeldata.cpp:305
117 6 style  Condition ' dbChan.m_fineTune!=(*i).m_fineTune' is always false mythtv/programs/mythfilldatabase/channeldata.cpp:318
mythtv/programs/mythfilldatabase/channeldata.cpp:306
118 6 style  Condition ' dbChan.m_freqId!=(*i).m_freqId' is always false mythtv/programs/mythfilldatabase/channeldata.cpp:319
mythtv/programs/mythfilldatabase/channeldata.cpp:307
119 6 style  Condition ' dbChan.m_tvFormat!=(*i).m_tvFormat' is always false mythtv/programs/mythfilldatabase/channeldata.cpp:321
mythtv/programs/mythfilldatabase/channeldata.cpp:308
120 6 style  Condition ' m_transitioning' is always false mythtv/programs/mythfrontend/galleryslideview.cpp:632
mythtv/programs/mythfrontend/galleryslideview.cpp:626
121 6 style  Condition ' !m_stopCommandThread' is always true mythtv/programs/mythfrontend/networkcontrol.cpp:282
mythtv/programs/mythfrontend/networkcontrol.cpp:280
122 6 style  Condition ' !m_stopCommandThread' is always true mythtv/programs/mythfrontend/networkcontrol.cpp:284
mythtv/programs/mythfrontend/networkcontrol.cpp:280
123 6 style  struct member ' info::m_inputid' is never used. mythtv/programs/mythfrontend/statusbox.cpp:750
124 6 style  struct member ' info::m_schedgroup' is never used. mythtv/programs/mythfrontend/statusbox.cpp:751
125 6 style  struct member ' info::m_errored' is never used. mythtv/programs/mythfrontend/statusbox.cpp:753
126 6 style  struct member ' info::m_unavailable' is never used. mythtv/programs/mythfrontend/statusbox.cpp:754
127 6 style  struct member ' info::m_sleeping' is never used. mythtv/programs/mythfrontend/statusbox.cpp:755
128 6 style  struct member ' info::m_recording' is never used. mythtv/programs/mythfrontend/statusbox.cpp:756
129 6 style  struct member ' info::m_livetv' is never used. mythtv/programs/mythfrontend/statusbox.cpp:757
130 6 style  struct member ' info::m_available' is never used. mythtv/programs/mythfrontend/statusbox.cpp:758
131 6 style  Condition ' !result' is always true mythtv/programs/mythfrontend/upnpscanner.cpp:1187
mythtv/programs/mythfrontend/upnpscanner.cpp:1178
mythtv/programs/mythfrontend/upnpscanner.cpp:1176
132 6 style  Condition ' m_frameList.isEmpty()' is always true mythtv/programs/mythtranscode/videodecodebuffer.cpp:83
mythtv/programs/mythtranscode/videodecodebuffer.cpp:79
mythtv/programs/mythtranscode/videodecodebuffer.cpp:77
133 6 style  Condition ' diskcount> 1' is always false mythplugins/mythgame/mythgame/gamehandler.cpp:361
mythplugins/mythgame/mythgame/gamehandler.cpp:360
mythplugins/mythgame/mythgame/gamehandler.cpp:335
134 6 style  The scope of the variable ' diskcount' can be reduced. mythplugins/mythgame/mythgame/gamehandler.cpp:335
135 6 style  Consider using std::any_of algorithm instead of a raw loop. mythplugins/mythgame/mythgame/gamesettings.cpp:418
136 6 style  Variable ' dx' is assigned a value that is never used. mythplugins/mythmusic/mythmusic/bumpscope.cpp:245
137 6 style  Variable ' i' is assigned a value that is never used. mythplugins/mythmusic/mythmusic/bumpscope.cpp:248
138 6 style  Variable ' strList' is assigned a value that is never used. mythplugins/mythmusic/mythmusic/editmetadata.cpp:1364
139 6 style  Condition ' list.size()> =3' is always true mythplugins/mythmusic/mythmusic/musicplayer.cpp:615
mythplugins/mythmusic/mythmusic/musicplayer.cpp:605
140 6 style  Condition ' node' is always true mythplugins/mythmusic/mythmusic/visualize.cpp:1198
141 6 style  Variable ' m_dftL[k]' is reassigned a value before the old one has been used. mythplugins/mythmusic/mythmusic/visualize.cpp:676
mythplugins/mythmusic/mythmusic/visualize.cpp:675
142 6 style  Consider using std::fill algorithm instead of a raw loop. mythplugins/mythmusic/mythmusic/visualize.cpp:1051
143 6 style  Virtual function ' LoadData' is called from constructor ' NetTree(DialogType type,MythScreenStack*parent,const char*name=nullptr)' at line 51. Dynamic binding is not used. mythplugins/mythnetvision/mythnetvision/nettree.h:106
mythplugins/mythnetvision/mythnetvision/nettree.cpp:889
mythplugins/mythnetvision/mythnetvision/nettree.cpp:876
mythplugins/mythnetvision/mythnetvision/nettree.cpp:51

cppcheck version - 2.7.4
Updated 22 May 2022 14:25:05 GMT