Ticket #11245: 0001-Changed-DVD-angle-handling-to-be-1-based-throughout-.patch

File 0001-Changed-DVD-angle-handling-to-be-1-based-throughout-.patch, 2.7 KB (added by peper03@…, 11 years ago)
  • mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp

    From a6e892f206a46c3ccfa07ba255284f9f272d1da4 Mon Sep 17 00:00:00 2001
    From: Richard <peper03@yahoo.com>
    Date: Sat, 17 Nov 2012 14:38:36 +0100
    Subject: [PATCH] Changed DVD angle handling to be 1-based throughout (as they
     are on DVDs). This also affects the SWITCHTOANGLE action
     via the Services API.
    
    ---
     mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp |    4 ++--
     mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp   |    8 ++++----
     mythtv/libs/libmythtv/tv_play.cpp             |    2 +-
     3 files changed, 7 insertions(+), 7 deletions(-)
    
    diff --git a/mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp b/mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    index a86faeb..f8c9c25 100644
    a b QString MythBDPlayer::GetTitleName(int title) const 
    239239
    240240QString MythBDPlayer::GetAngleName(int angle) const
    241241{
    242     if (angle >= 0 && angle < GetNumAngles())
     242    if (angle >= 1 && angle <= GetNumAngles())
    243243    {
    244         QString name = QObject::tr("Angle %1").arg(angle+1);
     244        QString name = QObject::tr("Angle %1").arg(angle);
    245245        return name;
    246246    }
    247247    return QString();
  • mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp

    diff --git a/mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp b/mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    index 0230428..1c4fa45 100644
    a b int MythDVDPlayer::GetCurrentAngle(void) const 
    628628
    629629QString MythDVDPlayer::GetAngleName(int angle) const
    630630{
    631     if (angle >= 0 && angle < GetNumAngles())
     631    if (angle >= 1 && angle <= GetNumAngles())
    632632    {
    633         QString name = QObject::tr("Angle %1").arg(angle+1);
     633        QString name = QObject::tr("Angle %1").arg(angle);
    634634        return name;
    635635    }
    636636    return QString();
    bool MythDVDPlayer::SwitchAngle(int angle) 
    642642    if (!total || angle == GetCurrentAngle())
    643643        return false;
    644644
    645     if (angle >= (int)total)
    646         angle = 0;
     645    if (angle < 1 || angle > (int)total)
     646        angle = 1;
    647647
    648648    return player_ctx->buffer->DVD()->SwitchAngle(angle);
    649649}
  • mythtv/libs/libmythtv/tv_play.cpp

    diff --git a/mythtv/libs/libmythtv/tv_play.cpp b/mythtv/libs/libmythtv/tv_play.cpp
    index 26220bd..7fa0cc8 100644
    a b void TV::FillOSDMenuNavigate(const PlayerContext *ctx, OSD *osd, 
    1143111431        currenttext = tr("Angle");
    1143211432        int current_angle = GetCurrentAngle(ctx);
    1143311433
    11434         for (int i = 0; i < num_angles; i++)
     11434        for (int i = 1; i <= num_angles; i++)
    1143511435        {
    1143611436            QString angleIdx = QString("%1").arg(i, 3, 10, QChar(48));
    1143711437            QString desc = GetAngleName(ctx, i);