Ticket #1682: 1682.patch

libs/libmythtv/NuppelVideoPlayer.cpp

@@ -1556 +1556 @@
 {
     uint origMode = textDisplayMode;
 
+    textDesired = enable;
+
     if (!enable)
     {
         DisableCaptions(origMode);
@@ -5496 +5498 @@
     return ret;
 }
 
+/** \fn NuppelVideoPlayer::TracksChanged(uint)
+ *  \brief This tries to re-enables captions/subtitles if the user
+ *         wants them and one of the captions/subtitles tracks has
+ *         changed.
+ */
+void NuppelVideoPlayer::TracksChanged(uint trackType)
+{
+    if (trackType >= kTrackTypeSubtitle &&
+        trackType <= kTrackTypeTeletextCaptions && textDesired)
+    {
+        SetCaptionsEnabled(textDesired);
+    }
+}
+
 InteractiveTV *NuppelVideoPlayer::GetInteractiveTV(void)
 {
     if (!interactiveTV && osd && itvEnabled)

libs/libmythtv/NuppelVideoPlayer.h

@@ -345 +345 @@
     int GetTrack(uint type) const;
     int ChangeTrack(uint type, int dir);
     void ChangeCaptionTrack(int dir);
+    void TracksChanged(uint trackType);
 
     // MHEG/MHI stream selection
     bool ITVHandleAction(const QString &action);
@@ -604 +605 @@
 
     // Support for captions, teletext, etc. decoded by libav
     QMutex    subtitleLock;
+    /// This allows us to enable captions/subtitles later if the streams
+    /// are not immediately available when the video starts playing.
+    bool      textDesired;
     bool      osdHasSubtitles;
     long long osdSubtitlesExpireAt;
     MythDeque<AVSubtitle> nonDisplayedSubtitles;

libs/libmythtv/decoderbase.cpp

@@ -824 +824 @@
             return false;
 
     tracks[type].push_back(info);
+
+    if (GetNVP())
+        GetNVP()->TracksChanged(type);
+
     return true;
 }
 
 /** \fn DecoderBase::AutoSelectTrack(uint)
  *  \brief Select best track.
  *
- *   If case there's only one track available, always choose it.
+ *   In case there's only one track available, always choose it.
  *
  *   If there is a user selected track we try to find it.
  *
@@ -904 +908 @@
         selTrack = 0;
     }
 
+    int oldTrack = currentTrack[type];
     currentTrack[type] = (selTrack < 0) ? -1 : selTrack;
     StreamInfo tmp = tracks[type][currentTrack[type]];
     selectedTrack[type] = tmp;
@@ -917 +922 @@
             .arg(currentTrack[type]+1)
             .arg(iso639_key_toName(lang)).arg(lang));
 
+    if (GetNVP() && (oldTrack != currentTrack[type]))
+        GetNVP()->TracksChanged(type);
+
     return selTrack;
 }