Ticket #3031: 3031-dbg-3.patch

libs/libmythtv/firewirechannel.cpp

@@ -65 +65 @@
 
     bool ok = false;
     if (!(*it)->externalChanger.isEmpty())
-    {
         ok = ChangeExternalChannel(freqid);
-        SetSIStandard("mpeg");
-        SetDTVInfo(0,0,0,0,1);
-    }
     else
     {
         uint ichan = freqid.toUInt(&ok);
@@ -206 +202 @@
                 "STB is turned off, must be on to set channel.");
 
         SetSIStandard("mpeg");
-        SetDTVInfo(0,0,0,0,1);
+        SetCachedATSCInfo(QString("%1-1").arg(channel));
 
         return true; // signal monitor will call retune later...
     }
@@ -215 +211 @@
         return false;
 
     SetSIStandard("mpeg");
-    SetDTVInfo(0,0,0,0,1);
+    SetCachedATSCInfo(QString("%1-1").arg(channel));
 
     return true;
 }

libs/libmythtv/hdhrsignalmonitor.cpp

@@ -98 +98 @@
     if (!GetStreamData())
         return false;
 
-    UpdateListeningForEIT();
-
     const QMap<uint, bool> &listening = GetStreamData()->ListeningPIDs();
 
     // PIDs that need to be added..

libs/libmythtv/hdhrchannel.cpp

@@ -26 +26 @@
 #include "channelutil.h"
 #include "frequencytables.h"
 
-#define DEBUG_PID_FILTERS
-
 #define LOC QString("HDHRChan(%1): ").arg(GetDevice())
 #define LOC_ERR QString("HDHRChan(%1), Error: ").arg(GetDevice())
 
@@ -85 +83 @@
     }
 }
 
-bool HDHRChannel::EnterPowerSavingMode(void)
-{
-    return QString::null != TunerSet("channel", "none", false);
-}
-
 bool HDHRChannel::FindDevice(void)
 {
     if (!_device_id)
@@ -141 +134 @@
     return true;
 }
 
-QString HDHRChannel::DeviceGet(const QString &name, bool report_error_return)
+QString HDHRChannel::DeviceGet(const QString &name)
 {
     QMutexLocker locker(&_lock);
 
@@ -159 +152 @@
         return QString::null;
     }
 
-    if (report_error_return && error)
-    {
-        VERBOSE(VB_IMPORTANT, LOC_ERR +
-                QString("DeviceGet(%1): %2").arg(name).arg(error));
-
+    if (error) {
+        VERBOSE(VB_IMPORTANT, LOC_ERR + QString("DeviceGet(%1): %2").arg(name).arg(error));
         return QString::null;
     }
 
     return QString(value);
 }
 
-QString HDHRChannel::DeviceSet(const QString &name, const QString &val,
-                               bool report_error_return)
+QString HDHRChannel::DeviceSet(const QString &name, const QString &val)
 {
     QMutexLocker locker(&_lock);
 
@@ -186 +175 @@
     if (hdhomerun_control_set(_control_socket, name, val, &value, &error) < 0)
     {
         VERBOSE(VB_IMPORTANT, LOC_ERR + "Set request failed" + ENO);
-
         return QString::null;
     }
 
-    if (report_error_return && error)
-    {
-        VERBOSE(VB_IMPORTANT, LOC_ERR +
-                QString("DeviceSet(%1 %2): %3").arg(name).arg(val).arg(error));
-
+    if (error) {
+        VERBOSE(VB_IMPORTANT, LOC_ERR + QString("DeviceSet(%1 %2): %3").arg(name).arg(val).arg(error));
         return QString::null;
     }
 
     return QString(value);
 }
 
-QString HDHRChannel::TunerGet(const QString &name, bool report_error_return)
+QString HDHRChannel::TunerGet(const QString &name)
 {
-    return DeviceGet(QString("/tuner%1/%2").arg(_tuner).arg(name),
-                     report_error_return);
+    return DeviceGet(QString("/tuner%1/%2").arg(_tuner).arg(name));
 }
 
-QString HDHRChannel::TunerSet(const QString &name, const QString &value,
-                              bool report_error_return)
+QString HDHRChannel::TunerSet(const QString &name, const QString &value)
 {
-    return DeviceSet(QString("/tuner%1/%2").arg(_tuner).arg(name), value,
-                     report_error_return);
+    return DeviceSet(QString("/tuner%1/%2").arg(_tuner).arg(name), value);
 }
 
 bool HDHRChannel::DeviceSetTarget(unsigned short localPort)
@@ -275 +257 @@
     if (!inputName.isEmpty())
         return SwitchToInput(inputName, channum);
 
-    ClearDTVInfo();
-    _ignore_filters = false;
+    SetCachedATSCInfo("");
 
     InputMap::const_iterator it = inputs.find(currentInputID);
     if (it == inputs.end())
@@ -331 +312 @@
     curchannelname = QDeepCopy<QString>(channum);
 
     // Set the major and minor channel for any additional multiplex tuning
-    SetDTVInfo(atsc_major, atsc_minor, netid, tsid, mpeg_prog_num);
+    if (atsc_major || atsc_minor)
+        SetCachedATSCInfo(QString("%1_%2").arg(atsc_major).arg(atsc_minor));
+    else if (mpeg_prog_num >= 0)
+        SetCachedATSCInfo(QString("0-%1").arg(mpeg_prog_num));
+    else
+        SetCachedATSCInfo(QString("%1_0").arg(channum));
 
     // Set this as the future start channel for this source
-    inputs[currentInputID]->startChanNum = QDeepCopy<QString>(curchannelname);
+    inputs[currentInputID]->startChanNum = curchannelname;
 
-    // Turn on the HDHomeRun program filtering if it is supported
-    // and we are tuning to an MPEG program number.
-    if (mpeg_prog_num && (GetTuningMode() == "mpeg"))
-    {
-        QString pnum = QString::number(mpeg_prog_num);
-        _ignore_filters = QString::null != TunerSet("program", pnum, false);
-    }
-
     return true;
 }
 
@@ -445 +423 @@
     it = lower_bound(_pids.begin(), _pids.end(), pid);
     if (it != _pids.end() && *it == pid)
     {
-#ifdef DEBUG_PID_FILTERS
         VERBOSE(VB_CHANNEL, "AddPID(0x"<<hex<<pid<<dec<<") NOOP");
-#endif // DEBUG_PID_FILTERS
         return true;
     }
 
     _pids.insert(it, pid);
 
-#ifdef DEBUG_PID_FILTERS
     VERBOSE(VB_CHANNEL, "AddPID(0x"<<hex<<pid<<dec<<")");
-#endif // DEBUG_PID_FILTERS
 
     if (do_update)
         return UpdateFilters();
@@ -470 +444 @@
     it = lower_bound(_pids.begin(), _pids.end(), pid);
     if (it == _pids.end())
     {
-#ifdef DEBUG_PID_FILTERS
         VERBOSE(VB_CHANNEL, "DelPID(0x"<<hex<<pid<<dec<<") NOOP");
-#endif // DEBUG_PID_FILTERS
-
-       return true;
+        return true;
     }
 
     if (*it == pid)
     {
-#ifdef DEBUG_PID_FILTERS
         VERBOSE(VB_CHANNEL, "DelPID(0x"<<hex<<pid<<dec<<") -- found");
-#endif // DEBUG_PID_FILTERS
         _pids.erase(it);
     }
     else
     {
-#ifdef DEBUG_PID_FILTERS
         VERBOSE(VB_CHANNEL, "DelPID(0x"<<hex<<pid<<dec<<") -- failed");
-#endif // DEBUG_PID_FILTERS
     }
 
     if (do_update)
@@ -500 +467 @@
 {
     QMutexLocker locker(&_lock);
 
-#ifdef DEBUG_PID_FILTERS
     VERBOSE(VB_CHANNEL, "DelAllPID()");
-#endif // DEBUG_PID_FILTERS
-
     _pids.clear();
 
     return UpdateFilters();
@@ -529 +493 @@
     vector<uint> range_min;
     vector<uint> range_max;
 
-    if (_ignore_filters)
-        return true;
-
     for (uint i = 0; i < _pids.size(); i++)
     {
         uint pid_min = _pids[i];
@@ -567 +528 @@
 
     QString new_filter = TunerSet("filter", filter);
 
-#ifdef DEBUG_PID_FILTERS
     QString msg = QString("Filter: '%1'").arg(filter);
     if (filter != new_filter)
         msg += QString("\n\t\t\t\t'%2'").arg(new_filter);
 
     VERBOSE(VB_CHANNEL, msg);
-#endif // DEBUG_PID_FILTERS
 
     return filter == new_filter;
 }

libs/libmythtv/dvbchannel.h

@@ -72 +72 @@
 
   private:
     int  GetChanID(void) const;
+    bool InitChannelParams(DTVMultiplex &t,
+                           uint sourceid, const QString &channum);
 
     void CheckOptions(DTVMultiplex &t) const;
     bool CheckModulation(DTVModulation modulation) const;

libs/libmythtv/dtvchannel.h

@@ -41 +41 @@
     virtual bool TuneMultiplex(uint mplexid, QString inputname) = 0;
     /// \brief To be used by the channel scanner and possibly the EIT scanner.
     virtual bool Tune(const DTVMultiplex &tuning, QString inputname) = 0;
-    /// \brief Enters power saving mode if the card supports it
-    virtual bool EnterPowerSavingMode(void) { return true; }
 
     // Gets
 
@@ -69 +67 @@
     /// \brief Returns PSIP table standard: MPEG, DVB, ATSC, or OpenCable
     QString GetSIStandard(void) const;
 
-    /// \brief Returns suggested tuning mode: "mpeg", "dvb", or "atsc"
-    QString GetSuggestedTuningMode(bool is_live_tv) const;
-
-    /// \brief Returns tuning mode last set by SetTuningMode().
-    QString GetTuningMode(void) const;
-
     /** \brief Returns cached MPEG PIDs for last tuned channel.
      *  \param pid_cache List of PIDs with their TableID
      *                   types is returned in pid_cache.
@@ -84 +76 @@
 
     // Sets
 
-    /// \brief Sets tuning mode: "mpeg", "dvb", "atsc", etc.
-    void SetTuningMode(const QString &tuningmode);
-
     /** \brief Saves MPEG PIDs to cache to database
      * \param pid_cache List of PIDs with their TableID types to be saved.
      */
@@ -96 +85 @@
   protected:
     /// \brief Sets PSIP table standard: MPEG, DVB, ATSC, or OpenCable
     void SetSIStandard(const QString&);
-    void SetDTVInfo(uint atsc_major, uint atsc_minor,
-                    uint dvb_orig_netid,
-                    uint mpeg_tsid, int mpeg_pnum);
-    void ClearDTVInfo(void) { SetDTVInfo(0, 0, 0, 0, -1); }
+    void SetCachedATSCInfo(const QString &chan);
 
     static void GetCachedPids(int chanid, pid_cache_t&);
     static void SaveCachedPids(int chanid, const pid_cache_t&);
@@ -108 +94 @@
     mutable QMutex dtvinfo_lock;
 
     QString sistandard; ///< PSIP table standard: MPEG, DVB, ATSC, OpenCable
-    QString tuningMode;
     int     currentProgramNum;
     uint    currentATSCMajorChannel;
     uint    currentATSCMinorChannel;

libs/libmythtv/mpeg/atscstreamdata.cpp

@@ -107 +107 @@
 
 void ATSCStreamData::Reset(int desiredProgram)
 {
-    Reset(-1,-1);
     MPEGStreamData::Reset(desiredProgram);
     AddListeningPID(ATSC_PSIP_PID);
 }

libs/libmythtv/dvbchannel.cpp

@@ -238 +238 @@
     QString loc_err = LOC_ERR + tmp;
 
     VERBOSE(VB_CHANNEL, loc);
-
     if (fd_frontend < 0)
     {
         VERBOSE(VB_IMPORTANT, loc_err + "Channel object "
                 "will not open, can not change channels.");
 
-        ClearDTVInfo();
         return false;
     }
 
@@ -254 +252 @@
         return true;
     }
 
-    ClearDTVInfo();
-
     QString inputName;
     if (!CheckChannel(channum, inputName))
     {
@@ -276 +272 @@
     if (it == inputs.end())
         return false;
 
-    // Get the input data for the channel
-    QString tvformat, modulation, freqtable, freqid, si_std;
-    int finetune;
-    uint64_t frequency;
-    int mpeg_prog_num;
-    uint atsc_major, atsc_minor, mplexid, tsid, netid;
-
-    if (!ChannelUtil::GetChannelData(
-        (*it)->sourceid, channum,
-        tvformat, modulation, freqtable, freqid,
-        finetune, frequency,
-        si_std, mpeg_prog_num, atsc_major, atsc_minor, tsid, netid,
-        mplexid, commfree))
-    {
-        VERBOSE(VB_IMPORTANT, loc_err +
-                "Unable to find channel in database.");
-
-        return false;
-    }
-
-    // Initialize basic the tuning parameters
+    // Initialize all the tuning parameters
     DTVMultiplex tuning;
-    if (!mplexid || !tuning.FillFromDB(card_type, mplexid))
+    if (!InitChannelParams(tuning, (*it)->sourceid, channum))
     {
         VERBOSE(VB_IMPORTANT, loc_err +
-                "Failed to initialize multiplex options");
+                "Failed to initialize channel options");
 
         return false;
     }
 
-    SetDTVInfo(atsc_major, atsc_minor, netid, tsid, mpeg_prog_num);
-
-    // Try to fix any problems with the multiplex
     CheckOptions(tuning);
 
     if (!Tune(tuning, ""))
     {
         VERBOSE(VB_IMPORTANT, loc_err + "Tuning to frequency.");
 
-        ClearDTVInfo();
         return false;
     }
 
@@ -360 +332 @@
     return SetChannelByString((*it)->startChanNum);
 }
 
+/** \fn DVBChannel::InitChannelParams(DTVMultiplex&,uint,const QString&)
+ *  \brief Initializes all variables pertaining to a channel.
+ *
+ *  \return true on success and false on failure
+ */
+bool DVBChannel::InitChannelParams(DTVMultiplex  &tuning,
+                                   uint           sourceid,
+                                   const QString &channum)
+{
+    QString tvformat, modulation, freqtable, freqid, si_std;
+    int finetune;
+    uint64_t frequency;
+    uint mplexid;
+
+    if (!ChannelUtil::GetChannelData(
+            sourceid,   channum,
+            tvformat,   modulation,   freqtable,   freqid,
+            finetune,   frequency,
+            si_std,                   currentProgramNum,
+            currentATSCMajorChannel,  currentATSCMinorChannel,
+            currentTransportID,       currentOriginalNetworkID,
+            mplexid,    commfree))
+    {
+        return false;
+    }
+
+    if (currentATSCMinorChannel)
+        currentProgramNum = -1;
+
+    if (mplexid)
+        return tuning.FillFromDB(card_type, mplexid);
+
+    VERBOSE(VB_IMPORTANT, LOC_ERR + "Unable to find channel in database.");
+    return false;
+}
+
 /** \fn DVBChannel::CheckOptions(DTVMultiplex&) const
  *  \brief Checks tuning for problems, and tries to fix them.
  */

libs/libmythtv/iptvchannel.cpp

@@ -129 +129 @@
         return false;
     }
 
-    // Set the current channum to the new channel's channum
-    curchannelname = QDeepCopy<QString>(channum);
+    // Set the channel..
+    curchannelname = channum;
+    currentProgramNum = 1;
 
-    // Set the dtv channel info for any additional multiplex tuning
-    SetDTVInfo(/*atsc_major*/ 0, /*atsc_minor*/ 0,
-               /*netid*/ 0,
-               /*tsid*/ 0, /*mpeg_prog_num*/ 1);
-
     VERBOSE(VB_CHANNEL, LOC + "SetChannelByString() -- end");
     return true;
 }

libs/libmythtv/tv_rec.cpp

@@ -765 +765 @@
     changeState = false;
 
     eitScanStartTime = QDateTime::currentDateTime();    
-    if ((internalState == kState_None) &&
-        CardUtil::IsEITCapable(genOpt.cardtype))
+    if ((internalState == kState_None) && (genOpt.cardtype == "DVB"))
     {
         // Add some randomness to avoid all cards starting
         // EIT scanning at nearly the same time.
@@ -981 +980 @@
     MythEvent me("RECORDING_LIST_CHANGE");
     gContext->dispatch(me);
     pauseNotify = true;
+}    
 
-    if (GetDTVChannel())
-        GetDTVChannel()->EnterPowerSavingMode();
-}
-
 DVBRecorder *TVRec::GetDVBRecorder(void)
 {
 #ifdef USING_DVB
@@ -1057 +1053 @@
         }
         VERBOSE(VB_IMPORTANT, LOC_ERR + msg1 + "\n\t\t\t" + msg2);
     }
-
-    if (GetDTVChannel())
-        GetDTVChannel()->EnterPowerSavingMode();
 }
 
 void TVRec::CloseChannel(void)
@@ -1656 +1649 @@
         sd->SetCaching(true);
     }
 
-    uint neededVideo = 0;
-    uint neededAudio = 0;
+    QString sistandard = dtvchan->GetSIStandard();
 
-    ProgramInfo *rec = lastTuningRequest.program;
-    RecordingProfile profile;
-    load_profile(genOpt.cardtype, tvchain, rec, profile);
-    const Setting *setting = profile.byName("recordingtype");
-    if (setting)
-    {
-        neededVideo = (setting->getValue() == "tv") ? 1 : 0;
-        neededAudio = (setting->getValue() == "audio") ? 1 : 0;
-    }
-
-    const QString tuningmode = dtvchan->GetTuningMode();
-
     // Check if this is an ATSC Channel
     int major = dtvchan->GetMajorChannel();
     int minor = dtvchan->GetMinorChannel();
-    if ((minor > 0) && (tuningmode == "atsc"))
+    if ((minor > 0) && (sistandard == "atsc"))
     {
         QString msg = QString("ATSC channel: %1_%2").arg(major).arg(minor);
         VERBOSE(VB_RECORD, LOC + msg);
@@ -1691 +1671 @@
         asd->Reset(major, minor);
         sm->SetStreamData(sd);
         sm->SetChannel(major, minor);
-        sd->SetVideoStreamsRequired(neededVideo);
-        sd->SetAudioStreamsRequired(neededAudio);
+        sd->SetVideoStreamsRequired(1);
 
         // Try to get pid of VCT from cache and
         // require MGT if we don't have VCT pid.
@@ -1706 +1685 @@
     // Check if this is an DVB channel
     int progNum = dtvchan->GetProgramNumber();
 #ifdef USING_DVB
-    if ((progNum >= 0) && (tuningmode == "dvb"))
+    if ((progNum >= 0) && (sistandard == "dvb"))
     {
         int netid   = dtvchan->GetOriginalNetworkID();
         int tsid    = dtvchan->GetTransportID();
 
+        uint neededVideo = 0;
+        uint neededAudio = 0;
+
         DVBStreamData *dsd = dynamic_cast<DVBStreamData*>(sd);
         if (!dsd)
         {
@@ -1720 +1702 @@
                 GetDTVRecorder()->SetStreamData(dsd);
         }
 
+        ProgramInfo *rec = lastTuningRequest.program;
+        RecordingProfile profile;
+        load_profile(genOpt.cardtype, tvchain, rec, profile);
+        const Setting *setting = profile.byName("recordingtype");
+        if (setting)
+        {
+            neededVideo = (setting->getValue() == "tv") ? 1 : 0;
+            neededAudio = (setting->getValue() == "audio") ? 1 : 0;
+        }
+
         VERBOSE(VB_RECORD, LOC +
                 QString("DVB service_id %1 on net_id %2 tsid %3")
                 .arg(progNum).arg(netid).arg(tsid));
@@ -1771 +1763 @@
         sd->Reset(progNum);
         sm->SetStreamData(sd);
         sm->SetProgramNumber(progNum);
-        sd->SetVideoStreamsRequired(neededVideo);
-        sd->SetAudioStreamsRequired(neededAudio);
-
+        sd->SetVideoStreamsRequired(1);
         sm->AddFlags(SignalMonitor::kDTVSigMon_WaitForPAT |
                      SignalMonitor::kDTVSigMon_WaitForPMT |
                      SignalMonitor::kDVBSigMon_WaitForPos);
@@ -1784 +1774 @@
     }
 
     QString msg = "No valid DTV info, ATSC maj(%1) min(%2), MPEG pn(%3)";
-    VERBOSE(VB_IMPORTANT, LOC_ERR + msg.arg(major).arg(minor).arg(progNum));
+    VERBOSE(VB_RECORD, LOC_ERR + msg.arg(major).arg(minor).arg(progNum));
     return false;
 }
 
@@ -2312 +2302 @@
     long long bitrate;
     if (genOpt.cardtype == "MPEG")
         bitrate = 10080000LL; // use DVD max bit rate
-    else if (genOpt.cardtype == "DBOX2")
-        bitrate = 10080000LL; // use DVD max bit rate
-    else if (!CardUtil::IsEncoder(genOpt.cardtype))
+    else if (genOpt.cardtype == "HDTV")
         bitrate = 19400000LL; // 1080i
+    else if (genOpt.cardtype == "FIREWIRE")
+        bitrate = 19400000LL; // 1080i
+    else if (genOpt.cardtype == "DVB")
+        bitrate = 19400000LL; // 1080i
     else // frame grabber
         bitrate = 10080000LL; // use DVD max bit rate, probably too big
 
@@ -3390 +3382 @@
  */
 void TVRec::TuningFrequency(const TuningRequest &request)
 {
-    DTVChannel *dtvchan = GetDTVChannel();
-    if (dtvchan)
+    if (request.minorChan)
     {
-        MPEGStreamData *mpeg = NULL;
-
-        if (GetDTVRecorder())
-            mpeg = GetDTVRecorder()->GetStreamData();
-
-        const QString tuningmode = (HasFlags(kFlagEITScannerRunning)) ?
-            dtvchan->GetSIStandard() :
-            dtvchan->GetSuggestedTuningMode(
-                kState_WatchingLiveTV == internalState);
-
-        dtvchan->SetTuningMode(tuningmode);
-
-        if (request.minorChan && (tuningmode == "atsc"))
-        {
-            channel->SetChannelByString(request.channel);
-
-            ATSCStreamData *atsc = dynamic_cast<ATSCStreamData*>(mpeg);
-            if (atsc)
-                atsc->SetDesiredChannel(request.majorChan, request.minorChan);
-        }
-        else if (request.progNum >= 0)
-        {
-            channel->SetChannelByString(request.channel);
-
-            if (mpeg)
-                mpeg->SetDesiredProgram(request.progNum);
-        }
+        MPEGStreamData *mpeg = GetDTVRecorder()->GetStreamData();
+        ATSCStreamData *atsc = dynamic_cast<ATSCStreamData*>(mpeg);
+        channel->SetChannelByString(request.channel);
+        atsc->SetDesiredChannel(request.majorChan, request.minorChan);
     }
-
+    else if (request.progNum >= 0)
+    {
+        MPEGStreamData *mpeg = GetDTVRecorder()->GetStreamData();
+        channel->SetChannelByString(request.channel);
+        mpeg->SetDesiredProgram(request.progNum);
+    }
     if (request.IsOnSameMultiplex())
     {
         QStringList slist;

libs/libmythtv/channel.cpp

@@ -441 +441 @@
     if (!inputName.isEmpty())
         return ChannelBase::SwitchToInput(inputName, channum);
 
-    ClearDTVInfo();
+    SetCachedATSCInfo("");
 
     InputMap::const_iterator it = inputs.find(currentInputID);
     if (it == inputs.end())
@@ -516 +516 @@
     InitPictureAttributes();
 
     // Set the major and minor channel for any additional multiplex tuning
-    SetDTVInfo(atsc_major, atsc_minor, netid, tsid, mpeg_prog_num);
+    if (atsc_major || atsc_minor)
+        SetCachedATSCInfo(QString("%1_%2").arg(atsc_major).arg(atsc_minor));
+    else
+        SetCachedATSCInfo(QString("%1_0").arg(channum));
 
     // Set this as the future start channel for this source
-    inputs[currentInputID]->startChanNum = QDeepCopy<QString>(curchannelname);
+    inputs[currentInputID]->startChanNum = curchannelname;
 
     return true;
 }

libs/libmythtv/hdhrchannel.h

@@ -29 +29 @@
 
     bool Open(void);
     void Close(void);
-    bool EnterPowerSavingMode(void);
 
     // Sets
     bool SetChannelByString(const QString &chan);
@@ -63 +62 @@
     bool DeviceSetTarget(unsigned short localPort);
     bool DeviceClearTarget(void);
 
-    QString DeviceGet(const QString &name, bool report_error_return = true);
-    QString DeviceSet(const QString &name, const QString &value,
-                      bool report_error_return = true);
+    QString DeviceGet(const QString &name);
+    QString DeviceSet(const QString &name, const QString &value);
 
-    QString TunerGet(const QString &name, bool report_error_return = true);
-    QString TunerSet(const QString &name, const QString &value,
-                     bool report_error_return = true);
+    QString TunerGet(const QString &name);
+    QString TunerSet(const QString &name, const QString &value);
 
   private:
     hdhr_socket_t  *_control_socket;
     uint            _device_id;
     uint            _device_ip;
     uint            _tuner;
-    bool            _ignore_filters;
     vector<uint>    _pids;
     mutable QMutex  _lock;
 };

libs/libmythtv/dtvchannel.cpp

@@ -8 +8 @@
 // MythTV headers
 #include "mythcontext.h"
 #include "mythdbcon.h"
-#include "cardutil.h"
 
 #define LOC QString("DTVChan(%1): ").arg(GetDevice())
 #define LOC_WARN QString("DTVChan(%1) Warning: ").arg(GetDevice())
@@ -16 +15 @@
 
 DTVChannel::DTVChannel(TVRec *parent)
     : ChannelBase(parent),
-      sistandard("mpeg"),         tuningMode(QString::null),
-      currentProgramNum(-1),
+      sistandard("mpeg"),         currentProgramNum(-1),
       currentATSCMajorChannel(0), currentATSCMinorChannel(0),
       currentTransportID(0),      currentOriginalNetworkID(0)
 {
@@ -89 +87 @@
     }
 }
 
-void DTVChannel::SetDTVInfo(uint atsc_major, uint atsc_minor,
-                            uint dvb_orig_netid,
-                            uint mpeg_tsid, int mpeg_pnum)
+void DTVChannel::SetCachedATSCInfo(const QString &chan)
 {
-    QMutexLocker locker(&dtvinfo_lock);
-    currentProgramNum        = mpeg_pnum;
-    currentATSCMajorChannel  = atsc_major;
-    currentATSCMinorChannel  = atsc_minor;
-    currentTransportID       = mpeg_tsid;
-    currentOriginalNetworkID = dvb_orig_netid;
+    int progsep = chan.find("-");
+    int chansep = chan.find("_");
+
+    currentProgramNum        = -1;
+    currentOriginalNetworkID = 0;
+    currentTransportID       = 0;
+    currentATSCMajorChannel  = 0;
+    currentATSCMinorChannel  = 0;
+
+    if (progsep >= 0)
+    {
+        currentProgramNum = chan.right(chan.length() - progsep - 1).toInt();
+        currentATSCMajorChannel = chan.left(progsep).toInt();
+    }
+    else if (chansep >= 0)
+    {
+        currentATSCMinorChannel =
+            chan.right(chan.length() - chansep - 1).toInt();
+        currentATSCMajorChannel = chan.left(chansep).toInt();
+    }
+    else
+    {
+        bool ok;
+        int chanNum = chan.toInt(&ok);
+        if (ok && chanNum >= 10)
+        {
+            currentATSCMinorChannel = chanNum % 10;
+            currentATSCMajorChannel = chanNum / 10;
+        }
+    }
+
+    if (currentATSCMinorChannel > 0)
+    {
+        VERBOSE(VB_CHANNEL, LOC +
+                QString("SetCachedATSCInfo(%2): %3_%4").arg(chan)
+                .arg(currentATSCMajorChannel).arg(currentATSCMinorChannel));
+    }
+    else if ((0 == currentATSCMajorChannel) && (0 == currentProgramNum))
+    {
+        VERBOSE(VB_CHANNEL, LOC +
+                QString("SetCachedATSCInfo(%2): RESET").arg(chan));
+    }
+    else
+    {
+        VERBOSE(VB_CHANNEL, LOC +
+                QString("SetCachedATSCInfo(%2): %3-%4").arg(chan)
+                .arg(currentATSCMajorChannel).arg(currentProgramNum));
+    }
 }
 
 QString DTVChannel::GetSIStandard(void) const
@@ -110 +148 @@
 void DTVChannel::SetSIStandard(const QString &si_std)
 {
     QMutexLocker locker(&dtvinfo_lock);
-    sistandard = QDeepCopy<QString>(si_std.lower());
+    sistandard = QDeepCopy<QString>(si_std);
 }
-
-QString DTVChannel::GetSuggestedTuningMode(bool is_live_tv) const
-{
-    uint cardid = GetCardID();
-    QString input = GetCurrentInput();
-
-    uint quickTuning = 0;
-    if (cardid && !input.isEmpty())
-        quickTuning = CardUtil::GetQuickTuning(cardid, input);
-
-    bool useQuickTuning = (quickTuning && is_live_tv) || (quickTuning > 1);
-
-    QMutexLocker locker(&dtvinfo_lock);
-    if (!useQuickTuning && ((sistandard == "atsc") || (sistandard == "dvb")))
-        return QDeepCopy<QString>(sistandard);
-
-    return "mpeg";
-}
-
-QString DTVChannel::GetTuningMode(void) const
-{
-    QMutexLocker locker(&dtvinfo_lock);
-    return QDeepCopy<QString>(tuningMode);
-}
-
-void DTVChannel::SetTuningMode(const QString &tuning_mode)
-{
-    QMutexLocker locker(&dtvinfo_lock);
-    tuningMode = QDeepCopy<QString>(tuning_mode.lower());
-}