Ticket #3442: show_cycle_visualizer.patch

mythplugins/mythmusic/mythmusic/globalsettings.cpp

@@ -381 +381 @@
     return gc;
 };
 
+static HostCheckBox *ShowVisualCycleOnSongChange()
+{
+    HostCheckBox *gc = new HostCheckBox("ShowVisualCycleOnSongChange");
+    gc->setLabel(QObject::tr("Show the type of visualizer on each song instead of song information"));
+    gc->setValue(false);
+    gc->setHelpText(QObject::tr("Show the changed visualizer when the song "
+                    "changes. Otherwise song information will be shown."));
+    return gc;
+};
+
 static HostCheckBox *ShowAlbumArtOnSongChange()
 {
     HostCheckBox *gc = new HostCheckBox("VisualAlbumArtOnSongChange");
@@ -641 +651 @@
     connect(button, SIGNAL(pressed()), SLOT(showVisEditor()));
 
     playersettings3->addChild(VisualCycleOnSongChange());
+    playersettings3->addChild(ShowVisualCycleOnSongChange());
     playersettings3->addChild(ShowAlbumArtOnSongChange());
     playersettings3->addChild(VisualRandomize());
     playersettings3->addChild(VisualModeDelay());

mythplugins/mythmusic/mythmusic/playbackbox.cpp

@@ -90 +90 @@
     showrating = gContext->GetNumSetting("MusicShowRatings", 0);
     listAsShuffled = gContext->GetNumSetting("ListAsShuffled", 0);
     cycle_visualizer = gContext->GetNumSetting("VisualCycleOnSongChange", 0);
+    show_cycle_visualizer = gContext->GetNumSetting("ShowVisualCycleOnSongChange", 0);
     show_album_art = gContext->GetNumSetting("VisualAlbumArtOnSongChange", 0);
     random_visualizer = gContext->GetNumSetting("VisualRandomize", 0);
 
@@ -514 +515 @@
             else if (action == "SELECT")
             {
                 music_tree_list->select();
-                if (visualizer_status > 0 && cycle_visualizer)
                     CycleVisualizer();
             }
             else if (action == "REFRESH") 
@@ -1316 +1316 @@
         mainvisual->setVisual("Blank");
         mainvisual->setVisual(visual_modes[current_visual]);
     }
-
-    bannerEnable(tr("Visualization: ") + visual_modes[current_visual], 4000);
+    if (show_cycle_visualizer)
+    {
+        bannerEnable(tr("Visualization: ") + visual_modes[current_visual], 4000);
+    }
+    else
+    {
+        bannerEnable(curMeta, show_album_art);
+    }
 }
 
 void PlaybackBoxMusic::setTrackOnLCD(Metadata *mdata)
--- mythplugins/mythmusic/mythmusic/playbackbox.h        2007-05-10 18:07:06.000000000 +0200
+++ mythplugins/mythmusic/mythmusic/playbackbox.h        2007-05-10 18:05:15.000000000 +0200
@@ -195 +195 @@
     GenericTree *playlist_tree;
 
     bool cycle_visualizer;
+    bool show_cycle_visualizer;
     bool random_visualizer;
     bool show_album_art;
     bool show_whole_tree;