Ticket #5238: libs_libmythfreemheg-uninit-defects.patch

libs/libmythfreemheg/BaseClasses.h

@@ -192 +192 @@
 class MHGenericBoolean: public MHGenericBase
 {
 public:
-    MHGenericBoolean() {}
+    MHGenericBoolean() : m_fDirect(false) {}
     void Initialise(MHParseNode *p, MHEngine *engine);
     void PrintMe(FILE *fd, int nTabs) const;
     bool GetValue(MHEngine *engine) const; // Return the value, looking up any indirect ref.
@@ -203 +203 @@
 class MHGenericInteger: public MHGenericBase
 {
 public:
-    MHGenericInteger() {}
+    MHGenericInteger() : m_nDirect(-1) {}
     void Initialise(MHParseNode *p, MHEngine *engine);
     void PrintMe(FILE *fd, int nTabs) const;
     int GetValue(MHEngine *engine) const; // Return the value, looking up any indirect ref.

libs/libmythfreemheg/Bitmap.cpp

@@ -41 +41 @@
 {
     m_fTiling = false;
     m_nOrigTransparency = 0;
+    m_nTransparency = 0;
     m_nXDecodeOffset = 0;
     m_nYDecodeOffset = 0;
     m_pContent = NULL;
@@ -50 +51 @@
 {
     m_fTiling = ref.m_fTiling;
     m_nOrigTransparency = ref.m_nOrigTransparency;
+    m_nTransparency = 0;
     m_nXDecodeOffset = 0;
     m_nYDecodeOffset = 0;
     m_pContent = NULL;

libs/libmythfreemheg/Groups.cpp

@@ -40 +40 @@
 MHGroup::MHGroup()
 {
     m_nOrigGCPriority = 127; // Default.
+    m_fIsApp = false;
     m_nLastId = 0;
 }
 

libs/libmythfreemheg/Groups.h

@@ -157 +157 @@
 class MHSendEvent: public MHElemAction
 {
 public:
-    MHSendEvent(): MHElemAction(":SendEvent") {}
+    MHSendEvent(): MHElemAction(":SendEvent"), m_EventType(EventIsAvailable) {}
     virtual void Initialise(MHParseNode *p, MHEngine *engine);
     virtual void Perform(MHEngine *engine);
     virtual void PrintArgs(FILE *fd, int nTabs) const;

libs/libmythfreemheg/Ingredients.cpp

@@ -36 +36 @@
     m_fShared = false;
     m_nOrigContentSize = 0;
     m_nOrigCCPrio = 127; // Default.
+    m_nContentSize = 0;
+    m_nCCPrio = 0;
     m_ContentType = IN_NoContent;
 }
 
@@ -51 +53 @@
     m_nOrigContentSize = ref.m_nOrigContentSize;
     m_nOrigCCPrio = ref.m_nOrigCCPrio;
     m_fShared = ref.m_fShared;
+    m_nContentSize = ref.m_nContentSize;
+    m_nCCPrio = ref.m_nCCPrio;
 }
 
 

libs/libmythfreemheg/Ingredients.h

@@ -120 +120 @@
 class MHSetData: public MHElemAction
 {
 public:
-    MHSetData(): MHElemAction(":SetData") {}
+    MHSetData(): MHElemAction(":SetData"), m_fIsIncluded(false)
+               ,m_fSizePresent(false), m_fCCPriorityPresent(false) {}
     virtual void Initialise(MHParseNode *p, MHEngine *engine);
     virtual void Perform(MHEngine *engine);
     virtual void PrintArgs(FILE *fd, int nTabs) const;

libs/libmythfreemheg/Link.cpp

@@ -32 +32 @@
 MHLink::MHLink()
 {
     m_EventData.m_Type = MHUnion::U_None;
+    m_nEventType = EventIsAvailable;
 }
 
 void MHLink::Initialise(MHParseNode *p, MHEngine *engine)

libs/libmythfreemheg/Stream.cpp

@@ -145 +145 @@
 
 MHAudio::MHAudio()
 {
+    m_nComponentTag = 0;
     m_nOriginalVol = 0;
     m_fStreamPlaying = false;
 }
@@ -223 +224 @@
 
 MHVideo::MHVideo()
 {
+    m_nComponentTag = 0;
     m_Termination = VI_Disappear;
     m_nXDecodeOffset = 0;
     m_nYDecodeOffset = 0;

libs/libmythfreemheg/Text.cpp

@@ -38 +38 @@
     m_StartCorner = UpperLeft;
     m_fTextWrap = false;
     m_pDisplay = NULL;
+    m_fNeedsRedraw = false;
 }
 
 MHText::MHText(const MHText &ref): MHVisible(ref) // Copy constructor for cloning.
@@ -53 +54 @@
     m_StartCorner = ref.m_StartCorner;
     m_fTextWrap = ref.m_fTextWrap;
     m_pDisplay = NULL;
+    m_fNeedsRedraw = ref.m_fNeedsRedraw;
 }
 
 MHText::~MHText()
@@ -93 +95 @@
     if (pTextWrap) m_fTextWrap = pTextWrap->GetArgN(0)->GetBoolValue();
 
     m_pDisplay = engine->GetContext()->CreateText();
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
 }
 
 static const char *rchJustification[] =
@@ -175 +177 @@
     MHVisible::Preparation(engine);
 
     m_pDisplay->SetSize(m_nBoxWidth, m_nBoxHeight);
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
 }
 
 // Content preparation.  If it's included we can set up the content.
@@ -193 +195 @@
     CreateContent(data, length, engine);
     // Now signal that the content is available.
     engine->EventTriggered(this, EventContentAvailable);
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
 }
 
 // 
@@ -201 +203 @@
 {
     m_Content.Copy(MHOctetString((const char *)p, s));
     engine->Redraw(GetVisibleArea()); // Have to redraw if the content has changed.
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
 //  fprintf(fd, "Text content is now "); m_Content.PrintMe(0); fprintf(fd, "\n");
 }
 
 void MHText::SetTextColour(const MHColour &colour, MHEngine *engine)
 {
     m_textColour.Copy(colour);
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
     engine->Redraw(GetVisibleArea());
 }
 
@@ -223 +225 @@
 void MHText::SetFontAttributes(const MHOctetString &fontAttrs, MHEngine *engine)
 {
     m_fontAttrs.Copy(fontAttrs);
-    m_NeedsRedraw = true;
+    m_fNeedsRedraw = true;
     engine->Redraw(GetVisibleArea());
 }
 
@@ -516 +518 @@
 {
     if (! m_fRunning || ! m_pDisplay || m_nBoxWidth == 0 || m_nBoxHeight == 0) return; // Can't draw zero sized boxes.
     // We only need to recreate the display if something has changed.
-    if ( m_NeedsRedraw)
+    if ( m_fNeedsRedraw)
     {
         Redraw();
-        m_NeedsRedraw = false;
+        m_fNeedsRedraw = false;
     }
     // Draw the background first, then the text.
     engine->GetContext()->DrawRect(m_nPosX, m_nPosY, m_nBoxWidth, m_nBoxHeight, GetColour(m_bgColour));

libs/libmythfreemheg/Text.h

@@ -84 +84 @@
     MHOctetString   m_Content; // The content as an octet string
 
     MHTextDisplay   *m_pDisplay; // Pointer to the display object.
-    bool            m_NeedsRedraw;
+    bool            m_fNeedsRedraw;
 
     // Create the Unicode content from the character input.
     void CreateContent(const unsigned char *p, int s, MHEngine *engine);

libs/libmythfreemheg/Variables.h

@@ -41 +41 @@
 class MHBooleanVar : public MHVariable  
 {
 public:
-    MHBooleanVar() {}
+    MHBooleanVar(): m_fOriginalValue(false), m_fValue(false) {}
     virtual const char *ClassName() { return "BooleanVariable"; }
     virtual void Initialise(MHParseNode *p, MHEngine *engine);
     virtual void PrintMe(FILE *fd, int nTabs) const;
@@ -62 +62 @@
 class MHIntegerVar : public MHVariable  
 {
 public:
-    MHIntegerVar() {}
+    MHIntegerVar(): m_nOriginalValue(0), m_nValue(0) {}
     virtual const char *ClassName() { return "IntegerVariable"; }
     virtual void Initialise(MHParseNode *p, MHEngine *engine);
     virtual void PrintMe(FILE *fd, int nTabs) const;
@@ -156 +156 @@
 class MHTestVariable: public MHElemAction
 {
 public:
-    MHTestVariable(): MHElemAction(":TestVariable") {}
+    MHTestVariable(): MHElemAction(":TestVariable"), m_nOperator(0) {}
     virtual void Initialise(MHParseNode *p, MHEngine *engine);
     virtual void Perform(MHEngine *engine);
 protected:

libs/libmythfreemheg/Visible.cpp

@@ -35 +35 @@
 {
     m_nOriginalBoxWidth = m_nOriginalBoxHeight = -1; // Should always be specified.
     m_nOriginalPosX = m_nOriginalPosY = 0; // Default values.
+    m_nBoxWidth = m_nBoxHeight = 0;
+    m_nPosX = m_nPosY = 0;
 }
 
 // Copy constructor for cloning
@@ -44 +46 @@
     m_nOriginalBoxHeight = ref.m_nOriginalBoxHeight;
     m_nOriginalPosX = ref.m_nOriginalPosX;
     m_nOriginalPosY = ref.m_nOriginalPosY;
+    m_nBoxWidth = ref.m_nBoxWidth;
+    m_nBoxHeight = ref.m_nBoxHeight;
+    m_nPosX = ref.m_nPosX;
+    m_nPosY = ref.m_nPosY;
     m_OriginalPaletteRef.Copy(ref.m_OriginalPaletteRef);
 }
 
@@ -205 +211 @@
     m_fBorderedBBox = true;
     m_nOriginalLineWidth = 1;
     m_OriginalLineStyle = LineStyleSolid;
+    m_nLineWidth = 0;
+    m_LineStyle = 0;
     // Colour defaults to empty.
 }
 
@@ -216 +224 @@
     m_OriginalLineStyle = ref.m_OriginalLineStyle;
     m_OrigLineColour = ref.m_OrigLineColour;
     m_OrigFillColour = ref.m_OrigFillColour;
+    m_nLineWidth = ref.m_nLineWidth;
+    m_LineStyle = ref.m_LineStyle;
 }
 
 void MHLineArt::Initialise(MHParseNode *p, MHEngine *engine)