Ticket #5251: watch-weight-expire_v2.diff

mythtv/programs/mythfrontend/globalsettings.cpp

@@ -961 +961 @@
     bc->setLabel(QObject::tr("Auto-Expire method"));
     bc->addSelection(QObject::tr("Oldest show first"), "1");
     bc->addSelection(QObject::tr("Lowest priority first"), "2");
-    bc->addSelection(QObject::tr("Weighted time/priority combination"), "3");
+    bc->addSelection(QObject::tr("Weighted time/priority/watched combination"),
+                                 "3");
     bc->setHelpText(QObject::tr("Method used to determine which recorded "
                     "shows to delete first. Live TV recordings will always "
                     "expire before normal recordings."));
@@ -976 +977 @@
     bc->setValue(false);
     bc->setHelpText(QObject::tr("If enabled, programs that have been marked as "
                     "watched will be expired before programs that have not "
-                    "been watched."));
+                    "been watched. Does not apply to Weighted "
+                    "time/priority/watched Auto-Expire method "
+                    "(use watched weight instead)."));
+
     return bc;
 }
 
@@ -986 +990 @@
     bs->setLabel(QObject::tr("Priority weight"));
     bs->setHelpText(QObject::tr("The number of days bonus a program gets for "
                     "each priority point. This is only used when the Weighted "
-                    "time/priority Auto-Expire method is selected."));
+                    "time/priority/watched Auto-Expire method is selected."));
     bs->setValue(3);
     return bs;
 };
 
+static GlobalSpinBox *AutoExpireWatchedWeight()
+{
+    GlobalSpinBox *bs = new GlobalSpinBox("AutoExpireWatchedWeight", 1, 400, 1);
+    bs->setLabel(QObject::tr("Watched Weight"));
+    bs->setHelpText(QObject::tr("The number of days fewer a program gets when "
+                    "it is marked as watched. This is only used when the "
+                    "Weighted time/priority/watched Auto-Expire method "
+                    "is selected."));
+    bs->setValue(14);
+    return bs;
+};
+
 static GlobalCheckBox *AutoExpireDefault()
 {
     GlobalCheckBox *bc = new GlobalCheckBox("AutoExpireDefault");
@@ -4299 +4315 @@
         new VerticalConfigurationGroup(false, false, true, true);
     expgrp1->addChild(AutoExpireLiveTVMaxAge());
     expgrp1->addChild(AutoExpireDayPriority());
+    expgrp1->addChild(AutoExpireWatchedWeight());
     expgrp1->addChild(AutoExpireExtraSpace());
 
     HorizontalConfigurationGroup *expgrp =

mythtv/programs/mythbackend/autoexpire.cpp

@@ -902 +902 @@
         case emWeightedTimePriority:
             msg = "Adding programs expirable in Weighted Time Priority order";
             where = "autoexpire > 0";
-            if (gCoreContext->GetNumSetting("AutoExpireWatchedPriority", 0))
-                orderby = "recorded.watched DESC, ";
-            orderby += QString("DATE_ADD(starttime, INTERVAL '%1' * "
-                                        "recorded.recpriority DAY) ASC")
-                      .arg(gCoreContext->GetNumSetting("AutoExpireDayPriority", 3));
+            orderby =
+                QString("starttime"
+                        " + INTERVAL '%1' * recorded.recpriority DAY"
+                        " - INTERVAL '%2' * recorded.watched DAY"
+                        " ASC")
+                .arg(gCoreContext->GetNumSetting("AutoExpireDayPriority", 3))
+                .arg(gCoreContext->GetNumSetting("AutoExpireWatchedWeight", 
+                                                 14));
             break;
         case emShortLiveTVPrograms:
             msg = "Adding Short LiveTV programs in starttime order";