Ticket #5285: libs_libmythtv-uninit-defects.patch

libs/libmythtv/RingBuffer.cpp

@@ -531 +531 @@
  */
 void RingBuffer::CalcReadAheadThresh(void)
 {
-    uint estbitrate;
+    uint estbitrate = 0;
 
     pthread_rwlock_wrlock(&rwlock);
     wantseek       = false;

libs/libmythtv/ThreadedFileWriter.cpp

@@ -124 +124 @@
     mode(pmode),                         fd(-1),
     // state
     no_writes(false),                    flush(false),
-    in_dtor(false),                      ignore_writes(false),
-    tfw_min_write_size(0),
+    write_is_blocked(false),             in_dtor(false),
+    ignore_writes(false),                tfw_min_write_size(0),
     // buffer position state
     rpos(0),                             wpos(0),
     written(0),

libs/libmythtv/cc708window.cpp

@@ -101 +101 @@
 
 CC708Window::CC708Window()
     : priority(0),              visible(0),
-      anchor_point(0),
+      anchor_point(0),          relative_pos(0),
       anchor_vertical(0),       anchor_horizontal(0),
       row_count(0),             column_count(0),
       row_lock(0),              column_lock(0),

libs/libmythtv/cc708window.h

@@ -14 +14 @@
 class CC708CharacterAttribute
 {
   public:
+    CC708CharacterAttribute()
+        : pen_size(0),   offset(0)
+        , text_tag(0),   font_tag(0)
+        , edge_type(0),  underline(0)
+        , italics(0),    fg_color(0)
+        , fg_opacity(0), bg_color(0)
+        , bg_opacity(0), edge_color(0) {}
     uint pen_size;
     uint offset;
     uint text_tag;
@@ -60 +67 @@
 class CC708Pen
 {
   public:
+    CC708Pen() : row(0), column(0) {}
     void SetPenStyle(uint style);
     void SetAttributes(int pen_size,
                        int offset,       int text_tag,  int font_tag,
@@ -73 +81 @@
         attr.underline = underline;
         attr.italics   = italics;
     }
-  public:
+
     CC708CharacterAttribute attr;
 
     uint row;

libs/libmythtv/dsmccbiop.h

@@ -46 +46 @@
 class BiopTap
 {
   public:
-    BiopTap() { selector_data = NULL; }
+    BiopTap() :
+        id(0),               use(0),
+        assoc_tag(0),        selector_len(0),
+        selector_data(NULL) { }
     ~BiopTap();
 
     int Process(const unsigned char*);
@@ -73 +76 @@
 class BiopObjLocation
 {
   public:
-    BiopObjLocation() { }
+    BiopObjLocation() :
+        component_tag(0), component_data_len(0),
+        version_major(0), version_minor(0) { }
     ~BiopObjLocation() { }
 
     int Process(const unsigned char*);
@@ -96 +101 @@
 class ProfileBodyFull: public ProfileBody
 {
   public:
-    ProfileBodyFull() { }
+    ProfileBodyFull() :
+        data_len(0), byte_order(0),
+        lite_components_count(0) { }
     virtual ~ProfileBodyFull() { }
     virtual int Process(const unsigned char *);
     virtual DSMCCCacheReference *GetReference()
@@ -154 +161 @@
 class BiopBinding
 {
   public:
-    BiopBinding() : m_objinfo_len(0), m_objinfo(0) {}
+    BiopBinding() : m_binding_type(0), m_objinfo_len(0), m_objinfo(0) {}
     ~BiopBinding();
 
     int Process(const unsigned char *data);
@@ -171 +178 @@
 class BiopMessage
 {
   public:
-    BiopMessage() : m_objinfo(NULL), m_objkind(NULL) {}
+    BiopMessage() :
+        m_version_major(0), m_version_minor(0),
+        m_message_size(0),  m_objkind_len(0),
+        m_objinfo_len(0),  m_objinfo(NULL),
+        m_objkind(NULL) {}
     ~BiopMessage();
+
     bool Process(DSMCCCacheModuleData *cachep, DSMCCCache *cache,
                  unsigned char *data, unsigned long *curp);
 

libs/libmythtv/dvbdev/dvbci.cpp

@@ -233 +233 @@
   uint8_t data[MAX_TPDU_SIZE];
   const uint8_t *GetData(const uint8_t *Data, int &Length);
 public:
-  cTPDU(void) { size = 0; }
+  cTPDU(void) { size = 0; memset(data, 0, sizeof(uint8_t) * MAX_TPDU_SIZE); }
   cTPDU(uint8_t Slot, uint8_t Tcid, uint8_t Tag, int Length = 0, const uint8_t *Data = NULL);
   uint8_t Slot(void) { return data[0]; }
   uint8_t Tcid(void) { return data[1]; }
@@ -904 +904 @@
   dbgprotocol("New Application Information (session id %d)\n", SessionId);
   state = 0;
   creationTime = time(NULL);
+  applicationType = 0;
+  applicationManufacturer = 0;
+  manufacturerCode = 0;
   menuString = NULL;
 }
 
@@ -1326 +1329 @@
   selectable = Selectable;
   titleText = subTitleText = bottomText = NULL;
   numEntries = 0;
+  for (int i = 0; i < MAX_CIMENU_ENTRIES; i++)
+      entries[i] = NULL;
 }
 
 cCiMenu::~cCiMenu()

libs/libmythtv/fifowriter.cpp

@@ -26 +26 @@
 {
     num_fifos = count;
     usesync = sync;
+    cur_id = -1;
     maxblksize = new long[count];
     killwr = new int[count];
     fbcount = new int[count];

libs/libmythtv/frequencytables.h

@@ -74 +74 @@
           inversion(_inversion),           bandwidth(_bandwidth),
           coderate_hp(_coderate_hp),       coderate_lp(_coderate_lp),
           constellation(_constellation),   trans_mode(_trans_mode),
-          guard_interval(_guard_interval), hierarchy(_hierarchy) { ; }
+          guard_interval(_guard_interval), hierarchy(_hierarchy) { }
 
-    virtual ~FrequencyTable() { ; }
+    virtual ~FrequencyTable() { }
 
     // Common Stuff
     QString           name_format;    ///< pretty name format

libs/libmythtv/infostructs.h

@@ -13 +13 @@
 class MPUBLIC ChannelInfo
 {
  public:
-    ChannelInfo() {}
-   ~ChannelInfo() {}
+    ChannelInfo() : chanid(-1), sourceid(-1), favid(-1), iconload(false) {}
 
     void LoadChannelIcon(int width, int height = 0);
     QString Text(QString format);

libs/libmythtv/mpeg/tspacket.h

@@ -127 +127 @@
 {
     friend class PESPacket;
   public:
-    TSPacket() : TSHeader() {}
+    TSPacket() : TSHeader() { memset(_tspayload, 0, sizeof(char) * 184); }
     static TSPacket* CreatePayloadOnlyPacket()
     {
         TSPacket *pkt = new TSPacket();

libs/libmythtv/osdtypeteletext.cpp

@@ -210 +210 @@
 {
     OSDUpdateLocker locker(&m_lock, this);
 
-    int b1, b2, b3, err;
+    int b1, b2, b3, err = 0;
 
     if (magazine < 1 || magazine > 8)
         return;

libs/libmythtv/osdxvmc.cpp

@@ -23 +23 @@
 
 XvMCOSD::XvMCOSD(Display *disp, int port, int surface_type_id,
                  int xvmc_surf_flags)
-    : XJ_disp(disp), XJ_width(0), XJ_height(0),
-      xv_port(port), osd_palette(NULL), osd_xv_image(NULL),
-      osd_subpict_mode(NO_SUBPICTURE), osd_subpict_clear_color(0),
-      osd_subpict_alloc(false)
+    : XJ_disp(disp),                   XJ_width(0)
+    , XJ_height(0),                    xv_port(port)
+    , osd_palette(NULL),               osd_xv_image(NULL)
+    , osd_subpict_mode(NO_SUBPICTURE), osd_subpict_clear_color(0)
+    , osd_subpict_alloc(false),        revision(-1)
 {
     bzero(&osd_subpict, sizeof(osd_subpict));
+    bzero(&XJ_osd_shm_info, sizeof(XJ_osd_shm_info));
+    bzero(&osd_subpict_info, sizeof(osd_subpict_info));
+    bzero(&tmpframe, sizeof(tmpframe));
     // subpicture init
     int num = 0;
     XvImageFormatValues *xvfmv = NULL;

libs/libmythtv/osdxvmc.h

@@ -16 +16 @@
 class XvMCOSD
 {
   public:
-    XvMCOSD() { ; } // dummy
-
     XvMCOSD(Display *XJ_disp, int xv_port,
             int surface_type_id, int xvmc_surf_flags);
 

libs/libmythtv/programdata.h

@@ -25 +25 @@
 class ProgInfo
 {
   public:
-    ProgInfo() { }
+    ProgInfo() :
+        previouslyshown(false), audioproperties(-1),
+        videoproperties(-1),    subtitletype(-1) { }
     ProgInfo(const ProgInfo &other) { channel = other.channel;
                                       startts = other.startts;
                                       endts = other.endts;

libs/libmythtv/signalmonitorvalue.h

@@ -12 +12 @@
     SignalMonitorValue(const QString& _name, const QString& _noSpaceName,
                        int _threshold, bool _high_threshold,
                        int _min, int _max, int _timeout);
-    virtual ~SignalMonitorValue() { ; }
 
     // // // // // // // // // // // // // // // // // // // // // // // //
     // Gets  // // // // // // // // // // // // // // // // // // // // //
@@ -121 +120 @@
             .arg( (IsGood()) ? "Is" : "Is NOT" );
     }
   private:
-    SignalMonitorValue() {}
+    SignalMonitorValue()
+        : value(-1), threshold(-1), minval(-1), maxval(-1), timeout(-1),
+          high_threshold(true), set(false) { }
     SignalMonitorValue(const QString& _name, const QString& _noSpaceName,
                        int _value, int _threshold, bool _high_threshold,
                        int _min, int _max, int _timeout, bool _set);

libs/libmythtv/ttfont.cpp

@@ -31 +31 @@
 #include "osdtypes.h"
 #include "osdsurface.h"
 
-static int          have_library = 0;
-static FT_Library   the_library;
+bool TTFFont::have_library = false;
+FT_Library TTFFont::the_library;
 
 #define FT_VALID(handle) ((handle) && (handle)->clazz != NULL)
 
@@ -548 +548 @@
 
 TTFFont::TTFFont(char *file, int size, float wscale,
                  float hmult)
+    : valid(false),            face(0)
+    , max_descent(-1),         max_ascent(-1)
+    , fontsize(size),          vid_width(-1)
+    , vid_height(-1),          use_kerning(false)
+    , spacewidth(0),           m_size(size)
+    , m_outline(false),        m_shadowxoff(0)
+    , m_shadowyoff(0),         m_color_normal_y(255)
+    , m_color_normal_u(128),   m_color_normal_v(128)
+    , m_color_outline_y(0x40), m_color_outline_u(128)
+    , m_color_outline_v(128),  m_color_shadow_y(0x20)
+    , m_color_shadow_u(128),   m_color_shadow_v(128)
+    , m_file(file),            loadedfontsize(-1)
+    , m_wscale(wscale),        m_hmult(hmult)
+    
 {
-   FT_Error            error;
-
-   valid = false;
-   m_size = size;
-   spacewidth = 0;
-
-   m_outline = false;
-   m_shadowxoff = 0;
-   m_shadowyoff = 0;
-
-   m_color_normal_y = 255;
-   m_color_normal_u = m_color_normal_v = 128;
-
-   m_color_outline_y = 0x40;
-   m_color_outline_u = m_color_outline_v = 128;
-
-   m_color_shadow_y = 0x20;
-   m_color_shadow_u = m_color_shadow_v = 128;
-
    if (!have_library)
    {
-        error = FT_Init_FreeType(&the_library);
-        if (error) {
+        FT_Error error = FT_Init_FreeType(&the_library);
+        if (error)
            return;
-        }
-        have_library++;
-   }
 
-   fontsize = size;
-   library = the_library;
-
-   m_wscale = wscale;
-   m_file = file;
-   m_hmult = hmult;
+        have_library = true;
+   }
 
    Init();
 }
@@ -622 +610 @@
    int xdpi = 96, ydpi = 96;
    unsigned short i, n;
 
-   error = FT_New_Face(library, m_file, 0, &face);
+   error = FT_New_Face(the_library, m_file, 0, &face);
    if (error)
    {
         return;

libs/libmythtv/ttfont.h

@@ -69 +69 @@
      bool cache_glyph(unsigned short c);
 
      bool         valid;
-     FT_Library   library;
      FT_Face      face;
      QMap<unsigned short, FT_Glyph> glyphs;
      QMap<unsigned short, Raster_Map *> glyphs_cached;
@@ -104 +103 @@
      int loadedfontsize;
      float m_wscale;
      float m_hmult;
+
+     static bool have_library;
+     static FT_Library the_library;
 };
 
 #endif

libs/libmythtv/tv_play.h

@@ -102 +102 @@
 class AskProgramInfo
 {
   public:
-    AskProgramInfo() : info(NULL) {}
+    AskProgramInfo() :
+        has_rec(false),                has_later(false),
+        is_in_same_input_group(false), is_conflicting(false),
+        info(NULL) {}
     AskProgramInfo(const QDateTime &e, bool r, bool l, ProgramInfo *i) :
         expiry(e), has_rec(r), has_later(l),
         is_in_same_input_group(false), is_conflicting(false),

libs/libmythtv/vbitext/vbi.c

@@ -632 +632 @@
 vbi_open(const char *vbi_name, struct cache *ca, int fine_tune, int big_buf)
 {
     static int inited = 0;
-    struct vbi *vbi;
+    struct vbi *vbi = 0;
 
     (void)ca;
 

libs/libmythtv/videooutbase.cpp

@@ -312 +312 @@
     framesPlayed(0), db_scaling_allowed(true),
     supported_attributes(kPictureAttributeSupported_None)
 {
+    bzero(&pip_tmp_image, sizeof(pip_tmp_image));
     db_display_dim = QSize(gContext->GetNumSetting("DisplaySizeWidth",  0),
                            gContext->GetNumSetting("DisplaySizeHeight", 0));
 

libs/libmythtv/vsync.cpp

@@ -113 +113 @@
 VideoSync::VideoSync(VideoOutput *video_output,
                      int frameint, int refreshint,
                      bool halve_frame_interval) :
-    m_video_output(video_output),
-    m_frame_interval(frameint), m_refresh_interval(refreshint),
-    m_interlaced(halve_frame_interval) 
+    m_video_output(video_output),   m_frame_interval(frameint),
+    m_refresh_interval(refreshint), m_interlaced(halve_frame_interval),
+    m_delay(-1)
 {
+    bzero(&m_nexttrigger, sizeof(m_nexttrigger));
     if (m_interlaced && m_refresh_interval > m_frame_interval/2)
         m_interlaced = false; // can't display both fields at 2x rate
 
@@ -359 +360 @@
 
 nVidiaVideoSync::nVidiaVideoSync(VideoOutput *vo,
                                  int fi, int ri, bool intr) : 
-    VideoSync(vo, fi, ri, intr)
+    VideoSync(vo, fi, ri, intr), m_nvidia_fd(-1)
 {
 }