Ticket #5290: libs_libmythtv-check-pthread_create.patch

libs/libmythtv/RingBuffer.cpp

@@ -631 +631 @@
     readaheadrunning = false;
 
     readAheadRunningCondLock.lock();
-    pthread_create(&reader, NULL, StartReader, this);
+    int rval = pthread_create(&reader, NULL, StartReader, this);
+    if (rval != 0) {
+        VERBOSE(VB_IMPORTANT, QString("RingBuffer::StartupReadAheadThread: "
+                "pthread_create failed with %1").arg(strerror(rval)));
+        return;
+    }
     readAheadRunningCond.wait(&readAheadRunningCondLock);
     readAheadRunningCondLock.unlock();
 }

libs/libmythtv/dvbstreamhandler.cpp

@@ -189 +189 @@
     if (!IsRunning())
     {
         QMutex is_running_lock;
-        pthread_create(&_reader_thread, NULL,
-                       run_dvb_stream_handler_thunk, this);
+        int rval = pthread_create(&_reader_thread, NULL,
+                                  run_dvb_stream_handler_thunk, this);
+        if (rval < 0)
+        {
+            VERBOSE(VB_IMPORTANT, LOC_ERR + QString("DVBStreamHandler::Start - "
+                    "failed creating thread. Error %1").arg(strerror(errno)));
+            return;
+        }
 
         while (!IsRunning())
         {

libs/libmythtv/signalmonitor.cpp

@@ -205 +205 @@
     {
         QMutexLocker locker(&startStopLock);
         if (!running)
-            pthread_create(&monitor_thread, NULL, SpawnMonitorLoop, this);
+        {
+            if (pthread_create(&monitor_thread, NULL, SpawnMonitorLoop, this) == -1)
+            {
+                VERBOSE(VB_IMPORTANT, "Failed to create signal monitor thread");
+                return;
+            }
+        }
+
         while (!running)
             usleep(50);
     }