Ticket #5477: toggleupmixer_clean.diff

libs/libmythtv/NuppelVideoPlayer.cpp

@@ -3724 +3724 @@
     audio_codec = ac;
 }
 
+bool NuppelVideoPlayer::ToggleUpmixer()
+{
+    if (audioOutput)
+    {
+        const AudioSettings settings(
+                audio_bits, audio_channels, audio_samplerate,
+                audio_passthru, audio_codec);
+        return audioOutput->ToggleUpmixer(settings);
+    } 
+    return false;
+}
+
 void NuppelVideoPlayer::SetEffDsp(int dsprate)
 {
     if (audioOutput)

libs/libmythtv/tv_play.h

@@ -239 +239 @@
     // Used by EPG
     void ChangeVolume(bool up);
     void ToggleMute(void);
+    void ToggleUpmixer(void);
 
   public slots:
     void HandleOSDClosed(int osdType);

libs/libmythtv/NuppelVideoPlayer.h

@@ -128 +128 @@
     void SetAudioParams(int bits, int channels, int samplerate, bool passthru);
     void SetEffDsp(int dsprate);
     void SetAudioCodec(void *ac);
+    bool ToggleUpmixer();
 
     // Sets
     void SetParentWidget(QWidget *widget)     { parentWidget = widget; }

libs/libmythtv/tv_play.cpp

@@ -379 +379 @@
     REG_KEY("TV Playback", "VOLUMEDOWN", "Volume down", "[,{,F10,Volume Down");
     REG_KEY("TV Playback", "VOLUMEUP",   "Volume up",   "],},F11,Volume Up");
     REG_KEY("TV Playback", "MUTE",       "Mute",        "|,\\,F9,Volume Mute");
+    REG_KEY("TV Playback", "TOGGLEUPMIXER",       "Toggle Upmixer",        "F12,Toggle Upmixer");
     REG_KEY("TV Playback", "TOGGLEPIPMODE", "Toggle Picture-in-Picture mode",
             "V");
     REG_KEY("TV Playback", "TOGGLEPIPWINDOW", "Toggle active PiP window", "B");
@@ -2742 +2743 @@
             else if (action == "VOLUMEDOWN" || action == "VOLUMEUP" ||
                      action == "STRETCHINC" || action == "STRETCHDEC" ||
                      action == "MUTE"       || action == "TOGGLEASPECT" ||
-                     action == "TOGGLEFILL" )
+                     action == "TOGGLEFILL" || action == "TOGGLEUPMIXER")
             {
                 passThru = 1;
                 handled = false;
@@ -2797 +2798 @@
             else if (action == "VOLUMEDOWN" || action == "VOLUMEUP" ||
                      action == "STRETCHINC" || action == "STRETCHDEC" ||
                      action == "MUTE" || action == "PAUSE" ||
-                     action == "CLEAROSD")
+                     action == "CLEAROSD" || action == "TOGGLEUPMIXER")
             {
                 passThru = 1;
                 handled = false;
@@ -3364 +3365 @@
             ChangeVolume(true);
         else if (action == "MUTE")
             ToggleMute();
+        else if (action == "TOGGLEUPMIXER")
+            ToggleUpmixer();
         else if (action == "STRETCHINC")
             ChangeTimeStretch(1);
         else if (action == "STRETCHDEC")
@@ -6143 +6146 @@
         GetOSD()->SetSettingsText(text, 5);
 }
 
+void TV::ToggleUpmixer(void)
+{
+    bool state=nvp->ToggleUpmixer();
+
+    QString text;
+
+    if(state)
+        text = tr("Upmixer enabled");
+    else
+        text = tr("Upmixer disabled");
+
+    if (GetOSD() && !browsemode)
+        GetOSD()->SetSettingsText(text, 5);
+}
+
 void TV::ToggleSleepTimer(void)
 {
     QString text;
@@ -7317 +7335 @@
 
     if (HandleTrackAction(action))
         ;
+    else if (action == "TOGGLEUPMIXER")
+        ToggleUpmixer();
     else if (action == "TOGGLEMANUALZOOM")
         SetManualZoom(true);
     else if (action == "TOGGLESTRETCH")
@@ -7558 +7578 @@
         }
     }
 
+    new OSDGenericTree(treeMenu, tr("Toggle Upmixer"), "TOGGLEUPMIXER");
+
     new OSDGenericTree(treeMenu, tr("Manual Zoom Mode"), "TOGGLEMANUALZOOM");
 
     new OSDGenericTree(treeMenu, tr("Adjust Audio Sync"), "TOGGLEAUDIOSYNC");

libs/libmyth/audiooutputbase.h

@@ -76 +76 @@
     /// Audio Buffer Size -- should be divisible by 12,10,8,6,4,2..
     static const uint kAudioRingBufferSize   = 1536000;
 
+    virtual bool ToggleUpmixer(const AudioSettings&);
  protected:
     // You need to implement the following functions
     virtual bool OpenDevice(void) = 0;
@@ -153 +154 @@
     int source_audio_channels;
     int source_audio_bytes_per_sample;
     bool needs_upmix;
+    bool upmixer_enabled;
     int surround_mode;
 
     bool blocking; // do AddSamples calls block?

libs/libmyth/audiooutputbase.cpp

@@ -53 +53 @@
     source_audio_channels(-1),
     source_audio_bytes_per_sample(0),
     needs_upmix(false),
+    upmixer_enabled(false),
     surround_mode(FreeSurround::SurroundModePassive),
 
     blocking(false),
@@ -223 +224 @@
     }
 
     if ((configured_audio_channels == 6) &&
-        !(settings.codec || audio_codec))
+        !(settings.codec || audio_codec) && upmixer_enabled)
     {
         settings.channels = configured_audio_channels;
         lneeds_upmix = true;
@@ -245 +246 @@
         return;
     }
 
-    if (general_deps && !upmix_deps && lneeds_upmix && upmixer)
+    if (general_deps && !upmix_deps && lneeds_upmix && upmixer && upmixer_enabled)
     {
         upmixer->flush();
         source_audio_channels = lsource_audio_channels;
@@ -654 +655 @@
                               audio_bytes_per_sample) / audio_stretchfactor);
     }
 
-    if (upmixer && needs_upmix)
+    if (upmixer && needs_upmix && upmixer_enabled)
     {
         totalbuffer += upmixer->sampleLatency() * audio_bytes_per_sample;
     }
@@ -700 +701 @@
         len = (int)ceilf(float(len) * src_data.src_ratio);
 
     // include samples in upmix buffer that may be flushed
-    if (needs_upmix && upmixer)
+    if (needs_upmix && upmixer && upmixer_enabled)
         len += upmixer->numUnprocessedSamples() * abps;
 
     if (pSoundStretch)
@@ -767 +768 @@
         len = (int)ceilf(float(len) * src_data.src_ratio);
 
     // include samples in upmix buffer that may be flushed
-    if (needs_upmix && upmixer)
+    if (needs_upmix && upmixer && upmixer_enabled)
         len += upmixer->numUnprocessedSamples() * abps;
 
     if (pSoundStretch)
@@ -854 +855 @@
     return len;
 }
 
+bool AudioOutputBase::ToggleUpmixer(const AudioSettings& settings)
+{
+    upmixer_enabled = !upmixer_enabled;
+    this->Reconfigure(settings);
+    return upmixer_enabled;
+}
+
 void AudioOutputBase::_AddSamples(void *buffer, bool interleaved, int samples,
                                   long long timecode)
 {
@@ -870 +878 @@
 
     VERBOSE(VB_AUDIO+VB_TIMESTAMP,
             LOC + QString("_AddSamples samples=%1 bytes=%2, used=%3, "
-                          "free=%4, timecode=%5 needsupmix %6")
+                          "free=%4, timecode=%5 needsupmix %6 upmixer enabled %7")
             .arg(samples)
             .arg(samples * abps)
             .arg(kAudioRingBufferSize-afree).arg(afree).arg(timecode)
-            .arg(needs_upmix));
+            .arg(needs_upmix).arg(upmixer_enabled));
 
-    if (upmixer && needs_upmix)
+    if (upmixer && needs_upmix && upmixer_enabled)
     {
         int out_samples = 0;
         int step = (interleaved)?source_audio_channels:1;

libs/libmyth/audiooutput.h

@@ -69 +69 @@
     virtual void bufferOutputData(bool y) = 0;
     virtual int readOutputData(unsigned char *read_buffer, int max_length) = 0;
 
+    virtual bool ToggleUpmixer(const AudioSettings&) = 0;
+
   protected:
     void Error(const QString &msg);
     void Warn(const QString &msg);