Ticket #5522: programs_mythfrontend_main.cpp-argpos-incr-unreachable.patch

File programs_mythfrontend_main.cpp-argpos-incr-unreachable.patch, 1.1 KB (added by Erik Hovland <erik@…>, 13 years ago)

removes unreachable argpos increment

  • mythtv/programs/mythfrontend/main.cpp

    The argpos++ for the -G or --get-setting argument cannot
    
    From: Erik Hovland <erik@hovland.org>
    
    be reached. Removing it keeps people from wondering
    what is going on.
    ---
    
     mythtv/programs/mythfrontend/main.cpp |    9 ++-------
     1 files changed, 2 insertions(+), 7 deletions(-)
    
    diff --git a/mythtv/programs/mythfrontend/main.cpp b/mythtv/programs/mythfrontend/main.cpp
    index a450304..406367c 100644
    a b int main(int argc, char **argv) 
    12601260                }
    12611261                return FRONTEND_EXIT_OK;
    12621262            }
    1263             else
    1264             {
    1265                 cerr << "Invalid or missing argument to -G/--get-setting option\n";
    1266                 return FRONTEND_EXIT_INVALID_CMDLINE;
    1267             }
    1268 
    1269             ++argpos;
     1263            cerr << "Invalid or missing argument to -G/--get-setting option\n";
     1264            return FRONTEND_EXIT_INVALID_CMDLINE;
    12701265        }
    12711266        else if (!strcmp(a.argv()[argpos],"-geometry") ||
    12721267                 !strcmp(a.argv()[argpos],"--geometry"))