Ticket #5897: gallery_scale.patch

mythplugins/mythgallery/mythgallery/glsingleview.cpp

@@ -75 +75 @@
       // General
       m_source_x(0.0f),
       m_source_y(0.0f),
-      m_scaleMax(false),
+      m_scaleMax(kScaleToFit),
 
       // Texture variables (for display and effects)
       m_texMaxDim(512),
@@ -96 +96 @@
       m_effect_cube_yrot(0.0f),
       m_effect_cube_zrot(0.0f)
 {
-    m_scaleMax = (gContext->GetNumSetting("GalleryScaleMax", 0) > 0);
+    m_scaleMax = (ScaleMax) gContext->GetNumSetting("GalleryScaleMax", 0);
 
     m_slideshow_timer = new QTimer(this);
     RegisterEffects();
@@ -139 +139 @@
 GLSingleView::~GLSingleView()
 {
     // save the current m_scaleMax setting so we can restore it later
-    gContext->SaveSetting("GalleryScaleMax", (m_scaleMax ? "1" : "0"));
+    gContext->SaveSetting("GalleryScaleMax", m_scaleMax);
     CleanUp();
 }
 
@@ -457 +457 @@
         }
         else if (action == "FULLSCREEN")
         {
-            m_scaleMax = !m_scaleMax;
+            m_scaleMax = (ScaleMax) ((m_scaleMax + 1) % kScaleMaxCount);
             m_source_x = 0;
             m_source_y = 0;
             SetZoom(1.0f);

mythplugins/mythgallery/mythgallery/galleryutil.h

@@ -24 +24 @@
 
 #include "iconview.h"
 
+typedef enum {
+  kScaleToFit,
+  kScaleToFill,
+  kReduceToFit,
+  kScaleMaxCount        // must be last
+} ScaleMax;
+
 class GalleryUtil
 {
  public:
@@ -41 +48 @@
                               int sortorder, bool recurse,
                               ThumbHash *itemHash, ThumbGenerator *thumbGen);
 
-    static QSize ScaleToDest(const QSize &sz, const QSize &dest, bool scaleMax);
+    static QSize ScaleToDest(const QSize &sz, const QSize &dest, ScaleMax scaleMax);
 
     static bool CopyMove(const QFileInfo &src, QFileInfo &dst, bool move)
         { if (move) return Move(src, dst); else return Copy(src, dst); }

mythplugins/mythgallery/mythgallery/glsingleview.h

@@ -107 +107 @@
     // General
     float         m_source_x;
     float         m_source_y;
-    bool          m_scaleMax;
+    ScaleMax      m_scaleMax;
 
     // Texture variables (for display and effects)
     int           m_texMaxDim;

mythplugins/mythgallery/mythgallery/singleview.cpp

@@ -61 +61 @@
       m_pixmap(NULL),
       m_angle(0),
       m_source_loc(0,0),
-      m_scaleMax(false),
+      m_scaleMax(kScaleToFit),
 
       // Info variables
       m_info_pixmap(NULL),
@@ -93 +93 @@
       m_effect_milti_circle_out_points(4),
       m_effect_circle_out_points(4)
 {
-    m_scaleMax = (gContext->GetNumSetting("GalleryScaleMax", 0) > 0);
+    m_scaleMax = (ScaleMax) gContext->GetNumSetting("GalleryScaleMax", 0);
 
     m_slideshow_timer = new QTimer(this);
     RegisterEffects();
@@ -175 +175 @@
     }
 
     // save the current m_scaleMax setting so we can restore it later
-    gContext->SaveSetting("GalleryScaleMax", (m_scaleMax ? "1" : "0"));
+    gContext->SaveSetting("GalleryScaleMax", m_scaleMax);
 }
 
 void SingleView::paintEvent(QPaintEvent *)
@@ -516 +516 @@
         }
         else if (action == "FULLSCREEN")
         {
-            m_scaleMax = !m_scaleMax;
+            m_scaleMax = (ScaleMax) ((m_scaleMax + 1) % kScaleMaxCount);
             m_source_loc = QPoint(0, 0);
             SetZoom(1.0f);
         }

mythplugins/mythgallery/mythgallery/singleview.h

@@ -36 +36 @@
 // MythTV plugin headers
 #include <mythtv/mythdialogs.h>
 
+#include "galleryutil.h"
 #include "imageview.h"
 #include "iconview.h"
 #include "sequence.h"
@@ -109 +110 @@
     QImage        m_image;
     int           m_angle;
     QPoint        m_source_loc;
-    bool          m_scaleMax;
+    ScaleMax      m_scaleMax;
 
     // Info variables
     QPixmap      *m_info_pixmap;

mythplugins/mythgallery/mythgallery/gltexture.cpp

@@ -84 +84 @@
     glEnd();
 }
 
-void GLTexture::ScaleTo(const QSize &dest, bool scaleMax)
+void GLTexture::ScaleTo(const QSize &dest, ScaleMax scaleMax)
 {
     QSize sz = GalleryUtil::ScaleToDest(GetSize(), dest, scaleMax);
     if ((sz.width()   > 0) && (sz.height()   > 0) &&

mythplugins/mythgallery/mythgallery/gltexture.h

@@ -27 +27 @@
 #include <QtOpenGL>
 #include <QSize>
 
+// MythGallery headers
+#include "galleryutil.h"
+
 class ThumbItem;
 
 class GLTexture
@@ -50 +53 @@
         { width = sz.width(); height = sz.height(); }
     void SetScale(float x, float y)
         { cx = x; cy = y; }
-    void ScaleTo(const QSize &dest, bool scaleMax);
+    void ScaleTo(const QSize &dest, ScaleMax scaleMax);
     void SetAngle(int newangle) { angle = newangle; }
 
     // Gets

mythplugins/mythgallery/mythgallery/galleryutil.cpp

@@ -460 +460 @@
     return false;
 }
 
-QSize GalleryUtil::ScaleToDest(const QSize &src, const QSize &dest, bool scaleMax)
+QSize GalleryUtil::ScaleToDest(const QSize &src, const QSize &dest, ScaleMax scaleMax)
 {
     QSize sz = src;
 
@@ -472 +472 @@
     if ((sz.width() > 0) && (sz.height() > 0))
         imageAspect = (double)sz.width() / (double)sz.height();
 
-    int scaleWidth;
-    int scaleHeight;
-    if (scaleMax)
+    int scaleWidth = sz.width();
+    int scaleHeight = sz.height();
+
+    switch (scaleMax)
     {
+    case kScaleToFill:
         // scale-max to dest width for most images
         scaleWidth = dest.width();
         scaleHeight = (int)((float)dest.width() * pixelAspect / imageAspect);
@@ -485 +487 @@
             scaleWidth = (int)((float)dest.height() * imageAspect / pixelAspect);
             scaleHeight = dest.height();
         }
-    }
-    else
-    {
+        break;
+
+    case kReduceToFit:
+        // Reduce to fit (but never enlarge)
+        if (scaleWidth <= dest.width() && scaleHeight <= dest.height())
+            break;
+        // Fall through
+
+    case kScaleToFit:
         // scale-min to dest height for most images
         scaleWidth = (int)((float)dest.height() * imageAspect / pixelAspect);
         scaleHeight = dest.height();
@@ -497 +505 @@
             scaleWidth = dest.width();
             scaleHeight = (int)((float)dest.width() * pixelAspect / imageAspect);
         }
+        break;
+
+    default:
+        break;
     }
 
-    sz.scale(scaleWidth, scaleHeight, Qt::KeepAspectRatio);
+    if (scaleWidth != sz.width() || scaleHeight != sz.height())
+        sz.scale(scaleWidth, scaleHeight, Qt::KeepAspectRatio);
     return sz;
 }