Ticket #6591: mythtv-6591-check_return_value_of_MSqlQuery_exec-important.patch
File mythtv-6591-check_return_value_of_MSqlQuery_exec-important.patch, 4.1 KB (added by , 12 years ago) |
---|
-
libs/libmythtv/dbcheck.cpp
old new 359 359 360 360 QString thequery = "DELETE FROM settings WHERE value='DBSchemaVer';"; 361 361 query.prepare(thequery); 362 query.exec();363 362 364 if ( query.lastError().type() != QSqlError::NoError)363 if (!query.exec()) 365 364 { 366 365 QString msg = 367 366 QString("DB Error (Deleting old DB version number): \n" … … 377 376 thequery = QString("INSERT INTO settings (value, data, hostname) " 378 377 "VALUES ('DBSchemaVer', %1, NULL);").arg(newnumber); 379 378 query.prepare(thequery); 380 query.exec();381 379 382 if ( query.lastError().type() != QSqlError::NoError)380 if (!query.exec()) 383 381 { 384 382 QString msg = 385 383 QString("DB Error (Setting new DB version number): \n" -
libs/libmythtv/scheduledrecording.cpp
old new 991 991 thequery ="SELECT GET_LOCK(:LOCK, 2);"; 992 992 query.prepare(thequery); 993 993 query.bindValue(":LOCK", "DiffSchedule"); 994 query.exec(); 995 if (query.lastError().type() != QSqlError::NoError) 994 if (!query.exec()) 996 995 { 997 996 QString msg = 998 997 QString("DB Error (Obtaining lock in testRecording): \n" … … 1006 1005 1007 1006 thequery = QString("DROP TABLE IF EXISTS %1;").arg(ttable); 1008 1007 query.prepare(thequery); 1009 query.exec(); 1010 if (query.lastError().type() != QSqlError::NoError) 1008 if (!query.exec()) 1011 1009 { 1012 1010 QString msg = 1013 1011 QString("DB Error (deleting old table in testRecording): \n" … … 1020 1018 1021 1019 thequery = QString("CREATE TABLE %1 SELECT * FROM record;").arg(ttable); 1022 1020 query.prepare(thequery); 1023 query.exec(); 1024 if (query.lastError().type() != QSqlError::NoError) 1021 if (!query.exec()) 1025 1022 { 1026 1023 QString msg = 1027 1024 QString("DB Error (create new table): \n" … … 1052 1049 thequery = "SELECT RELEASE_LOCK(:LOCK);"; 1053 1050 query.prepare(thequery); 1054 1051 query.bindValue(":LOCK", "DiffSchedule"); 1055 query.exec(); 1056 if (query.lastError().type() != QSqlError::NoError) 1052 if (!query.exec()) 1057 1053 { 1058 1054 QString msg = 1059 1055 QString("DB Error (free lock): \n" -
programs/mythfrontend/custompriority.cpp
old new 388 388 thequery = "SELECT GET_LOCK(:LOCK, 2);"; 389 389 query.prepare(thequery); 390 390 query.bindValue(":LOCK", "DiffSchedule"); 391 query.exec(); 392 if (query.lastError().type() != QSqlError::NoError) 391 if (!query.exec()) 393 392 { 394 393 QString msg = 395 394 QString("DB Error (Obtaining lock in testRecording): \n" … … 402 401 403 402 thequery = QString("DROP TABLE IF EXISTS %1;").arg(ttable); 404 403 query.prepare(thequery); 405 query.exec(); 406 if (query.lastError().type() != QSqlError::NoError) 404 if (!query.exec()) 407 405 { 408 406 QString msg = 409 407 QString("DB Error (deleting old table in testRecording): \n" … … 417 415 thequery = QString("CREATE TABLE %1 SELECT * FROM powerpriority;") 418 416 .arg(ttable); 419 417 query.prepare(thequery); 420 query.exec(); 421 if (query.lastError().type() != QSqlError::NoError) 418 if (!query.exec()) 422 419 { 423 420 QString msg = 424 421 QString("DB Error (create new table): \n" … … 457 454 thequery = "SELECT RELEASE_LOCK(:LOCK);"; 458 455 query.prepare(thequery); 459 456 query.bindValue(":LOCK", "DiffSchedule"); 460 query.exec(); 461 if (query.lastError().type() != QSqlError::NoError) 457 if (!query.exec()) 462 458 { 463 459 QString msg = 464 460 QString("DB Error (free lock): \n"