Ticket #7169: programs_mythfrontend-pass-by-value

Change to pass-by-reference or pass-by-pointer where pass-by-value is too heavy.

From: Erik Hovland <erik@hovland.org>


---

 mythtv/programs/mythfrontend/schedulecommon.cpp |    6 +++---
 mythtv/programs/mythfrontend/schedulecommon.h   |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)


diff --git a/mythtv/programs/mythfrontend/schedulecommon.cpp b/mythtv/programs/mythfrontend/schedulecommon.cpp
index ad9c0fd..21d1635 100644
--- a/mythtv/programs/mythfrontend/schedulecommon.cpp
+++ b/mythtv/programs/mythfrontend/schedulecommon.cpp
@@ -137,7 +137,7 @@ void ScheduleCommon::MakeOverride(RecordingInfo *recinfo)
 *  \brief Creates a dialog displaying current recording status and options
 *         available
 */
-void ScheduleCommon::ShowRecordingDialog(RecordingInfo recinfo)
+void ScheduleCommon::ShowRecordingDialog(const RecordingInfo& recinfo)
 {
     QString message = recinfo.title;
     
@@ -248,7 +248,7 @@ void ScheduleCommon::ShowRecordingDialog(RecordingInfo recinfo)
 *  \brief Creates a dialog displaying current recording status and options
 *         available
 */
-void ScheduleCommon::ShowNotRecordingDialog(RecordingInfo recinfo)
+void ScheduleCommon::ShowNotRecordingDialog(const RecordingInfo& recinfo)
 {
     QString timeFormat = gContext->GetSetting("TimeFormat", "h:mm AP");
 
@@ -500,7 +500,7 @@ void ScheduleCommon::customEvent(QEvent *event)
 *  \brief Returns true if a search should be employed to find a matching
 *         program.
 */
-bool ScheduleCommon::IsFindApplicable(RecordingInfo recInfo) const
+bool ScheduleCommon::IsFindApplicable(const RecordingInfo& recInfo) const
 {
     return recInfo.rectype == kFindDailyRecord ||
            recInfo.rectype == kFindWeeklyRecord;
diff --git a/mythtv/programs/mythfrontend/schedulecommon.h b/mythtv/programs/mythfrontend/schedulecommon.h
index 19926c8..987c0f3 100644
--- a/mythtv/programs/mythfrontend/schedulecommon.h
+++ b/mythtv/programs/mythfrontend/schedulecommon.h
@@ -24,13 +24,13 @@ class ScheduleCommon : public MythScreenType
     void EditScheduled(ProgramInfo *pginfo);
     void EditScheduled(RecordingInfo *recinfo);
     void MakeOverride(RecordingInfo *recinfo);
-    void ShowRecordingDialog(RecordingInfo recinfo);
-    void ShowNotRecordingDialog(RecordingInfo recinfo);
+    void ShowRecordingDialog(const RecordingInfo& recinfo);
+    void ShowNotRecordingDialog(const RecordingInfo& recinfo);
 
     virtual void customEvent(QEvent*);
 
   private:
-    bool IsFindApplicable(RecordingInfo recInfo) const;
+    bool IsFindApplicable(const RecordingInfo& recInfo) const;
         
 };