Ticket #7525: mythui_pulse_optimize_v2.patch

libs/libmythui/mythuitype.cpp

@@ -45 +45 @@
     m_XYSpeed = QPoint(0, 0);
     m_deferload = false;
 
+    m_NextPulse = (1 << animNUMTYPES) - 1; // all bits set
+    m_NextChildPulse = 0;
+
     m_Parent = NULL;
     if (parent)
     {
@@ -70 +73 @@
  */
 void MythUIType::Reset()
 {
+    SetNextPulse(true);
     // Reset all children
     QMutableListIterator<MythUIType *> it(m_ChildrenList);
     while (it.hasNext())
@@ -89 +93 @@
         return;
 
     m_ChildrenList.push_back(child);
+    FixupNextChildPulse();
 }
 
 static QObject *qChildHelper(const char *objName, const char *inheritsClass,
@@ -150 +155 @@
         {
             type->deleteLater();
             it.remove();
+            FixupNextChildPulse();
             return;
         }
     }
@@ -172 +178 @@
         {
             type->deleteLater();
             it.remove();
+            FixupNextChildPulse();
             child = NULL;
             return;
         }
@@ -198 +205 @@
     }
 
     m_ChildrenList.clear();
+    FixupNextChildPulse();
 }
 
 /** \brief Return the first MythUIType which accepts focus found at the given
@@ -325 +333 @@
 void MythUIType::HandleMovementPulse(void)
 {
     if (!GetMythPainter()->SupportsAnimation())
+    {
+        SetNextPulse(animMovement, false);
         return;
+    }
 
     if (!m_Moving)
+    {
+        SetNextPulse(animMovement, false);
         return;
+    }
 
     QPoint curXY = m_Area.topLeft().toQPoint();
     m_DirtyRegion = m_Area.toQRect();
@@ -362 +376 @@
     }
 
     m_Area.moveTopLeft(curXY);
+    SetNextPulse(animMovement, m_Moving);
 }
 
 /**
@@ -373 +388 @@
 {
     if (!GetMythPainter()->SupportsAlpha() ||
         !GetMythPainter()->SupportsAnimation())
+    {
+        SetNextPulse(animAlpha, false);
         return;
+    }
 
     if (m_AlphaChangeMode == 0)
+    {
+        SetNextPulse(animAlpha, false);
         return;
+    }
 
     m_Alpha += m_AlphaChange;
 
@@ -400 +421 @@
     }
 
     SetRedraw();
+    SetNextPulse(animAlpha, (m_AlphaChangeMode != 0));
 }
 
 /**
@@ -413 +435 @@
     if (!m_Visible)
         return;
 
-    HandleMovementPulse();
-    HandleAlphaPulse();
+    if (m_NextPulse & (1 << animMovement))
+        HandleMovementPulse();
+    if (m_NextPulse & (1 << animAlpha))
+        HandleAlphaPulse();
 
-    QList<MythUIType *>::Iterator it;
-    for (it = m_ChildrenList.begin(); it != m_ChildrenList.end(); ++it)
-        (*it)->Pulse();
+    if (m_NextChildPulse & (1 << animPulse))
+    {
+        QList<MythUIType *>::Iterator it;
+        for (it = m_ChildrenList.begin(); it != m_ChildrenList.end(); ++it)
+            (*it)->Pulse();
+    }
+    SetNextPulse(animPulse, false);
 }
 
 int MythUIType::CalcAlpha(int alphamod)
@@ -663 +691 @@
                              int maxalpha)
 {
     if (!GetMythPainter()->SupportsAlpha())
+    {
+        SetNextPulse(animAlpha, false);
         return;
+    }
 
     m_AlphaChangeMode = mode;
     m_AlphaChange = alphachange;
@@ -674 +705 @@
         m_Alpha = m_AlphaMax;
     if (m_Alpha < m_AlphaMin)
         m_Alpha = m_AlphaMin;
+    SetNextPulse(animAlpha, (m_AlphaChangeMode != 0));
 }
 
 void MythUIType::SetAlpha(int newalpha)
@@ -757 +789 @@
         emit Showing();
     else
         emit Hiding();
+    FixupNextChildPulse();
 }
 
 void MythUIType::SetEnabled(bool enable)
@@ -824 +857 @@
     m_XYSpeed = base->m_XYSpeed;
     m_deferload = base->m_deferload;
 
+    m_NextPulse = m_Visible ? (1 << animNUMTYPES) - 1 : 0;
+    FixupNextChildPulse();
+
     QList<MythUIType *>::Iterator it;
     for (it = base->m_ChildrenList.begin(); it != base->m_ChildrenList.end();
          ++it)
@@ -1009 +1045 @@
     return false;
 }
 
+// Recompute m_NextChildPulse, and if anything has changed, continue
+// up the tree.
+void MythUIType::FixupNextChildPulse(bool recomputeChildren)
+{
+    for (MythUIType *current=this; current; current=current->m_Parent)
+    {
+        unsigned oldNextPulse = current->m_NextPulse;
+        unsigned oldNextChildPulse = current->m_NextChildPulse;
+
+        if (current->m_Visible)
+        {
+            // If necessary, recompute m_NextChildPulse as the min of
+            // m_NextPulse and m_NextChildPulse across all children.
+            if (recomputeChildren)
+            {
+                current->m_NextChildPulse = 0;
+                QList<MythUIType*>::iterator it;
+                for (it = current->m_ChildrenList.begin(); it != current->m_ChildrenList.end(); ++it)
+                {
+                    current->m_NextChildPulse |= (*it)->m_NextPulse;
+                    current->m_NextChildPulse |= (*it)->m_NextChildPulse;
+                }
+            }
+
+        } else {
+            current->m_NextPulse = 0;
+            current->m_NextChildPulse = 0;
+        }
+
+        // If anything changed, continue up the tree.  Also continue
+        // if current=this, since the method might have been called as
+        // a result of m_NextPulse changing.
+        unsigned oldmin = oldNextPulse | oldNextChildPulse;
+        unsigned newmin = current->m_NextPulse | current->m_NextChildPulse;
+        if (oldmin == newmin && current != this)
+            break;
+        recomputeChildren = true;
+    }
+}
+
+void MythUIType::SetNextPulse(AnimationType type, bool flag)
+{
+    unsigned oldMask = m_NextPulse;
+    if (flag)
+        m_NextPulse |= (1 << type);
+    else
+        m_NextPulse &= ~(1 << type);
+    if (m_NextPulse != oldMask)
+        FixupNextChildPulse(false);
+}
+
+void MythUIType::SetNextPulse(bool flag)
+{
+    for (unsigned i=0; i<animNUMTYPES; i++)
+        SetNextPulse((AnimationType)i, flag);
+}

libs/libmythui/mythuitype.h

@@ -121 +121 @@
 
     bool ContainsPoint(const QPoint &point) const;
 
+    enum AnimationType {
+        animMovement=0,
+        animAlpha,
+        animPulse,
+        animNUMTYPES
+    };
+    void SetNextPulse(AnimationType type, bool flag); // true=asap, false=never
+    void SetNextPulse(bool flag); // true=asap, false=never
+    void FixupNextChildPulse(bool recomputeChildren=true);
+
   protected:
     virtual void customEvent(QEvent *);
 
@@ -190 +200 @@
     QPoint m_XYDestination;
     QPoint m_XYSpeed;
 
+    unsigned m_NextPulse;
+    unsigned m_NextChildPulse;
+
     FontMap *m_Fonts;
 
     MythUIType *m_Parent;

libs/libmythui/mythuiimage.cpp

@@ -284 +284 @@
     m_Delay = delayms;
     m_LastDisplay = QTime::currentTime();
     m_CurPos = 0;
+    SetNextPulse(animPulse, (m_Delay > 0));
 }
 
 /**
@@ -302 +303 @@
     m_Filename = img->GetFileName();
     Clear();
     m_Delay = -1;
+    SetNextPulse(animPulse, false);
 
     img->UpRef();
 
@@ -853 +855 @@
     }
 
     MythUIType::Pulse();
+    SetNextPulse(animPulse, (m_Delay > 0));
 }
 
 /**
@@ -999 +1002 @@
     else if (element.tagName() == "crop")
         m_cropRect = parseRect(element);
     else if (element.tagName() == "delay")
+    {
         m_Delay = getFirstText(element).toInt();
+        SetNextPulse(animPulse, (m_Delay > 0));
+    }
     else if (element.tagName() == "reflection")
     {
         m_isReflected = true;

libs/libmythui/mythuitext.cpp

@@ -453 +453 @@
     //
 
     MythUIType::Pulse();
+    SetNextPulse(animPulse, (m_colorCycling || m_scrolling));
 
     if (m_colorCycling)
     {

libs/libmythui/mythuiwebbrowser.cpp

@@ -621 +621 @@
     }
 
     MythUIType::Pulse();
+    SetNextPulse(animPulse, (m_updateInterval != 0));
 }
 
 /**

libs/libmythui/mythuitextedit.cpp

@@ -78 +78 @@
 void MythUITextEdit::Pulse(void)
 {
     if (!m_cursorImage)
+    {
+        SetNextPulse(animPulse, false);
         return;
+    }
 
     if (m_HasFocus)
     {
@@ -102 +105 @@
         m_cursorImage->SetVisible(false);
 
     MythUIType::Pulse();
+    SetNextPulse(animPulse, true);
 }
 
 bool MythUITextEdit::ParseElement(

libs/libmythui/mythuiclock.cpp

@@ -64 +64 @@
     }
 
     MythUIText::Pulse();
+    SetNextPulse(animPulse, true);
 }
 
 /**