Ticket #8856: StartRecording-WaitForTune-v2.patch

libs/libmythtv/tv_rec.cpp

@@ -122 +122 @@
       stateChangeLock(QMutex::Recursive),
       pendingRecLock(QMutex::Recursive),
       internalState(kState_None), desiredNextState(kState_None),
-      changeState(false), pauseNotify(true),
+      changeState(false), m_SMdone(true), pauseNotify(true),
       stateFlags(0), lastTuningRequest(0),
       triggerEventLoopLock(QMutex::NonRecursive),
       triggerEventLoopSignal(false),
@@ -1618 +1618 @@
         stateChangeLock.lock();
 
         // verify that we were triggered.
-        ok = (tuningRequests.empty() && !changeState);
+        ok = (tuningRequests.empty() && m_SMdone && !changeState);
     }
     return ok;
 }
@@ -3507 +3507 @@
 
         // The dequeue isn't safe to do until now because we
         // release the stateChangeLock to teardown a recorder
+        if (request.flags & kFlagRecording)
+            m_SMdone = false;
         tuningRequests.dequeue();
 
         // Now we start new stuff
@@ -3542 +3544 @@
     if (HasFlags(kFlagWaitingForSignal) && !(streamData = TuningSignalCheck()))
         return;
 
+    m_SMdone = true;
+
     if (HasFlags(kFlagNeedToStartRecorder))
     {
         if (recorder)
@@ -3788 +3792 @@
     if (!channum.isEmpty())
     {
         if (!input.isEmpty())
-            ok = channel->SelectInput(input, channum, true);
+            channel->SelectInput(input, channum, true);
         else
-        {
             channel->SelectChannel(channum, true);
-            ok = true;
-        }
     }
 
-    if (!ok)
-    {
-        if (!(request.flags & kFlagLiveTV) || !(request.flags & kFlagEITScan))
-        {
-            if (curRecording)
-                curRecording->SetRecordingStatus(rsFailed);
-
-            VERBOSE(VB_IMPORTANT, LOC_ERR +
-                    QString("Failed to set channel to %1. "
-                            "Reverting to kState_None")
-                    .arg(channum));
-            if (kState_None != internalState)
-                ChangeState(kState_None);
-            else
-                tuningRequests.enqueue(TuningRequest(kFlagKillRec));
-            return;
-        }
-        else
-        {
-            VERBOSE(VB_IMPORTANT, LOC_ERR +
-                    QString("Failed to set channel to %1.").arg(channum));
-        }
-    }
-
     // Start signal (or channel change) monitoring
     VERBOSE(VB_RECORD, LOC + "Starting Signal Monitor");
     bool error = false;

libs/libmythtv/tv_rec.h

@@ -355 +355 @@
     TVState        internalState;
     TVState        desiredNextState;
     bool           changeState;
+    bool           m_SMdone;
     bool           pauseNotify;
     uint           stateFlags;
     TuningQueue    tuningRequests;