Changeset 2b3bd21a4 in mythtv

Timestamp:

Aug 13, 2012, 5:43:08 AM (12 years ago)

Author:

Chris Pinkham <cpinkham@…>

Branches:

devel/2020-player, devel/ffmpeg-resync, fixes/0.26, fixes/0.27, fixes/0.28, fixes/29, fixes/30, fixes/31, github-templates, master

Children:

82318f638

Parents:

5ff8a8a410

git-author:

Chris Pinkham <cpinkham@…> (08/13/12 05:43:08)

git-committer:

Chris Pinkham <cpinkham@…> (08/13/12 05:47:51)

Message:

Revert [6fb8692] to not use aacenc.c AAC encoder by default.

We've been recommended not to use the native AAC encoder by default
since there are still some known issues with the encoder. This
commit tries to be as minimally invasive as possible since we're
close to release, but it does change it so that the native AAC
encoder in libavcodec is not used unless neither libmp3lame nor
libfaac support was configured.

If the native AAC encoder is working fine for you then you don't
have to do anything. If you want to use libmp3lame as MythTV v0.25
used, then configure MythTV with --enable-libmp3lame. If you wish
to use AAC but prefer libfaac over the native AAC encoder, then
you can run configure with --enable-libfaac --enable-nonfree. If
both --enable-libmp3lame and --enable-libfaac are used, then
libfaac will take precedence.

Location:

mythtv

Files:

• libs/libmythtv/avformatwriter.cpp (modified) (1 diff)
• programs/mythtranscode/transcode.cpp (modified) (2 diffs)

mythtv/libs/libmythtv/avformatwriter.cpp

@@ -606 +606 @@
     c->codec_type = AVMEDIA_TYPE_AUDIO;
 
-    if (c->codec_id == CODEC_ID_MP3)
+    if (!gCoreContext->GetSetting("HLSAUDIO").isEmpty())
+    {
+        if (gCoreContext->GetSetting("HLSAUDIO") == "aac")
+            c->sample_fmt = AV_SAMPLE_FMT_FLT;
+        else
+            c->sample_fmt = AV_SAMPLE_FMT_S16;
+    }
+    else
+#if CONFIG_LIBMP3LAME_ENCODER || CONFIG_LIBFAAC_ENCODER
         c->sample_fmt = AV_SAMPLE_FMT_S16;
-    else
+#else
         c->sample_fmt = AV_SAMPLE_FMT_FLT;
+#endif
 
     m_audioBytesPerSample = m_audioChannels *

mythtv/programs/mythtranscode/transcode.cpp

@@ -1098 +1098 @@
                 avfw2->SetContainer("mpegts");
 
-                if (gCoreContext->GetNumSetting("HLSAACAUDIO", 1))
-                    avfw2->SetAudioCodec("aac");
+                if (!gCoreContext->GetSetting("HLSAUDIO").isEmpty())
+                    avfw2->SetAudioCodec(gCoreContext->GetSetting("HLSAUDIO"));
                 else
-                    avfw2->SetAudioCodec("libmp3lame");
+#if CONFIG_LIBFAAC_ENCODER
+                avfw2->SetAudioCodec("libfaac");
+#else
+# if CONFIG_LIBMP3LAME_ENCODER
+                avfw2->SetAudioCodec("libmp3lame");
+# else
+                avfw2->SetAudioCodec("aac");
+# endif
+#endif
 
                 avfw2->SetAudioBitrate(audioOnlyBitrate);
@@ -1113 +1121 @@
             avfw->SetVideoCodec("libx264");
 
-            if (gCoreContext->GetNumSetting("HLSAACAUDIO", 1))
+            if (!gCoreContext->GetSetting("HLSAUDIO").isEmpty())
+                avfw->SetAudioCodec(gCoreContext->GetSetting("HLSAUDIO"));
+            else
+#if CONFIG_LIBFAAC_ENCODER
+                avfw->SetAudioCodec("libfaac");
+#else
+# if CONFIG_LIBMP3LAME_ENCODER
+                avfw->SetAudioCodec("libmp3lame");
+# else
                 avfw->SetAudioCodec("aac");
-            else
-                avfw->SetAudioCodec("libmp3lame");
+# endif
+#endif
 
             if (hlsStreamID == -1)