Changeset 8f1ab5426 in mythtv

Timestamp:

Jul 5, 2017, 8:59:37 PM (7 years ago)

Author:

Bill Meek <bmeek@…>

Branches:

devel/2020-player, devel/ffmpeg-resync, fixes/29, fixes/30, fixes/31, github-templates, master

Children:

0b7e144d87, 7388b5a60

Parents:

606192062

Message:

Services API: Log more Guide/GetChannelIcon? errors

The primary fix is for folks that create a link between
~mythtv/.mythtv/channels and ~/.mythtv/channels, but
forget to make their channels directory writable by
the user running the backend. The link solution (rather
than running mythtv-setup as user mythtv) appears in
the Wiki and the Forum. When the new copy of the image
is attempted, e.g using Height=57, it failed.

Log and tell the user if the ChanId? doesn't exist or is
marked invisible.

If the image can't be scaled, log the error. Happens now
when lyngsat returns text files rather than images.

Use upnp filtering to see the new logs.

File:

• mythtv/programs/mythbackend/services/guide.cpp (modified) (5 diffs)

mythtv/programs/mythbackend/services/guide.cpp

@@ -374 +374 @@
 
     if (sFileName.isEmpty())
-        return QFileInfo();
+    {
+        LOG(VB_UPNP, LOG_ERR,
+            QString("GetImageFile - ChanId %1 doesn't exist or isn't visible")
+                    .arg(nChanId));
+        return QFileInfo();
+    }
 
     // ------------------------------------------------------------------
@@ -425 +430 @@
     // ----------------------------------------------------------------------
 
+    QString sChannelsDirectory = QFileInfo( sNewFileName ).absolutePath();
+
+    if (!QFileInfo( sChannelsDirectory ).isWritable())
+    {
+        LOG(VB_UPNP, LOG_ERR, QString("GetImageFile - no write access to: %1")
+            .arg( sChannelsDirectory ));
+        return QFileInfo();
+    }
+
     float fAspect = 0.0;
 
@@ -430 +444 @@
 
     if (!pImage)
-        return QFileInfo();
+    {
+        LOG(VB_UPNP, LOG_ERR, QString("GetImageFile - can't create image: %1")
+            .arg( sFullFileName ));
+        return QFileInfo();
+    }
 
     if (fAspect <= 0)
@@ -437 +455 @@
     if (fAspect == 0)
     {
+        LOG(VB_UPNP, LOG_ERR, QString("GetImageFile - zero aspect"));
         delete pImage;
         return QFileInfo();
@@ -450 +469 @@
                                 Qt::SmoothTransformation);
 
-    img.save( sNewFileName, "PNG" );
+    if (img.isNull())
+    {
+        LOG(VB_UPNP, LOG_ERR, QString("SaveImageFile - unable to scale. "
+            "See if %1 is really an image.").arg( sFullFileName ));
+        delete pImage;
+        return QFileInfo();
+    }
+
+    if (!img.save( sNewFileName, "PNG" ))
+    {
+        LOG(VB_UPNP, LOG_ERR, QString("SaveImageFile - failed, %1")
+            .arg( sNewFileName ));
+        delete pImage;
+        return QFileInfo();
+    }
 
     delete pImage;