Changeset b28041a11 in mythtv

Timestamp:

Nov 21, 2012, 3:27:31 PM (12 years ago)

Author:

Daniel Thor Kristjansson <danielk@…>

Branches:

fixes/0.26

Children:

93204a3747

Parents:

3c359636b

git-author:

Daniel Thor Kristjansson <danielk@…> (11/21/12 15:27:31)

git-committer:

Stuart Morgan <smorgan@…> (12/02/12 14:00:44)

Message:

Fix #10995. Default to local time for mythshutdown --setwakeup.

Location:

mythtv/programs/mythshutdown

Files:

• commandlineparser.cpp (modified) (2 diffs)
• main.cpp (modified) (3 diffs)

mythtv/programs/mythshutdown/commandlineparser.cpp

@@ -23 +23 @@
          << add(QStringList( QStringList() << "-w" << "--setwakeup" ),
                 "setwakeup", "",
-                "Set the wakeup time (yyyy-MM-ddThh:mm:ss)", "")
+                "Set the wakeup time (yyyy-MM-ddThh:mm:ss) "
+                "default is in local time", "")
          << add(QStringList( QStringList() << "-t" << "--setscheduledwakeup" ),
                 "setschedwakeup", false,
@@ -67 +68 @@
                 "       128 - Less than 15 minutes to next wakeup period\n"
                 "       255 - Setup is running") );
+
+    // The localtime command line parameter exists solely to make scripts
+    // using this executable self documenting.
+
+    CommandLineArg::AllowOneOf( QList<CommandLineArg*>()
+         << add("--utc",
+                "utc", false,
+                "Specify that the wakeup time is in utc", "")
+         << add("--localtime",
+                "localtime", false,
+                "Specify that the wakeup time is in local time", "") );
 }
 

mythtv/programs/mythshutdown/main.cpp

@@ -376 +376 @@
 }
 
-static int setWakeupTime(QString sWakeupTime)
+static void setWakeupTime(const QDateTime &wakeupTime)
 {
     LOG(VB_GENERAL, LOG_INFO, "Mythshutdown: --setwakeup");
 
     LOG(VB_GENERAL, LOG_NOTICE,
-        QString("Mythshutdown: wakeup time given is: %1").arg(sWakeupTime));
-
-    // check time given is valid
-    QDateTime dtWakeupTime;
-    dtWakeupTime = MythDate::fromString(sWakeupTime);
-
-    if (!dtWakeupTime.isValid())
-    {
-        LOG(VB_GENERAL, LOG_ERR,
-            QString("Mythshutdown: --setwakeup invalid date "
-                                      "format (%1)\n\t\t\t"
-                                      "must be yyyy-MM-ddThh:mm:ss")
-                                      .arg(sWakeupTime));
-        return 1;
-    }
+        QString("Mythshutdown: wakeup time given is: %1 (local time)")
+        .arg(MythDate::toString(wakeupTime)));
 
     setGlobalSetting("MythShutdownNextScheduled",
-                     MythDate::toString(dtWakeupTime, MythDate::kDatabase));
-
-    return 0;
+                     MythDate::toString(wakeupTime, MythDate::kDatabase));
 }
 
@@ -433 +418 @@
             restarttime = restarttime.addSecs((-1) * add);
 
-        setWakeupTime(restarttime.toString(Qt::ISODate));
+        setWakeupTime(restarttime);
 
         return 0;
@@ -822 +807 @@
         res = getStatus((bool)(cmdline.toInt("status") == 1));
     else if (cmdline.toBool("setwakeup"))
-        res = setWakeupTime(cmdline.toString("setwakeup"));
+    {
+        // only one of --utc or --localtime can be passed per
+        // CommandLineArg::AllowOneOf() in commandlineparser.cpp
+        bool utc = cmdline.toBool("utc");
+        QString tmp = cmdline.toString("setwakeup");
+
+        QDateTime wakeuptime = (utc) ?
+            MythDate::fromString(tmp) :
+            QDateTime::fromString(tmp, Qt::ISODate).toUTC();
+
+        if (!wakeuptime.isValid())
+        {
+            cerr << qPrintable(
+                QObject::tr("mythshutdown: --setwakeup invalid date "
+                            "format (%1)\n\t\t\t"
+                            "must be yyyy-MM-ddThh:mm:ss")
+                .arg(tmp)) << endl;
+            res = 1;
+        }
+        else
+        {
+            setWakeupTime(wakeuptime);
+        }
+    }
     else if (cmdline.toBool("safeshutdown"))
     {