Opened 13 years ago

Closed 13 years ago

#10034 closed Patch - Bug Fix (fixed)

[PATCH] configure: Fix checks for Windows/QtDBus

Reported by: Lawrence Rust <lvr@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: Ports - Windows Version: Master Head
Severity: medium Keywords: QtDBus configure
Cc: Ticket locked: no

Description

Commit 9bf9ec907e added some fixes to the configure script to check for QtDBus on Windows using pkg-config and compile time checks. However, when cross-compiling pkg-config can wrongly enable QtDBus by detecting to the host's QtDBus setup. This fix skips all DBus checks if the qtdbus variable is disabled, which it is is the target-os is mingw32.

Attachments (1)

0001-configure-Fix-checks-for-QtDBus.patch​ (1.1 KB) - added by Lawrence Rust <lvr@…> 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Lawrence Rust <lvr@…>

Attachment: 0001-configure-Fix-checks-for-QtDBus.patch​ added

comment:1 Changed 13 years ago by beirdo

This patch does not do what you say it will do. If it's previously disabled, you have made it do the compile check anyways.

comment:2 Changed 13 years ago by beirdo

Owner: changed from Nigel to beirdo
Status: new → assigned

comment:3 Changed 13 years ago by Github

Milestone: unknown → 0.25
Resolution: → fixed
Status: assigned → closed

Skip QTDBus checks if it is already disabled.

Based on a patch from LVR on #10034, except doesn't compile the check when it's already disabled.

Fixes #10034

Branch: master Changeset: 375e66bfe3c068b9ab2ef4fe247746e2f3e45b00

Note: See TracTickets for help on using tickets.