Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#10084 closed Patch - Bug Fix (fixed)

PATCH crash in mythtranscode

Reported by: mythtv@… Owned by:
Priority: minor Milestone: 0.25
Component: MythTV - Mythtranscode Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If there are a great many audio frames without intervening video frames, then ab_count can over run the length of the buffers it indexes. The simple fix is to use allocated buffers and grow them as needed.

There are patches for master, fixes/0.24 and jyavenard/backports/fixes/0.24 on my fork at https://github.com/Glidos/mythtv. The commits are labelled "Handle out of range ab_count". The other commits on those branches relate to Ticket #10008, which also fixes problems in mythtranscode.

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by jyavenard

Can't you just create a pull request and provide this here.

comment:2 Changed 3 years ago by jyavenard

Your commit isn't complete (you probably forgot to commit some files)... I will work on a different solution in the mean time...

comment:3 Changed 3 years ago by jyavenard

After reviewing your patch, it is not functionally equivalent to what was there before. and just can't work.

For example, in an attempt (at a guess) to reformat the code, you do:

ab[ab_count].offset = audiobuffer_len;

but the audiobuffer_len you store has been incremented by len, while before the value stored was prior to the += len.

comment:4 Changed 3 years ago by Github

  • Milestone changed from unknown to 0.25
  • Resolution set to fixed
  • Status changed from new to closed

Fix potential cash in mythtranscode.

Fixes #10084

Branch: master
Changeset: a42b76ccd377ae6750a160ed14b621216a437cc6

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.