Opened 12 years ago
Closed 12 years ago
#10084 closed Patch - Bug Fix (fixed)
PATCH crash in mythtranscode
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | MythTV - Mythtranscode | Version: | Unspecified |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
If there are a great many audio frames without intervening video frames, then ab_count can over run the length of the buffers it indexes. The simple fix is to use allocated buffers and grow them as needed.
There are patches for master, fixes/0.24 and jyavenard/backports/fixes/0.24 on my fork at https://github.com/Glidos/mythtv. The commits are labelled "Handle out of range ab_count". The other commits on those branches relate to Ticket #10008, which also fixes problems in mythtranscode.
Change History (4)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Your commit isn't complete (you probably forgot to commit some files)... I will work on a different solution in the mean time...
comment:3 Changed 12 years ago by
After reviewing your patch, it is not functionally equivalent to what was there before. and just can't work.
For example, in an attempt (at a guess) to reformat the code, you do:
ab[ab_count].offset = audiobuffer_len;
but the audiobuffer_len you store has been incremented by len, while before the value stored was prior to the += len.
comment:4 Changed 12 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fix potential cash in mythtranscode.
Fixes #10084
Branch: master Changeset: a42b76ccd377ae6750a160ed14b621216a437cc6
Can't you just create a pull request and provide this here.