Opened 7 years ago

Last modified 11 months ago

#10092 new Developer Task

mythfrontend setup & MythUI

Reported by: Xavier Hervy <xavier.hervy@…> Owned by: Jonatan Lindblad
Priority: minor Milestone: 30.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords: mythfrontend mythui settings rewrite
Cc: Peter Bennett Ticket locked: no

Description

This patch is nowhere near ready. This is an attempt to convert the mythfrontend screens to the new MythUI. see http://www.gossamer-threads.com/lists/mythtv/dev/493945 for more details. There is bugs in it, such as Load() and Save() do not work properly Also some screen are missing, such as :

  • Video Mode Profile which I complete last week but lost my change
  • Playback Profile for which I need to understand how it is suppose to work at the first place (I believe this is broken in master or buggy)

And the following one which are in different source files

  • Audio settings
  • Playback groups
  • Channel groups
  • Recording profiles
  • Myth Video settings

Some of them, I did not really thought about how to convert them while other are quite easy using the same approach or similar

Attachments (18)

mythfrontendsetup.diff (153.7 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
standardsetting-ui.xml (7.5 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
mythfrontendsetup-2011-10-16.diff (218.5 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Much cleaner, Playback profile partially implemented, default-wide included
mythfrontendsetup-07-02-2012.diff (16.8 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Video General Setting with MythUI with default-wide theme but should be usable with default too as I use relative positionning
mythfrontendsetup-07-02-2012.2.diff (43.5 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Correct previous patch which was missing file
mythfrontendsetup-08-02-2012.diff (105.8 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
More setting converted to MythUI: General, TV Settings General, TV Settings Program Guide, TV Settings PlayBack? OSD, General Video Setting
mythfrontendsetup-14-02-2012.diff (222.8 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Nearly all settings are converted now: selection of play back profile have been removed (working on 2 != computers) I will put it back later. Audio setting mostly done, I need to add the test button + advanced settings. Also Channel groups and Recording profils have not been touch yet
mythfrontendsetup-16-02-2012.diff (236.5 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Pick up directory via MythUIFileBrowser, Use a Spin box dialog #10342 instead of text edit dialog when necessary, add advanced audio setting. Test audio button is still missing
mythfrontendsetup-01-03-2012.diff.tar.gz (46.6 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Few improvements, some cleaning, convert Playback Group Setting to new UI
mythfrontendsetup-2012-03-04.diff.tar.gz (47.9 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Convert Group Channel to MythUI
mythfrontendsetting-2012-03-06.diff.tar.gz (46.2 KB) - added by xavier.hervy@… 7 years ago.
No change, just update to latest git version
mythfrontendsetting-2012-03-06-2.diff.tar.gz (46.0 KB) - added by xavier.hervy@… 7 years ago.
Fix some error due to update + cleanup
mythfrontendsetting-2012-03-08.diff.tar.gz (48.3 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Convert plugin setting to MythUI + move standardsetting classes to libmyth
settings-libmyth-2012-03-09.diff (40.5 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
settings-themes-2012-03-09.diff (14.3 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
settings-mythfrontend-2012-03-09.diff (230.7 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
settings-mythplugins-2012-03-09.diff (34.6 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
settings-mythplugins-2012-03-09-2.diff (34.6 KB) - added by Xavier Hervy <xavier.hervy@…> 7 years ago.
Fix typo, thx knightr

Download all attachments as: .zip

Change History (64)

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Attachment: mythfrontendsetup.diff added

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Attachment: standardsetting-ui.xml added

comment:1 Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

By the way, the xml file have been done for MythCenter?-wide and is a bit dodgy

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Much cleaner, Playback profile partially implemented, default-wide included

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Video General Setting with MythUI with default-wide theme but should be usable with default too as I use relative positionning

comment:2 Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

I attach a new patch, I display the settings in a MythUIListButton object instead of MythUIGenericTree as I had some trouble to properly update the tree otherwise.

On the Last patch I only converted VideoGeneralSetting? to MythUI and would like some feedbacks before converting the other screens.

comment:3 Changed 7 years ago by stuartm

Milestone: unknown0.25
Status: newinfoneeded_new

Xavier, did you miss some changes from the latest patch? You said that you'd changed it to use a buttonlist instead of a tree but I don't see that bit in the new patch. (I have yet to apply/test)

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Correct previous patch which was missing file

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

More setting converted to MythUI: General, TV Settings General, TV Settings Program Guide, TV Settings PlayBack? OSD, General Video Setting

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Nearly all settings are converted now: selection of play back profile have been removed (working on 2 != computers) I will put it back later. Audio setting mostly done, I need to add the test button + advanced settings. Also Channel groups and Recording profils have not been touch yet

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Pick up directory via MythUIFileBrowser, Use a Spin box dialog #10342 instead of text edit dialog when necessary, add advanced audio setting. Test audio button is still missing

comment:4 Changed 7 years ago by beirdo

Owner: set to stuartm

comment:5 Changed 7 years ago by stuartm

Milestone: 0.250.26

comment:6 Changed 7 years ago by stuartm

Status: infoneeded_newnew

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Few improvements, some cleaning, convert Playback Group Setting to new UI

comment:7 Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Also it does rely on three patches against MythUI

comment:8 Changed 7 years ago by stuartm

Type: Bug Report - GeneralPatch - Feature

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Convert Group Channel to MythUI

Changed 7 years ago by xavier.hervy@…

No change, just update to latest git version

Changed 7 years ago by xavier.hervy@…

Fix some error due to update + cleanup

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Convert plugin setting to MythUI + move standardsetting classes to libmyth

comment:9 Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

From now, I will have 4 different patches:

  • libmyth, with the standard settings classes
  • themes, only fro default and defaut-wide
  • mythfrontend
  • mythplugins

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Changed 7 years ago by Xavier Hervy <xavier.hervy@…>

Fix typo, thx knightr

comment:10 Changed 6 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.27

comment:11 Changed 5 years ago by paulh

Milestone: 0.270.28

Any chance of some updates patches? Sadly the patches don't apply any more :(

comment:12 Changed 5 years ago by stuartm

Xavier, we'd really like to get this into the next release, hell we'd even like to get it in NOW if we could. I appreciate that keeping the patches in sync with master was extremely difficult and we'd be willing to help where we can.

comment:13 Changed 5 years ago by Nicolas Riendeau

Just to let interested parties knows and in order to avoid duplicate work I am currently fixing the patches so that they can be applied to current master.

comment:14 Changed 5 years ago by JYA

any update on this?

having it would be a real bonu... thanks for the great work

comment:15 Changed 5 years ago by Nicolas Riendeau

I am sorry Jean-Yves but I really did not have much time to work on MythTV in recent months...

I thought it would be a simple matter of reapplying the patches manually but it turned out that the patches broke not only because of trivial changes but also because some settings were replaced/reorganized and I do not know the UI code well enough (and did not have time to analyze how it worked) to be fully sure of how to fix what was broken... I wanted to contact Stuart about this but totally forgot, sorry...

I can try to reapply them again but this ticket depends on other patches which have not been committed (ticket #10332 and ticket #10342) which really have to be committed to give me a chance of completing this. I could apply those but I would really feel better if it was Stuart or John that did the QC and applied the patches in those two tickets...

Sorry I wish the news about the status of this ticket were better...

Nicolas

comment:16 Changed 5 years ago by JYA

have you made any progress on this?

do you want me to take over?

I have a bit of time right now, and need something to do

comment:17 Changed 3 years ago by Karl Egly

Owner: changed from stuartm to Jonatan Lindblad
Status: newassigned

This patch set / ticket was last worked on by natanojl in the mythui/settings branch, see https://github.com/MythTV/mythtv/tree/devel/mythui/settings

comment:18 Changed 3 years ago by paulh

Milestone: 0.280.29

comment:19 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.2929.0

Milestone renamed

comment:20 Changed 22 months ago by Karl Egly

Keywords: settings rewrite added
Type: Patch - FeatureDeveloper Task

comment:21 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 75e6dd089a810cabc620ae76d74c3692ce027a23/mythtv:

Settings: Port the recording & transcoder profiles to MythUI

Refs #10092

comment:22 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 2052b1126165057c7a73691397ef9793f872a8d1/mythtv:

Settings: Start converting capture card settings to MythUI

Refs #10092

comment:23 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 4b2ca8c67a0d98af4c661e3320ab32c6955578f9/mythtv:

Settings: Convert the DiSEqC settings to MythUI

Refs #10092

comment:24 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 6375cd4fe2bc91eadcdd32877b63478a5bf0d154/mythtv:

Settings: Port the channel scanner to MythUI

Refs #10092

comment:25 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 5f6f1c1d8324bee6bc5d98f78a5e3a779dea0eb1/mythtv:

Settings: Port the channel editor to MythUI

Refs #10092

comment:26 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 444c40acf401d9cddf1f6470ce56e8d23f22d1c6/mythtv:

Settings: Rename the playback group class to minimize translation impact

Refs #10092

comment:27 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 8a712a6b4e97491076a29b43ba1b963980ffe377/mythtv:

Settings: Remove settings.h from standardsettings.h

Refs #10092

comment:28 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 59e3e7bc80db004944c369860ff5a9966dc22217/mythtv:

Settings: Remove inheritance to TriggeredConfigurationGroup? for some classes

Refs #10092

comment:29 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In c86d1fe2189372ac5245b3140c58cf80fd54f329/mythtv:

Settings: Only emit valueChanged if the value was actually changed

Refs #10092

comment:30 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 7a283ceded4be611a001a252c4d9f1d274b31f37/mythtv:

Settings: Remove unneeded call to MythUISpinBox::AddSelection?

Refs #10092

comment:31 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 74942259c8af4a68bfa92d0b1c82c8b4af8e98cb/mythtv:

Settings: Remove a no longer relevant comment

Refs #10092

comment:32 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 7501ec4a3aefb511d50400b7d6a4faed87912723/mythtv:

Settings: Avoid marking the screen refresh rate as changed

Refs #10092

comment:33 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In 15776b17277d9c125fb2945eeea220fbce5de0fa/mythtv:

Settings: Allow individual video sources to be deleted through the menu

Refs #10092

comment:34 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

comment:35 Changed 22 months ago by Jonatan Lindblad <jlindblad@…>

In e3f957fd5b2439f4fc31ac285bf79d6a6125a64d/mythtv:

Settings: Avoid marking the audio device as changed

Refs #10092

comment:36 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In eaa5316238cad266750db04d2ae80d37ca674b6a/mythtv:

Settings: Port the transport editor to MythUI

Refs #10092

comment:37 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In e6731080f13cf2eec307673abdc2067bb004f131/mythtv:

Settings: Port the creation of input groups to MythUI

Refs #10092

comment:38 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In 400f4a26f7843b1e9a8244a8c80dfe3e6ce097d2/mythtv:

Settings: Add support for deleting playback groups

Support for using the menu remains to be implemented.

Refs #10092

comment:39 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In da28762430ee08b1170b99370ef37119002326ed/mythtv:

Settings: Move the new playback group editor to libmythtv

Refs #10092

comment:40 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In 1728e4ff17a0b10425ebd6d1b1ed4f09ff11f912/mythtv:

Settings: Fix some settings being incorrectly marked as changed

Refs #10092

comment:41 Changed 19 months ago by Jonatan Lindblad <jlindblad@…>

In 3af397f455729aeccb4dfb3f46a9d878fb5fecb4/mythtv:

Settings: Remove TODO comment

Refs #10092

comment:42 Changed 19 months ago by Peter Bennett

Cc: Peter Bennett added

comment:43 Changed 13 months ago by Stuart Auchterlonie

Milestone: 29.029.1

comment:44 Changed 11 months ago by Peter Bennett

Milestone: 29.129.0
Resolution: Fixed
Status: assignedclosed

All backend and frontend setup screens have now been converted to the new setup in V29. Thank you to Jonatan Lindblad and Xavier Hervey.

comment:45 Changed 11 months ago by Stuart Auchterlonie

Milestone: 29.029.1

comment:46 in reply to:  44 Changed 11 months ago by Jonatan Lindblad

Milestone: 29.130.0
Resolution: Fixed
Status: closednew

Replying to pbennett:

All backend and frontend setup screens have now been converted to the new setup in V29. Thank you to Jonatan Lindblad and Xavier Hervey.

I'm sorry but that's not entirely correct. The Images, mythwelcome, and some MythGame? settings have not yet been ported to MythUI. I have started with the first two but not yet finished them.

Then there are all the database upgrade screens, and the usage of MythProgressDialog? in MythMusic.

Note: See TracTickets for help on using tickets.