Opened 14 years ago

Closed 14 years ago

#1010 closed enhancement (fixed)

reorg of mythmusic LCD info

Reported by: leo@… Owned by: paulh
Priority: minor Milestone: 0.20
Component: mythmusic Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I have a 4x40 LCD and still the artist-track info won't fit on a single line on quite a few occaissions. This inspired me to go looking for display space. I combined the InfoWidget? and the ProgressBar? on a single line. Worst case, the InfoWidget? contains something like "S:? R:1 ". As you see I condensed the info a bit. Also, speaking for myself, I don't have must use for shuffle with repeat anyway ;-) The attached patch gives the following LCD info (dependent on the number of lines) For 2-line displays:

<ArtistAlbumTitle?> <Elapse/Remaining? Time>

For 3-line displays:

<ArtistAlbumTitle?> <Elapse/Remaining? Time> <Info+ProgressBar?>

For displays with more than 3 lines:

<ArtistAlbum?> <Title> <Elapse/Remaining? Time> <Info+ProgressBar?>

I also added some code to clear the widgets before displaying them. This prevents that at the start of a song you are presented with the info of the previous song.

Attachments (2)

mythlcdserver.diff (4.3 KB) - added by leo@… 14 years ago.
scrollwidgets.diff (17.9 KB) - added by leo@… 14 years ago.

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by leo@…

Attachment: mythlcdserver.diff added

comment:1 Changed 14 years ago by leo@…

Sigh, reformat the example part of the comment...

For 2-line displays:
       <ArtistAlbumTitle> 
       <Elapse/Remaining Time> 
For 3-line displays:
       <ArtistAlbumTitle> 
       <Elapse/Remaining Time>
       <Info+ProgressBar> 
For displays with more than 3 lines:
       <ArtistAlbum>
       <Title>
       <Elapse/Remaining Time>
       <Info+ProgressBar>

comment:2 Changed 14 years ago by Isaac Richards

Owner: changed from Isaac Richards to paulh

comment:3 Changed 14 years ago by anonymous

Looks good and i like it, but at least the second line in my 4x20 LCD doesn't scroll anymore with this Patch.

If the Title of an song is longer than 20 I cannot read the whole Title.

comment:4 Changed 14 years ago by leo@…

I think I found out why scrolling no longer works, I should have used assignScrollingList() instead of assignScrollingText(). I will see if I can update the patch tonight.

Glad you like it though ;-)

comment:5 Changed 14 years ago by leo@…

OK, assignScrollingList() will not do the job either. It seems that there is no provision for scrolling multiple widgets on a screen - except for the special menu-screens. I will see if I can rewrite the scrollingText stuff to scroll on multiple widgets. This is quite a bit more work though.... To be continued ;-)

Changed 14 years ago by leo@…

Attachment: scrollwidgets.diff added

comment:6 Changed 14 years ago by leo@…

Here is an updated patch. This patch contains both the reformat changes for the LCD music screen and code to scroll multiple widgets on the same screen. I replaced the assignScrollingText/scrollText/beginScrollingText function by a new combo: assignScrollingWidgets/formatScrollingWidgets/beginScrollingWidgets/scrollWidgets.

comment:7 Changed 14 years ago by paulh

Milestone: 0.20
Status: newassigned

I'll take a look at this after 0.19 is out.

comment:8 Changed 14 years ago by anonymous

scrollwidgest breakes my mythmusic.

comment:9 Changed 14 years ago by leo@…

It works here for svn#9062. Since you didn't specify what went wrong, I assume running 'make clean; make' in both the mythtv and the mythplugins tree will fix the problem.

comment:10 Changed 14 years ago by paulh

Resolution: fixed
Status: assignedclosed

(In [9150]) Close #1010 - Apply patch to reorganise mythmusic LCD info.

Changes the API in libmyth so bumping the binary version. Requires a make clean of the pluggins at least.

Note: See TracTickets for help on using tickets.