Opened 12 years ago
Closed 11 years ago
Last modified 11 years ago
#10146 closed Bug Report - General (fixed)
Cannot edit recording metadata
Reported by: | Owned by: | paulh | |
---|---|---|---|
Priority: | minor | Milestone: | 0.27 |
Component: | MythTV - User Interface Library | Version: | Master Head |
Severity: | medium | Keywords: | recording metadata |
Cc: | Ticket locked: | no |
Description
Hi,
Selecting "change metadata" for a recording does nothing. The following message is issued:
E PlaybackBox?: Window 'editmetadata' is missing required elements
Regards, Antonio
Change History (10)
comment:1 Changed 12 years ago by
Status: | new → infoneeded_new |
---|
comment:2 Changed 12 years ago by
Mythbuntu wide as it comes from the PPA repositories. Theme Selector reports 25.1 version. No newer version is available it seems.
comment:3 Changed 12 years ago by
in fact it looks like some themes are broken since changeset:c704430299e176e3372dfc09dad3b0d0dcc1065d
I tried to fix that in Terra:
diff --git a/mythtv/themes/Terra/recordings-ui.xml b/mythtv/themes/Terra/recordings-ui.xml index e65339a..0ae3834 100644 --- a/mythtv/themes/Terra/recordings-ui.xml +++ b/mythtv/themes/Terra/recordings-ui.xml @@ -254,18 +254,6 @@ </state> </statetype> -<!-- - <textarea name="filesize_str" from="basetextarea"> - <area>360,647,200,30</area> - <align>right</align> - </textarea> - - <textarea name="freereport" from="basetextarea"> - <area>570,647,300,30</area> - <align>left</align> - </textarea> ---> - <statetype name="ratingstate" from="baserating"> <position>1193,435</position> </statetype> @@ -622,12 +610,12 @@ <shape name="fade" from="basefadebackground" /> <imagetype name="backimg"> - <position>877,78</position> + <area>650,78,635,515</area> <filename>popups/alt_menu_background.png</filename> </imagetype> <textarea name="label" from="basetextarea"> - <area>889,93,378,125</area> + <area>662,93,615,125</area> <font>basemedium</font> <align>allcenter</align> <value>Edit Recording Metadata</value> @@ -635,36 +623,67 @@ </textarea> <textarea name="titlelabel" from="basetextarea"> - <area>889,225,378,30</area> + <area>680,230,615,30</area> <value>Title</value> - <align>hcenter</align> + <align>left</align> <font>basemedium</font> </textarea> - <textedit name="title" from="baseshorttextedit"> - <position>919,250</position> + <textedit name="title" from="basetextedit"> + <position>825,230</position> </textedit> - <textarea name="subtitlelabel" from="titlelabel"> - <position>889,305</position> + <textarea name="subtitlelabel" from="basetextarea"> + <area>680,280,565,30</area> <value>Subtitle</value> + <align>left</align> + <font>basemedium</font> </textarea> - <textedit name="subtitle" from="baseshorttextedit"> - <position>919,330</position> + <textedit name="subtitle" from="basetextedit"> + <position>825,280</position> </textedit> - <textarea name="descriptionlabel" from="titlelabel"> - <position>889,385</position> + <textarea name="descriptionlabel" from="basetextarea"> + <area>680,330,565,30</area> <value>Description</value> + <align>left</align> + <font>basemedium</font> </textarea> - <textedit name="description" from="baseshortmultilinetextedit"> - <position>919,415</position> + + <textedit name="description" from="basetextedit"> + <area>825,330,437,90</area> + </textedit> + + <textarea name="inetreflabel" from="basetextarea"> + <area>680,425,565,30</area> + <align>left</align> + <value>Inetref</value> + <font>basemedium</font> + </textarea> + + <textedit name="inetref" from="basetextedit"> + <position>825,425</position> </textedit> + <textarea name="seaslabel" from="basetextarea"> + <area>680,475,565,30</area> + <align>left</align> + <value>Season/Epsiode</value> + <font>basemedium</font> + </textarea> + + <spinbox name="season" from="basespinbox"> + <position>897,475</position> + </spinbox> + + <spinbox name="episode" from="basespinbox"> + <position>1077,475</position> + </spinbox> + <button name="ok" from="basebutton"> - <position>968,515</position> + <position>853,520</position> <value>OK</value> </button> </window>
But there is still a problem: the text doesn´t wrap properly in multiline, and also in the title only the end is shown - I think almost everyone would prefer the beginning.
On the other hand I think it would be useful if we could get more information what exactly is missing:
diff --git a/mythtv/programs/mythfrontend/playbackbox.cpp b/mythtv/programs/mythfrontend/playbackbox.cpp index dc76ecf..66962e9 100644 --- a/mythtv/programs/mythfrontend/playbackbox.cpp +++ b/mythtv/programs/mythfrontend/playbackbox.cpp @@ -5072,6 +5072,8 @@ RecMetadataEdit::RecMetadataEdit(MythScreenStack *lparent, ProgramInfo *pginfo) bool RecMetadataEdit::Create() { + int rv=0; + if (!LoadWindowFromXML("recordings-ui.xml", "editmetadata", this)) return false; @@ -5083,13 +5085,45 @@ bool RecMetadataEdit::Create() m_episodeSpin = dynamic_cast<MythUISpinBox*>(GetChild("episode")); MythUIButton *okButton = dynamic_cast<MythUIButton*>(GetChild("ok")); - if (!m_titleEdit || !m_subtitleEdit || !m_inetrefEdit || !m_seasonSpin || - !m_episodeSpin || !okButton) + if (!m_titleEdit) { LOG(VB_GENERAL, LOG_ERR, LOC + - "Window 'editmetadata' is missing required elements."); - return false; + "Window 'editmetadata' is missing 'title' element."); + rv=1; + } + if (!m_subtitleEdit) + { + LOG(VB_GENERAL, LOG_ERR, LOC + + "Window 'editmetadata' is missing 'subtitle' element."); + rv=1; } + if (!m_inetrefEdit) + { + LOG(VB_GENERAL, LOG_ERR, LOC + + "Window 'editmetadata' is missing 'inetref' element."); + rv=1; + } + if (!m_seasonSpin) + { + LOG(VB_GENERAL, LOG_ERR, LOC + + "Window 'editmetadata' is missing 'season' element."); + rv=1; + } + if (!m_episodeSpin) + { + LOG(VB_GENERAL, LOG_ERR, LOC + + "Window 'editmetadata' is missing 'epsisode' element."); + rv=1; + } + if (!okButton) + { + LOG(VB_GENERAL, LOG_ERR, LOC + + "Window 'editmetadata' is missing 'ok' element."); + rv=1; + } + + if (rv == 1 ) + return false; m_titleEdit->SetText(m_progInfo->GetTitle()); m_titleEdit->SetMaxLength(128);
comment:4 Changed 12 years ago by
Milestone: | unknown → 0.25 |
---|---|
Status: | infoneeded_new → new |
comment:5 Changed 12 years ago by
Status: | new → accepted |
---|
comment:6 Changed 12 years ago by
Milestone: | 0.25 → 0.25.1 |
---|
comment:7 Changed 12 years ago by
Milestone: | 0.25.1 → 0.26 |
---|
comment:8 Changed 11 years ago by
Milestone: | 0.26 → 0.26.1 |
---|
comment:9 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:10 Changed 11 years ago by
Milestone: | 0.26.1 → 0.27 |
---|---|
Owner: | changed from stuartm to paulh |
Your theme is not up to date. Which one are you using?