Opened 9 years ago

Closed 9 years ago

#10275 closed Patch - Bug Fix (fixed)

Fix mythcommflag final commercial break

Reported by: Jim Stichnoth <stichnot@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.25
Component: MythTV - Mythcommflag Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


When a recording ends with a commercial break, mythcommflag may artificially end the break 2 seconds before the end of the recording. This makes it inconvenient when copying the skiplist to the cutlist, such as when editing the recording.

This patch puts a more or less correct skiplist into the database. The resulting skiplist seems to give reasonable behavior for manual commskip, automatic commskip, and loading the skiplist in the program editor.

Attachments (1)

commflag_final_skip_region.patch (832 bytes) - added by Jim Stichnoth <stichnot@…> 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Jim Stichnoth <stichnot@…>

comment:1 Changed 9 years ago by Jim Stichnoth

Owner: changed from cpinkham to Jim Stichnoth
Status: newassigned

comment:2 Changed 9 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: assignedclosed

Commflag: Avoid adding an artificial non-break region at the end.

If the recording is deemed to end with a final break region, extend the final break slightly, to avoid a spurious 2-second non-break region at the very end.

Fixes #10275

Branch: master Changeset: 31351766db1439e78b2d0022aa65b00b825c69a8

Note: See TracTickets for help on using tickets.