Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10291 closed Patch - Feature (fixed)

CEA-708 caption color improvements

Reported by: Jim Stichnoth <stichnot@…> Owned by:
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch makes a few improvements to CEA-708 caption colors.

  1. Enable colors even when the "CCBackground" setting is true.
  1. Change the CCBackground help text to remove the clause "as white text".
  1. Improve the translation from 6-bit CEA-708 color values to 24-bit QColor values. U.S. ATSC programs appear to use only the higher-order of the 2 bits for each RGB component, so map binary values 10 and 11 to the maximum 255 value.

Attachments (1)

cc708_colorfix.patch (4.8 KB) - added by Jim Stichnoth <stichnot@…> 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Jim Stichnoth <stichnot@…>

Attachment: cc708_colorfix.patch added

comment:1 Changed 8 years ago by danielk

Jim, what happens if the text is dark/black on what was originally a light background?

comment:2 Changed 8 years ago by Jim Stichnoth <stichnot@…>

In all cases I see in my frontend logs, the closed caption provider explicitly sets a black background, via SetPenColor? with bg_color=bg_opacity=0, or via DefineWindow? with pen_style=1 or pen_style=4 (both of which imply bg_color=bg_opacity=0). So I would say that scenario is very unlikely, and will affect practically all closed caption users, not just MythTV users.

I would be just as happy if CEA-708 ignored the CCBackground setting and used the caption provider's values. Especially with the rumor that in the future there will be a separate config to override colors, fonts, sizes, etc.

comment:3 Changed 8 years ago by Github

Milestone: unknown0.26
Resolution: fixed
Status: newclosed

Fixes #10291. Replace white-on-black force option with X-on-black.

The thought here is that people want to force a black backround on captions for readability but don't want to force the text to be black since there may be semantic content in the color used. Red for emphasis, for example.

Branch: master Changeset: 21fede584b08265c8884dec3b6be995bdbcdc74f

comment:4 Changed 8 years ago by Raymond Wagner

Milestone: 0.260.25
Note: See TracTickets for help on using tickets.