Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10329 closed Patch - Bug Fix (Fixed)

Fix DeleteMap tracker for in-progress recording

Reported by: Jim Stichnoth <stichnot@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.25
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


If you enter the program editor and create a cutlist for an in-progress recording, playback will exit prematurely at the last frame that existed when the cutlist was created. This is because DeleteMap::GetNearestMark?() uses MythPlayer::totalFrames to represent the case where there are no further cut regions in the recording. This isn't a good representation when the recording is growing.

The attached patch modified GetNearestMark?() to return an extra status value signifying whether an actual mark is being returned, versus a min/max placeholder, and uses the status in TrackerWantsToJump?().

(I think this was first reported on #mythtv, but I can't find a reference.)

Attachments (1)

deletemap_tracker_fix.patch (4.0 KB) - added by Jim Stichnoth <stichnot@…> 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Jim Stichnoth <stichnot@…>

Attachment: deletemap_tracker_fix.patch added

comment:1 Changed 9 years ago by Jim Stichnoth

Component: MythTV - GeneralMythTV - Video Playback
Milestone: unknown0.25
Owner: set to Jim Stichnoth
Status: newaccepted

comment:2 Changed 9 years ago by Jim Stichnoth

Resolution: Fixed
Status: acceptedclosed

comment:3 Changed 9 years ago by Github

Cutlist editor: Adjust "Cut to End" behavior for an in-progress recording.

When adding a "Cut to End" region to a recording that is currently in progress, only cut to the current end of the program, rather than to the ultimate end of the program. Refs #10329.

Branch: master Changeset: 1ce3d21e3a763011f4214c659d0ed4b822121dd6

comment:4 Changed 9 years ago by Github

Cutlist editor: Update the edit bar for in-progress recordings.

When editing an in-progress recording, the edit bar only updates when the cutlist is modified, but not when the recording length changes. However, the position indicator does get updated, resulting in the edit bar graphics getting out of sync.

This is fixed by disabling the (seemingly premature) optimization that updates the edit bar only when the cutlist changes. This fix will need to be reevaluated after the 0.25 release.

Refs #10329

Branch: master Changeset: 5d7c01d089469be950d62f06de32f4c5fc948ee0

comment:5 Changed 9 years ago by Github

Fix minor problems editing in-progress recordings.

Revert 5d7c01d08, and add logic that also updates the edit bar when the total number of frames in the recording changes.

Modify 1ce3d21e3 to use a better test for an in-progress recording. If the recording finishes during the editing session, the original test would continue to indicate that the recording was in-progress.

Binary version is updated. Refs #10329.

Branch: master Changeset: f77d001e945387ecb00fd88c53b45bb74ae0f396

comment:6 Changed 9 years ago by Github

DeleteMap? tracker: Fix an error in 94d27c67f.

For recordings with a final cut region, DeleteMap::GetNearestMark?() was in some situations reporting the final mark as "fake", causing the DeleteMap? tracker to ignore it and continue playing in the final cut region.

Refs #10329.

Branch: master Changeset: 30ed8f0a20e7a10272b5997d970957a0ed7ec970

Note: See TracTickets for help on using tickets.