Opened 8 years ago

Closed 8 years ago

#10366 closed Patch - Bug Fix (fixed)

libcec configuration detection code mismatched with source code

Reported by: mythtv@… Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - configure script Version: Unspecified
Severity: medium Keywords: libcec
Cc: Ticket locked: no

Description

The detection code contained within the mythtv/configure script is mismatched to the implementation code contained within mythtv/libs/libmythui/cecadapter.cpp.

The mythtv/configure script checks for header files within a libcec subdirectory:

#include <libcec/cec.h>

yet mythtv/libs/libmythui/cecadapter.cpp contains:

#include “cec.h”

the mythtv/configure script also checks for the deprecated LoadLibCec() function, which has been removed from libcec version 1.5 whereas mythtv/libs/libmythui/cecadapter.cpp has already been switched to use the new LibCecInit() function.

The attached patch homogenises all of the include paths, settling on the:

#include <libcec/cec.h>

format. Whilst I consider this approach to be the best one it is worth noting that it requires correct #include statements within the libcec headers, which were only introduced in version 1.5, and therefore the minimum required version has been increased accordingly.

The patch also removes the unnecessary cecc.h C API header from mythtv/libs/libmythui/cecadapter.cpp as being a C++ source file the cec.h C++ API is the correct and only required header.

Attachments (1)

libcec_configure_f76910875f.patch (1.9 KB) - added by mythtv@… 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by mythtv@…

comment:1 Changed 8 years ago by beirdo

Component: MythTV - User Interface LibraryMythTV - configure script
Owner: changed from stuartm to beirdo

comment:2 Changed 8 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: newclosed

Fix libcec configure to work with v1.5

The detection code contained within the mythtv/configure script is mismatched to the implementation code contained within libs/libmythui/cecadapter.cpp.

The configure script also checks for the deprecated LoadLibCec?() function, which has been removed from libcec version 1.5 whereas libs/libmythui/cecadapter.cpp has already been switched to use the new LibCecInit?() function.

Increases the minimum version of libcec to 1.5.

Fixes #10366

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

Branch: master Changeset: 20d6852d905476a0cae3587db04e13a2a33bddbf

Note: See TracTickets for help on using tickets.