Opened 12 years ago
Closed 12 years ago
Last modified 12 years ago
#10383 closed Bug Report - General (fixed)
Metadata Options doesn't always fill out TVDB number
Reported by: | Kenni Lund [kenni a kelu dot dk] | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 0.25.1 |
Component: | MythTV - Mythmetadatalookup | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The Metadata Options for a recording rule doesn't populate the TMDB/TVDB number when multiple results from thetvdb are found and one of these are selected, while Season/Episode? is set to 0/0.
Tested on master from today (v0.25pre-4682-gc2a0b85) with Arclight.
An illustrated example:
There's a recording rule for "X-Files" and we click on "Metadata Options":
http://postimage.org/image/4gnwjxg8z/
MythTV performs a search and comes up with four results, all from thetvdb.com:
http://postimage.org/image/rlj5el2fh/
The first one is the right one, so we select it. The results are now briefly removed from the screen (for about 2 seconds) while the screen from behind the results is shown:
http://postimage.org/image/tsyezhi83/
The TMDB/TVDB # field does NOT get populated now, instead the results are shown again:
http://postimage.org/image/rlj5el2fh/
Selecting the same item again, results in the same loop. This behavior continues infinitely.
If you instead exit out of the presented results and set Season/Episode? to 1/1 followed by a click on "Perform Query", the same 4 results will show up - but this time the TVDB number WILL get populated correctly when the first item is selected:
http://postimage.org/image/h0jyaf2bn/
Attachments (2)
Change History (10)
comment:1 Changed 12 years ago by
Changed 12 years ago by
Attachment: | 10383.patch added |
---|
comment:2 Changed 12 years ago by
This patch will beak the metadata classes in a number of their other uses. I think there is a less intrusive way to solve this which I will try to look at before the release.
comment:3 Changed 12 years ago by
Owner: | robertm deleted |
---|---|
Status: | new → assigned |
comment:4 Changed 12 years ago by
Status: | assigned → new |
---|
comment:5 Changed 12 years ago by
This time I didn't change the metadata classes but changed the MetadataOptions? so that they just use the selected query results instead of doing another lookup. Worked for me ... hope it did not break anything else ...
Changed 12 years ago by
Attachment: | 10383_2.patch added |
---|
comment:7 Changed 12 years ago by
Owner: | set to Michael T. Dean <mdean@…> |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:8 Changed 12 years ago by
Milestone: | unknown → 0.25.1 |
---|
The MetadataFactory? is guessing wether you looking for a recording or a movie by checking for Subtitle and Season/Episode?. If you have no Season/Episode? set and no Subtitle from EIT it assumes its a movie. The lookup type is not updated based on the grapper you get your result from ... this behaviour is fixed with the attached patch.