Opened 9 years ago

Closed 9 years ago

#10420 closed Patch - Bug Fix (fixed)

Invalid data type in VideoLookup XSD

Reported by: Gregory Moyer <moyerg@…> Owned by: dblain
Priority: minor Milestone: 0.25
Component: Bindings - XML/JSON Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In the XSD generated for the VideoLookup? data contract (used in the video service), there is a type of "xs:stringlist" for the "Countries" property that is not a valid W3C data type. It looks like QStringList is handled properly in wsdl.cpp, but there is an issue in xsd.cpp (which is why the WSDLs do not have this problem). The only data contract I found using QStringList was VideoLookup?.

The attached patch handles QStringList by turning it into ArrayOfString? (as is done for the WSDLs currently). The reason the patch sets "sType" is because the line "typesToInclude.insert( sType, sContentType );" comes before the call to ConvertTypeToXSD. You may wish to rearrange things slightly by just overriding "sType" with ConvertTypeToXSD since it will turn "QStringList" into "ArrayOfString?" if "bCustomType" is set (which it is now with this patch). My aim here was to be as minimally invasive as possible.

Attachments (2)

xsd-fix-qstringlist.patch​ (539 bytes) - added by Gregory Moyer <moyerg@…> 9 years ago.
mythbackend.version.log​ (859 bytes) - added by Gregory Moyer <moyerg@…> 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Gregory Moyer <moyerg@…>

Attachment: xsd-fix-qstringlist.patch​ added

Changed 9 years ago by Gregory Moyer <moyerg@…>

Attachment: mythbackend.version.log​ added

comment:1 Changed 9 years ago by dblain

Milestone: unknown → 0.25
Status: new → accepted

comment:2 Changed 9 years ago by Github

Resolution: → fixed
Status: accepted → closed

Fixes #10420 - Invalid data type in VideoLookup? XSD

Signed-off-by: David Blain <dblain@…>

Branch: master Changeset: 15786787e28fee503438ebb7fc6dc812eff04049

Note: See TracTickets for help on using tickets.