Opened 8 years ago

Closed 8 years ago

#10476 closed Patch - Bug Fix (fixed)

Silence uint warning (comparison < 0) in mythudplistener.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Silence a (pedantic) warning about testing the timeout uint for less than zero in mythtv/libs/libmythui/mythudplistener.cpp (detected by clang).

timeout is declared a uint. The string conversion is via toUInt(). The value cannot be negative, and the test is considered redundant by clang.

Patch attached to remove the (redundant) test.

Attachments (1)

mythudplistener_cpp.diff (570 bytes) - added by Gary Buhrmaster <gary.buhrmaster@…> 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Attachment: mythudplistener_cpp.diff added

comment:1 Changed 8 years ago by stuartm

Milestone: unknown0.25
Owner: set to stuartm
Status: newaccepted
Version: UnspecifiedMaster Head

comment:2 Changed 8 years ago by Github

Resolution: fixed
Status: acceptedclosed

Silence warning about testing a uint for less than zero (detected by clang). Closes #10476

Signed-off-by: Stuart Morgan <smorgan@…>

Branch: master Changeset: fb448d6df7aca75f145379a3945a683780006b0f

Note: See TracTickets for help on using tickets.