Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#10524 closed Patch - Feature (fixed)

g++ C++ standards compliance patch

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.26
Component: MythTV - Video Playback Version: Unspecified
Severity: low Keywords:
Cc: Ticket locked: no

Description

(Part 2 of 2, since the patches are in different components)

Feature patch for g++ C++0x/C++11 standards compliance

When compiling with g++ and specifing -std=c++0x the compilation fails in mythplayer.cpp due to a namespace collision for isnan (std:: and math::).

Patch attached which changes mythplayer to use the Qt function qIsNaN, providing a platform neutral implementation now that Qt has made that function available (in Qt 4.6).

Since MythTV does not currently specify use of the new C++ standards, this patch is not necessary at this time, but may useful be at some future date (when gcc defaults to the C++11 standards?)

Attachments (1)

c++standard_2.patch (1.1 KB) - added by Gary Buhrmaster <gary.buhrmaster@…> 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by Gary Buhrmaster <gary.buhrmaster@…>

comment:1 Changed 22 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Owner set to Gary Buhrmaster <gary.buhrmaster@…>
  • Resolution set to fixed
  • Status changed from new to closed

In e4f3d088815b7f08650eec915da97acacf565d21/mythtv:

use qIsNaN in place of ::isnan

Feature patch for g++ C++0x/C++11 standards compliance

When compiling with g++ and specifing -std=c++0x the compilation fails in
mythplayer.cpp due to a namespace collision for isnan (std:: and math::).

Patch attached which changes mythplayer to use the Qt function qIsNaN,
providing a platform neutral implementation now that Qt has made that
function available (in Qt 4.6).

Since MythTV does not currently specify use of the new C++ standards, this
patch is not necessary at this time, but may useful be at some future date
(when gcc defaults to the C++11 standards?)

Fixes #10524

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

comment:2 Changed 22 months ago by beirdo

  • Milestone changed from unknown to 0.26

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.