Opened 18 years ago
Closed 18 years ago
Last modified 18 years ago
#1053 closed patch (fixed)
Help text in for FreqID is incorrect (patch attached)
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
in mythtv/libmythtv/channelsettings.cpp, line 192, the freqid help states to use the exact frequency in Hz. However, the value is actually in kHz. This will confuse people.
Patch is attached to fix it.
Attachments (2)
Change History (6)
Changed 18 years ago by
| Attachment: | kHz-text.patch added |
|---|
comment:1 Changed 18 years ago by
OK, on second glance, the same issue is in the Finetune right after it. Updated the patch.
Changed 18 years ago by
| Attachment: | kHz-text.2.patch added |
|---|
patch to fix the text mentioned (revised)
comment:2 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 18 years ago by
In this case an MPEG-4 recording is using a frame height which is not a multiple of 16. ffmpeg isn't doing any validation on the dimensions so it ends up writing outside the buffer. This just pads allocated buffers up to multiples of 16, so that this type of error doesn't cause a segfault with any of the codecs we support. MythTV does prevent you from setting an invalid dimension when you record to a MPEG-4 NUV, so AFAIK this is more of a legacy issue.
patch to fix the text mentioned.