Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

#10536 closed Bug Report - General (Fixed)

Correct saving of the DTSHDPassThru state

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: jyavenard
Priority: minor Milestone: unknown
Component: MythTV - Audio Output Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In setupwizard_audio.cpp gcc produces the warning: setupwizard_audio.cpp:237:9: warning: variable ‘dtshdState’ set but not used [-W
unused-but-set-variable]

While many of these are set but not used messages are essentially uninteresting, in this case the variable appears to have been intended to be used in the next line to save the state, and instead a different variable was used in the saving of the setting.

From a cursory examination, it appears that during the copy/paste/edit of the code fragments, this particular edit was overlooked.

Patch attached.

Attachments (1)

setupwizard_audio_cpp.patch (869 bytes) - added by Gary Buhrmaster <gary.buhrmaster@…> 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by Gary Buhrmaster <gary.buhrmaster@…>

comment:1 Changed 2 years ago by jyavenard

I'm very keen on completely dropping the audio part of the "wizard"

it just doesn't work like it should, it adds nothing over the existing audio setup ; quite the opposite

comment:2 Changed 2 years ago by robertm

  • Resolution set to Fixed
  • Status changed from new to closed

fixed in 711386d

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.