Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

#10537 closed Patch - Bug Fix (fixed)

Myth 0.25-rc gcc 4.7 patch

Reported by: mythtv@… Owned by: beirdo
Priority: minor Milestone: 0.24.3
Component: MythTV - General Version: Master Head
Severity: low Keywords: gcc 4.7
Cc: Ticket locked: no

Description

Myth core code will not compile with gcc 4.7 without explicitly including a few system header files. The included ffmpeg also requires changes to compile. Patch for mythtv and mythplugins included.

Attachments (2)

mythtv_0.25_gcc_4.7.patch (3.8 KB) - added by mythtv@… 2 years ago.
mythplugins_0.25_gcc_4.7.patch (423 bytes) - added by mythtv@… 2 years ago.

Download all attachments as: .zip

Change History (13)

Changed 2 years ago by mythtv@…

Changed 2 years ago by mythtv@…

comment:1 Changed 2 years ago by beirdo

  • Milestone changed from 0.25 to unknown
  • Owner set to beirdo
  • Status changed from new to assigned

Please don't set the milestone for tickets.

comment:2 Changed 2 years ago by beirdo

I'll look at this shortly, but I think we'll put this in after release.

comment:3 Changed 2 years ago by kenni

See also #10309.

comment:4 Changed 2 years ago by hobbes1069@…

unistd.h may be the way to go but I know on another project I suggested a similar fix but someone who developed on windows said "sys/types.h" was more portable. YMMV.

comment:5 Changed 2 years ago by beirdo

  • Milestone changed from unknown to 0.26
  • Resolution set to Fixed
  • Status changed from assigned to closed

Committed in 19a7e0131146d38bfe384da55fc4c16193f2b54e to master, all except the ffmpeg part.

comment:6 Changed 2 years ago by Kevon <mythtv@…>

In ed67f148adbe5b3122643ccfebca625e9b5ea12f/mythtv:

Make mythtv more compatible with GCC 4.7

Fixes #10537

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

Cherry-picked from 19a7e0131146d38bfe384da55fc4c16193f2b54e

comment:7 Changed 2 years ago by beirdo

  • Milestone changed from 0.26 to 0.24.3

comment:8 Changed 2 years ago by Kevon <mythtv@…>

In 773c88c3ac2c2eac4e6dbb6af0ce949df6d4ab27/mythtv:

Make mythtv more compatible with GCC 4.7

Fixes #10537

Signed-off-by: Gavin Hurlbut <ghurlbut@…>
(cherry picked from commit 19a7e0131146d38bfe384da55fc4c16193f2b54e)

comment:9 Changed 2 years ago by beirdo

  • Resolution Fixed deleted
  • Status changed from closed to new

The ffmpeg portions will be looked at shortly.

comment:10 Changed 2 years ago by superm1@…

Glancing through ffmpeg's git, this is probably the commit that will fix the failed build with gcc-4.7:

http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=da4c7cce2100a4e4f9276b4f17e260be47b53f41

comment:11 Changed 2 years ago by Kevon <mythtv@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 9ccfac11f31d8d05d48092efcbec8015c68f6cc1/mythtv:

Make ffmpeg compile with gcc 4.7

Fixes #10537

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.