Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#1054 closed defect (fixed)

Programs filled in from EIT show up as previously recorded

Reported by: greg Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

All programs filled in from EIT data are showing up in the programs listing as having been previously recorded. AS you mentioned this likely has to do with the lack of a series or programid.

Attachments (5)

mythweb.oldrecorded.diff (1.1 KB) - added by Robert Tsai <rtsai1111> 14 years ago.
mythweb.oldrecorded.2.diff (3.6 KB) - added by Robert Tsai <rtsai1111> 14 years ago.
change tabs to spaces
mythweb.oldrecorded.3.diff (1.2 KB) - added by Robert Tsai <rtsai1111> 14 years ago.
sorry, included too much in the diff
mythweb.oldrecorded.4.diff (1.2 KB) - added by Robert Tsai <rtsai1111> 14 years ago.
mythweb.oldrecorded.5.diff (846 bytes) - added by Robert Tsai <rtsai1111> 14 years ago.
need to keep channel.channum

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by xris

Resolution: fixed
Status: newclosed

(In [8637]) hopefully fix #1054

comment:2 Changed 14 years ago by Robert Tsai <rtsai1111>

Resolution: fixed
Status: closedreopened
Version: head

This breaks #848; certain recordings that don't have a seriesid field (movies broadcast on TV, for example) are improperly not marked in the mythweb TV listings as being recorded. I've attached a patch to fix hopefully both the EIT and "oldrecorded" problems (I don't have EIT, so I can't check for the originally-reported problem).

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.diff added

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.2.diff added

change tabs to spaces

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.3.diff added

sorry, included too much in the diff

comment:3 Changed 14 years ago by xris

Resolution: fixed
Status: reopenedclosed

(In [8887]) Apply patch to close #1223 and #1054

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.4.diff added

comment:4 Changed 14 years ago by Robert Tsai <rtsai1111>

Resolution: fixed
Status: closedreopened

Can anyone experiencing this "EIT channels all appear in TV listings as previously recorded" problem try out this most recent patch (apply to [8911])? You might also need the patch in #1232 (you shouldn't, but I only mention it because I only have one tree with both patches in it).

Also, for these EIT channels, are they also being filled in by a listings grabber, then being filled in later by EIT? If so, I think this might be an intractable problem. I the oldrecorded record could have empty or non-empty programid/seriesid values depending on when it got recorded and whether or not the guide data was overwritten by EIT. This is then compared to the program record at the time the mythweb TV listings are loaded (e.g., whether or not the downloaded guide data have been also overwritten by EIT data).

Anyway, anyone who is interested, please give this a try and let me know how it goes, plus the channel guide data configuration (whether it gets its guide data from download and/or EIT).

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.5.diff added

need to keep channel.channum

comment:5 Changed 14 years ago by xris

Resolution: fixed
Status: reopenedclosed

(In [8914]) Apply patches, and some of my own cleanup to close #1232 and #1054

comment:6 Changed 14 years ago by xris

(In [8915]) Clean up the query to remove some calculations and hopefully make it a little faster, re #1054

Note: See TracTickets for help on using tickets.