Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10544 closed Patch - Bug Fix (Fixed)

[Patch] Fix typo in '--ostream' option for mythtranscode

Reported by: Joe Nyland <joe@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - Mythtranscode Version: Master Head
Severity: low Keywords: mythtranscode
Cc: Ticket locked: no

Description

Running 'mythtranscode --help' returns:

<snip>
-e OR --ostream Output stream type: dvd, ps
<snip>

Meaning that mythtranscode can create a DVD compatible MPEG2 file, or an MPEG2-PS program stream file.

However, issueing 'mythtranscode --ostream ps' on a file fails, saying that ps is not a valid format.

Inspecting the code mythtranscode/commandlineparser.cpp reveals that mythtranscode will only output to a DVD compatible file, or a MPEG TS transport stream file.

The attached patch addresses this typo in the 'mythtranscode --help' output.

* Whilst I have a good amount of experience with scripting I am not a developer, so there is a chance I have made a mistake. I have verified that the patch applies correctly to the source and that I can successfully build MythTV with the patch applied, so as far as I can make out I haven't broken anything. If I can improve this in anyway, please let me know.

I hope this helps.

Joe

Attachments (1)

mythtranscode.ostream.patch (567 bytes) - added by Joe Nyland <joe@…> 2 years ago.
mythtranscode Patch File

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by Joe Nyland <joe@…>

mythtranscode Patch File

comment:1 Changed 2 years ago by beirdo

  • Milestone set to 0.25
  • Owner set to beirdo
  • Status changed from new to assigned

comment:2 Changed 2 years ago by beirdo

  • Resolution set to Fixed
  • Status changed from assigned to closed

Committed in a2cf165545ed48e. Thanks.

comment:3 Changed 2 years ago by J.Pilk@…

I may be mistaken about this, since I haven't used the lossless mythtranscode for some time, but it was my impression that -ps was the default output and there were two other selectable possibilities; I believe the patch does correct a faulty identification of -ps as one of these.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.