Opened 14 years ago

Closed 14 years ago

#1056 closed enhancement (fixed)

Dishnet EIT Patch

Reported by: greg Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by greg)

This patch adds support for the dishnet EIT information as well as their 7-9day info using the existing Huffman routines.

I've been using this to get listings for a family member who has no net connection to pull listings from zap2it for a couple weeks now without any problems.

Attachments (6)

dishnet_eit_8612.patch (4.1 KB) - added by greg 14 years ago.
dishnet_descriptors_8612.patch (871 bytes) - added by greg 14 years ago.
This adds the descriptor names to Oops... Trac detected an internal error: database is locked Traceback (most recent call last): File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 206, in handler dispatch_request(mpr.path_info, mpr, env) File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 139, in dispatch_request dispatcher.dispatch(req) File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 79, in dispatch req.authname = self.authenticate(req) File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 66, in authenticate authname = authenticator.authenticate(req) File "/usr/lib/python2.3/site-packages/trac/web/auth.py", line 48, in authenticate authname = self._get_name_for_cookie(req, req.incookietrac_auth?) File "/usr/lib/python2.3/site-packages/trac/web/auth.py", line 155, in _get_name_for_cookie (cookie.value, req.remote_addr)) File "/usr/lib/python2.3/site-packages/sqlite/main.py", line 255, in execute self.rs = self.con.db.execute(SQL % parms) This adds the descriptor names to DescriptorTagString?
dn-eit-scan-fixup.diff (1.1 KB) - added by anonymous 14 years ago.
support for DN when not all NETWORK id's are sent
1056.patch (2.9 KB) - added by danielk 14 years ago.
mostly updated patch
myth_eit-bev-dn2_r8925.diff (19.6 KB) - added by Mark.Buechler@… 14 years ago.
Patch which enabled standard/extended guide.
dishnet_eit_9143.patch (10.4 KB) - added by greg 14 years ago.
New dishnet eit patch against 9143

Download all attachments as: .zip

Change History (19)

Changed 14 years ago by greg

Attachment: dishnet_eit_8612.patch added

comment:1 Changed 14 years ago by greg

Description: modified (diff)
Type: defectenhancement

comment:2 Changed 14 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to danielk
Version: head

Changed 14 years ago by greg

This adds the descriptor names to Oops...

Trac detected an internal error:

database is locked Traceback (most recent call last):

File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 206, in handler

dispatch_request(mpr.path_info, mpr, env)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 139, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 79, in dispatch

req.authname = self.authenticate(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 66, in authenticate

authname = authenticator.authenticate(req)

File "/usr/lib/python2.3/site-packages/trac/web/auth.py", line 48, in authenticate

authname = self._get_name_for_cookie(req, req.incookietrac_auth?)

File "/usr/lib/python2.3/site-packages/trac/web/auth.py", line 155, in _get_name_for_cookie

(cookie.value, req.remote_addr))

File "/usr/lib/python2.3/site-packages/sqlite/main.py", line 255, in execute

self.rs = self.con.db.execute(SQL % parms)

This adds the descriptor names to DescriptorTagString?

Changed 14 years ago by anonymous

Attachment: dn-eit-scan-fixup.diff added

support for DN when not all NETWORK id's are sent

comment:3 Changed 14 years ago by anonymous

something changed recently on Dish's network. It is no longer sending all of the NIT sections. Specifically, the 'section_last' is getting set to '3', but the only sections being sent are 0 and 2

This patch is just a hack, and needs to be reworked, but it just forces all sections to be available once it sees 10 repeats. That enables the EITparser to start up.

comment:4 Changed 14 years ago by danielk

(In [8957]) References #1056. Applies working part of patch for Dishnet EIT support.

Changed 14 years ago by danielk

Attachment: 1056.patch added

mostly updated patch

comment:5 Changed 14 years ago by danielk

greg, can you look at the updated patch I attached to this ticket?

There are three problems AFAICT:

  • Doesn't compile due to a check of a Event class variable which does not exist.
  • It unconditionally turns on PrivateTypes?.ForceGuidePresent?, which would cause lots of problems for everyone else.
  • It unconditionally turns on "Table[EVENTS]->AddPid?(0x300,0x00,0x00,true);", which will cause a problem for some people.

Changed 14 years ago by Mark.Buechler@…

Attachment: myth_eit-bev-dn2_r8925.diff added

Patch which enabled standard/extended guide.

comment:6 Changed 14 years ago by Mark.Buechler@…

I've added a patch I've been using for a while now which fixes the hardcoding used for Dish EIT. However, this requires a DB update which I've implemented as a minor version for my own purposes. It also fixed the EIT crawl to either scan Dish EIT transports or all transports selectable through mythtv-setup. Furthermore it fixes the EIT craw to only scan unique transports instead of channels. It also adds a setting for the EIT craw start after idle timeout.

Someone may or may not find some/all of this usefull.

Changed 14 years ago by greg

Attachment: dishnet_eit_9143.patch added

New dishnet eit patch against 9143

comment:7 Changed 14 years ago by greg

Here is my updated dishnet EIT patch.

This applies cleanly to [9140]. It adds a per card config option to enable supporting the dishnet longterm data as well as moves some of the regular DVB config items to a second page as the first page was getting too cluttered.

comment:8 Changed 14 years ago by greg

Sorry, I meant it applies to [9143]

comment:9 Changed 14 years ago by danielk

(In [9146]) References #1056. Applies greg's latest DishNet? patch.

comment:10 Changed 14 years ago by danielk

Before I close the ticket I have a couple questions:

1/ The dishnet configuration is per source, but you just check it per card in TVRec. Is this safe? i.e. will a card connected to DishNet? never have another input that is connected to a different DVB-S data source (which could of course have ATSC encoded data on PID 0x300)? 2/ Are the dishnet EIT tables documented somewhere? Can I download these documents?

comment:11 Changed 14 years ago by anonymous

I think the WantDishnetEIT call should be per source instead of per card. I know others have had problems pulling BEV guide data if 0x300 is being filtered (see Mark's patch), and with a rotor, both could be used by th same card I guess. Not sure why someone would do that though.

Also, it would be nice to be able to enforce only scanning extended data (as Mark's patch did), as there is no point in getting now/next for most people if the extended data is available. I guess someone can create a new ticket with that functionality though.

comment:12 Changed 14 years ago by danielk

(In [9213]) References #1056. Handle DishNet? EIT more like standard EIT.

comment:13 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.