Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10612 closed Bug Report - General (fixed)

Live TV crash

Reported by: Adam Bennetts <abennetts@…> Owned by: jyavenard
Priority: minor Milestone: 0.25.1
Component: MythTV - General Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Live TV crashes the front end if Live TV is started with time stretch set to 120.

To reproduce:

  1. In Setup, Video, Playback Groups, Default, set the time stretch value to 120.
  2. Start Live TV.
  3. The front end crashes without playing any live TV.
  4. Change the time stretch back to 100 and Live TV works.

My MythTV frontend log with additional logging is attached.

I'm not able to create a backtrace right now but expect to be able to within the week if needed.

Attachments (5)

mythfrontend.log (51.6 KB) - added by Adam Bennetts <abennetts@…> 2 years ago.
Frontend log
myth_version.log (807 bytes) - added by Adam Bennetts <abennetts@…> 2 years ago.
MythTV version info
bt_10612.txt (37.0 KB) - added by stichnot 2 years ago.
Backtrace from a mythfrontend build with various patches; line numbers may vary
mythfrontend.20120416074451.10250.log (29.3 KB) - added by stichnot 2 years ago.
mythavtest.20120416174755.3560.log (55.7 KB) - added by stichnot 2 years ago.

Download all attachments as: .zip

Change History (14)

Changed 2 years ago by Adam Bennetts <abennetts@…>

Frontend log

Changed 2 years ago by Adam Bennetts <abennetts@…>

MythTV version info

comment:1 follow-up: Changed 2 years ago by J.Pilk@…

Where is it supposed to get the data from? It hasn't been transmitted yet.

comment:2 in reply to: ↑ 1 Changed 2 years ago by Adam Bennetts <abennetts@…>

Replying to J.Pilk@…:

Where is it supposed to get the data from? It hasn't been transmitted yet.

Of course. I think the front end should drop time stretch back to 100 and continue. This is what 0.24 did for me. I'm pretty sure 0.24 also did this if you had paused live TV and then caught up using time stretch - time stretch was reduced to 100 once there was no more data. 0.25 playback stutters as it waits for more data and then speeds up and then stutters etc (although possibly a different bug and I haven't tested it much, it may be related).

Possibly I should configure my playback groups differently and not set time stretch to > 100 in the Default play back group (I use default for everything, rightly or wrongly). But even then I don't think (mis) configuring time stretch should be able to crash the front end.

Cheers,
Adam.

comment:3 Changed 2 years ago by J.Pilk@…

Agreed: but a /real/ fix could be quite profitable...

Changed 2 years ago by stichnot

Backtrace from a mythfrontend build with various patches; line numbers may vary

Changed 2 years ago by stichnot

comment:4 Changed 2 years ago by jyavenard

  • Owner set to jyavenard
  • Status changed from new to accepted

comment:5 Changed 2 years ago by Jean-Yves Avenard <jyavenard@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 343e658ee65f6355de87ad0da0c4b57059d80bac/mythtv:

Abort setting timestretch if audio hasn't been initialised yet.

When starting liveTV with timestretch already set, it would cause an uncatched exception error.
Why mythplayer is calling SetStretchFactor? is a mystery to me and needs to be investigated. In the mean time, abort if the number of audio channels is invalid.

Fixes #10612

comment:6 Changed 2 years ago by Jean-Yves Avenard <jyavenard@…>

In e20d1f8e6cb33e7435ba57b25e0e72d6a16c56cd/mythtv:

Abort setting timestretch if audio hasn't been initialised yet.

When starting liveTV with timestretch already set, it would cause an uncatched exception error.
Why mythplayer is calling SetStretchFactor? is a mystery to me and needs to be investigated. In the mean time, abort if the number of audio channels is invalid.

Fixes #10612

[cherry-picked from 343e658ee65f6355de87ad0da0c4b57059d80bac]

Changed 2 years ago by stichnot

comment:7 Changed 2 years ago by Jean-Yves Avenard <jyavenard@…>

In c2fccb545d02808b3d16fb73f52aa92ea75ea719/mythtv:

Make sure passthru flag is in sync between video decoder and audio framework

When entering LiveTV with timestretch enabled via playback group, audio would be broken if watching a channel with AC3 content.
Reason being, audio is set for timestretch, but digital passthrough isn't disabled. We now make sure digital passthrough is disabled should timestretch had been activated earlier on.

Additionally, add the ability to cancel timestretch and audio processing should we revert to a timestretch factor of 1.0. This will only work if no reconfigure is done in between.

Fixes #10612 part 2

comment:8 Changed 2 years ago by Jean-Yves Avenard <jyavenard@…>

In f6e16c4fb14e22232f08d8b826c6186705e41ffc/mythtv:

Make sure passthru flag is in sync between video decoder and audio framework

When entering LiveTV with timestretch enabled via playback group, audio would be broken if watching a channel with AC3 content.
Reason being, audio is set for timestretch, but digital passthrough isn't disabled. We now make sure digital passthrough is disabled should timestretch had been activated earlier on.

Additionally, add the ability to cancel timestretch and audio processing should we revert to a timestretch factor of 1.0. This will only work if no reconfigure is done in between.

Fixes #10612 part 2

[cherry-picked from c2fccb545d02808b3d16fb73f52aa92ea75ea719]

comment:9 Changed 2 years ago by wagnerrp

  • Milestone changed from unknown to 0.25.1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.